On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: > HW pool manager e.g. Octeontx SoC demands s/w to program start and end > address of pool. Currently, there is no such api in external mempool. > Introducing rte_mempool_ops_register_memory_area api which will let HW(pool > manager) to know when common layer selects hugepage: > For each hugepage - Notify its start/end address to HW pool manager. > > Signed-off-by: Santosh Shukla <santosh.shu...@caviumnetworks.com> > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > [...] > > +/** > + * @internal wrapper for mempool_ops register_memory_area callback. > + * API to notify the mempool handler if a new memory area is added to pool. > + *
if -> when > + * Mempool handler usually get notified once for the case of mempool get full > + * range of memory area. However, if several memory areas exist then mempool > + * handler gets notified each time. Not sure I understand this last paragraph. > + * > + * @param mp > + * Pointer to the memory pool. > + * @param vaddr > + * Pointer to the buffer virtual address > + * @param paddr > + * Pointer to the buffer physical address > + * @param len > + * Pool size Minor: missing dot at the end > + * @return > + * - 0: Success; > + * - ENOTSUP: doesn't support register_memory_area ops (valid error case). Missing minus before ENOTSUP. The dot should be a semicolon instead.
