On 25/9/2017 3:43 AM, Wu, Jingjing wrote:

-----Original Message-----
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt
Sent: Saturday, August 26, 2017 12:02 AM
To: dev@dpdk.org
Cc: Hunt, David <david.h...@intel.com>; Marjanovic, Nemanja
<nemanja.marjano...@intel.com>; Sexton, Rory <rory.sex...@intel.com>
Subject: [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id to PF Id

Need a way to convert a vf id to a pf id on the host so as to query the pf for
relevant statistics which are used for the frequency changes in the
vm_power_manager app. Used when profiles are passed down from the guest
to the host, allowing the host to map the vfs to pfs.

Signed-off-by: Nemanja Marjanovic <nemanja.marjano...@intel.com>
Signed-off-by: Rory Sexton <rory.sex...@intel.com>
Signed-off-by: David Hunt <david.h...@intel.com>
---
  drivers/net/i40e/i40e_ethdev.c |  1 +
  drivers/net/i40e/i40e_rxtx.c   | 27 +++++++++++++++++++++++++++
  drivers/net/i40e/i40e_rxtx.h   |  1 +
  lib/librte_ether/rte_ethdev.h  | 11 +++++++++++
  4 files changed, 40 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5f26e24..8fb67d8 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -445,6 +445,7 @@ static const struct rte_pci_id pci_id_i40e_map[] = {  };

  static const struct eth_dev_ops i40e_eth_dev_ops = {
+       .vfid_to_pfid                 = i40e_vf_mac_to_vsi,
        .dev_configure                = i40e_dev_configure,
        .dev_start                    = i40e_dev_start,
        .dev_stop                     = i40e_dev_stop,
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
d42c23c..1379d5e 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -806,6 +806,33 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf
**rx_pkts, uint16_t nb_pkts)
        return nb_rx;
  }

+uint64_t
+i40e_vf_mac_to_vsi(struct rte_eth_dev *dev, uint64_t vfid) {
+       struct ether_addr *vf_mac_addr = (struct ether_addr *)&vfid;
+       struct ether_addr *mac;
+       struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
dev_private);
+       int vsi_id = 0, i, x;
+       struct i40e_pf_vf *vf;
+       uint16_t vf_num = pf->vf_num;
+
+       for (x = 0; x < vf_num; x++) {
+               int mac_addr_matches = 1;
+               vf = &pf->vfs[x];
+               mac = &vf->mac_addr;
+
+               for (i = 0; i < ETHER_ADDR_LEN; i++) {
+                       if (mac->addr_bytes[i] != vf_mac_addr->addr_bytes[i])
+                               mac_addr_matches = 0;
+               }
+               if (mac_addr_matches) {
+                       vsi_id = vf->vsi->vsi_id;
+                       return vsi_id;
+               }
vsi and vsi_id is not a common concept in API level.

Agreed. We're removing from the API level in next patch set version.

How about just return vf_id and rename the function like 
i40e_query_vf_id_by_mac?
In i40e driver, we can get the vsi_id by vf_id.

The next revision will just return the vf_id, and we'll rename the function.

+       }
+
+       return -1;
It's an ops to API, you need to use error code but not -1.

Will fix.

Thanks,
Dave,

Reply via email to