Re: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-20 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > Sent: Sunday, September 3, 2017 2:30 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; Tan, Jianfeng ; > Wu, Jingjing ; Hu, Jiayu > Subject: [dpdk-dev] [PATCH v3] app/testpmd: enable

Re: [dpdk-dev] [PATCH v4 2/5] gso: add TCP/IPv4 GSO support

2017-09-20 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > Sent: Tuesday, September 19, 2017 3:33 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Kavanagh, Mark > B ; Tan, Jianfeng ; > Yigit, Ferruh ; tho...@monjalon.net; Hu, Jiayu > > Subject: [dpdk-dev] [P

[dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-09-20 Thread Slawomir Mrozowicz
Overrunning array schedcore of 128 8-byte elements at element index 128 using index lcore_id. Fixed by correct check index lcoreid condition and change type of lcoreid to unsigned. Coverity issue: 143459 Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") Cc: ian.be...@intel

[dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-09-20 Thread Slawomir Mrozowicz
Overrunning array schedcore of 128 8-byte elements at element index 128 using index lcoreid. Fixed by correct check index lcoreid condition. Coverity issue: 143461 Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") Cc: ian.be...@intel.com Cc: sta...@dpdk.org Signed-off-by:

Re: [dpdk-dev] [PATCH v4 0/5] net/mlx5 multi-process support

2017-09-20 Thread Nélio Laranjeiro
On Tue, Sep 19, 2017 at 10:31:47PM +0800, Xueming Li wrote: > This patchset enhances Mellanox multi-process by supporting all multi-process > examples, also support reading ethdev (x)stats in secondary process. > > Start from V2, this patchset depends on upstream rdma-core enhancement > and l2fork

[dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-09-20 Thread Slawomir Mrozowicz
Overrunning array per_lcore_this_sched->current_lthread->tls->data of 1024 8-byte elements at element index 1024 using index k. Fixed by correct check k condition. Coverity issue: 143462 Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") Cc: ian.be...@intel.com Cc: sta...@d

Re: [dpdk-dev] [PATCH 3/3] maintainers: add Ferruh for main branch

2017-09-20 Thread Ferruh Yigit
On 9/19/2017 9:23 PM, Thomas Monjalon wrote: > Ferruh will co-maintain the main branch at git://dpdk.org/dpdk. > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] net/ixgbe: fix VFIO interrupt mapping in PF

2017-09-20 Thread Wei Dai
When a PF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in ixgbe_dev_init( ). In ixgbe_dev_start(), if previous VFIO interrupt mapping set in ixgbe_dev_init( ) is not cleard, it will fail when calling rte_intr_enable( ) tries to map Rx queue interrupt to other V

[dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-09-20 Thread Slawomir Mrozowicz
Overrunning array per_lcore_this_sched->current_lthread->tls->data of 1024 8-byte elements at element index 1024 using index k. Fixed by correct check k condition. Coverity issue: 143463 Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") Cc: ian.be...@intel.com Cc: sta...@d

[dpdk-dev] [PATCH] service: fix compilation error

2017-09-20 Thread Yi Yang
CC rte_service.o ./dpdk/lib/librte_eal/common/rte_service.c: In function ‘rte_service_start_with_defaults’: ./dpdk/lib/librte_eal/common/rte_service.c:449:9: error: ‘ids[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ret = rte_service_map_lcore_set

[dpdk-dev] [PATCH] vhost: fix vhost_user_set_mem_table error

2017-09-20 Thread Yi Yang
Usually vhost_user message VHOST_USER_SET_MEM_TABLE is only sent out during initialization and only sent once, but it isn't so for memory hotplug and hotunplug , for that case, vhost_user message VHOST_USER_SET_MEM_TABLE will be resent with the old memory regions (not hotunplugged) and the new memo

[dpdk-dev] [PATCH v2 2/2] net/i40e: add support for raw flow type for flow director

2017-09-20 Thread Kirill Rybalchenko
When addidng flow director filter for raw flow type, instead of constructing packet use buffer with pre-constructed packet. Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/i40e_fdir.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v2 1/2] ethdev: add support for raw flow type for flow director

2017-09-20 Thread Kirill Rybalchenko
Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow to support filter for raw flow type Signed-off-by: Kirill Rybalchenko --- lib/librte_ether/rte_eth_ctrl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_c

[dpdk-dev] [PATCH v2 0/2] ethdev: add support for raw flow type for flow director

2017-09-20 Thread Kirill Rybalchenko
For complex packets use raw flow type with pre-constructed packet buffer instead of creating a packet internally in PMD. v2: Fixed code style, comment added Kirill Rybalchenko (2): ethdev: add support for raw flow type for flow director net/i40e: add support for raw flow type for flow directo

Re: [dpdk-dev] [PATCH] service: fix compilation error

2017-09-20 Thread Van Haaren, Harry
> From: Yang, Yi Y > Sent: Wednesday, September 20, 2017 9:31 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Yang, Yi Y > Subject: [PATCH] service: fix compilation error > > CC rte_service.o > ./dpdk/lib/librte_eal/common/rte_service.c: In function > ‘rte_service_start_with_defaults’: >

Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class

2017-09-20 Thread Burakov, Anatoly
Hi Santosh, On 19-Sep-17 6:29 PM, santosh wrote: Hi Anatoly, On Tuesday 19 September 2017 10:07 PM, Burakov, Anatoly wrote: On 18-Sep-17 11:42 AM, Santosh Shukla wrote: Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova

[dpdk-dev] [PATCH v4] devtools: rework abi checker script

2017-09-20 Thread Olivier Matz
The initial version of the script had some limitations: - cannot work on a non-clean workspace - environment variables are not documented - no compilation log in case of failure - return success even it abi is incompatible This patch addresses these issues and rework the code. Signed-off-by: Oliv

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-20 Thread Basierski, SebastianX
Hi, Thank you for those fixes. > -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:47 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Unchecked return value from library > > Check retu

Re: [dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-20 Thread Basierski, SebastianX
> -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:41 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Buffer not null terminated > > Fix calling strncpy with the a maximum size equal of

Re: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped

2017-09-20 Thread Ananyev, Konstantin
Hi Wei, > > When an i40e PF port is stopped, all mirror rules should be removed. > All rule related software and hardware resources should also be > removed. Could you clarify why we have to remove all mirror rules when PF is stopped? As I remember mirror rule can direct to VF, which still can b

[dpdk-dev] [PATCH] net/virtio: fix of untrusted scalar value

2017-09-20 Thread Daniel Mrzyglod
The unscrutinized value may be incorrectly assumed to be within a certain range by later operations. In vhost_user_read: An unscrutinized value from an untrusted source used in a trusted context - the value of sz_payload may be harmfull and we need limit them to the max value of payload. Fixes: 6

Re: [dpdk-dev] [PATCH] net/virtio: fix of untrusted scalar value

2017-09-20 Thread Mrzyglod, DanielX T
This patch is for Coverity issue: 139601 Does it need v2 for updating Message Body ?

[dpdk-dev] [PATCH v3 0/3] Extend DES support

2017-09-20 Thread Pablo de Lara
This patchset extends the support of DES algorithms to the AESNI MB and OpenSSL PMDs. For AESNI MB PMD, the following algorithms are added: - DES-CBC - DES-DOCSISBPI For OpenSSL PMD, DES-CBC is added, as DES-DOCSISBPI was already supported. Changes in v3: - Added release note for support for DES

[dpdk-dev] [PATCH v3 1/3] crypto/aesni_mb: add DES support

2017-09-20 Thread Pablo de Lara
The Multi-buffer library now supports DES-CBC and DES-DOCSISBPI algorithms, so this commit extends adds support for them in the PMD. Signed-off-by: Pablo de Lara Acked-by: Fan Zhang Reviewed-by: Radu Nicolau --- doc/guides/cryptodevs/aesni_mb.rst | 2 + doc/guides/cryptodevs/feat

Re: [dpdk-dev] [PATCH] net/virtio: fix of untrusted scalar value

2017-09-20 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Mrzyglod, DanielX T > Sent: Wednesday, September 20, 2017 5:19 PM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; Mrzyglod, DanielX T; Tan, Jianfeng > Subject: [PATCH] net/virtio: fix of untrusted scalar value > > The unscrutinized value may be incorrectly

[dpdk-dev] [PATCH v3 3/3] app/crypto-perf: fix packet length check

2017-09-20 Thread Pablo de Lara
When using DES-CBC, packet size has to be multiple of 8 bytes, but if a list of packets is provided. the check was not correct. Fixes: fc4600fb2520 ("app/crypto-perf: add extra option checks") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Radu Nicolau --- app/test-crypto-perf/cpe

[dpdk-dev] [PATCH v3 2/3] crypto/openssl: add support for DES-CBC

2017-09-20 Thread Pablo de Lara
Signed-off-by: Pablo de Lara Acked-by: Radu Nicolau --- doc/guides/rel_notes/release_17_11.rst | 6 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 27 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 20 test/test/test_cryptodev.c

Re: [dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-20 Thread Tan, Jianfeng
> -Original Message- > From: Basierski, SebastianX > Sent: Wednesday, September 20, 2017 5:20 PM > To: Tan, Jianfeng; skh...@vmware.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] pmd_virtio: Buffer not null terminated > ... > > > Hi, > > I don't understand. > Are You asking me to send

Re: [dpdk-dev] [PATCH 05/11] lib/librte_mbuf: add security crypto flags and mbuf fields

2017-09-20 Thread Olivier MATZ
Hi Boris, Some comments inline. On Mon, Sep 18, 2017 at 07:54:03AM +, Boris Pismenny wrote: > Hi Olivier, > > On 9/14/2017 11:27 AM, Akhil Goyal wrote: > > > > From: Boris Pismenny > > > > add security crypto flags and update mbuf fields to support > > IPsec crypto offload for transmitted

[dpdk-dev] [PATCH v3 1/5] app/testpmd: add traffic management forwarding mode

2017-09-20 Thread Jasvinder Singh
This commit extends the testpmd application with new forwarding engine that demonstrates the use of ethdev traffic management APIs and softnic PMD for QoS traffic management. In this mode, 5-level hierarchical tree of the QoS scheduler is built with the help of ethdev TM APIs such as shaper profil

[dpdk-dev] [PATCH v3 3/5] app/test-pmd: add CLI for shaper and wred profiles

2017-09-20 Thread Jasvinder Singh
Add following CLIs in testpmd application; - commands to add/del shaper profile for TM hieraqrchy nodes. - commands to add/update shared shapers - commands to add/del WRED profiles for TM hiearchy leaf nodes. Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline.c| 41 +++ app/test-pmd/cm

[dpdk-dev] [PATCH v3 2/5] app/test-pmd: add CLI for TM capability and stats

2017-09-20 Thread Jasvinder Singh
Add following CLIs to testpmd application; - commands to display TM capability information. (per port, per hierarchy level and per hierarchy node) - command to display hiearchy node type - stats collection Signed-off-by: Jasvinder Singh --- v3 change: - Implements feedback from Pablo[1] - move

[dpdk-dev] [PATCH v3 4/5] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-09-20 Thread Jasvinder Singh
Add following CLIs in testpmd application; - commands to add TM hierarchy nodes (leaf and nonleaf). - command for runtime update of node weight. - command to commit the TM hierarchy Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline.c| 36 +++ app/test-pmd/cmdline_tm.c | 594 ++

[dpdk-dev] [PATCH v3 5/5] app/test-pmd: add CLI for TM packet classification

2017-09-20 Thread Jasvinder Singh
Add following CLIs in testpmd application; - command to set the packet field mask and offset value for classification. - command to set traffic class translation table entry Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline.c| 11 ++ app/test-pmd/cmdline_tm.c | 305 +

[dpdk-dev] [PATCH] crypto/openssl: fix compilation break with openssl 1.1

2017-09-20 Thread Akhil Goyal
hmac APIs are changed in openssl version 1.1. this patch handles both versions of openssl for hmac APIs Fixes: d7174e8f368f ("crypto/openssl: replace evp APIs with HMAC APIs") Signed-off-by: Akhil Goyal --- drivers/crypto/openssl/rte_openssl_pmd.c | 27 drivers

Re: [dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs

2017-09-20 Thread Akhil Goyal
Hi Pablo, On 9/8/2017 7:33 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Tuesday, August 29, 2017 7:59 AM To: dev@dpdk.org; De Lara Guarch, Pablo Cc: hemant.agra...@nxp.com; Doherty, Declan ; Akhil Goyal Subject: [P

Re: [dpdk-dev] [PATCH v2] net/af_packet: make bypass configurable

2017-09-20 Thread Luca Boccassi
On Tue, 2017-09-19 at 17:45 -0400, Chas Williams wrote: > From: "Charles (Chas) Williams" > > In certain situations, low speed interfaces, it may be desirable to > have the flow control provided by the kernel queueing disciplines. > > Signed-off-by: Chas Williams > --- >  drivers/net/af_packet/

[dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Kuba Kozak
Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 3 +

[dpdk-dev] [PATCH] acl: fix unchecked return value

2017-09-20 Thread Kuba Kozak
Add return value check and error handling for fseek call. Coverity issue: 143435 Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- examples/l3fwd-acl/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletio

Re: [dpdk-dev] [PATCH v3 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-20 Thread Timothy M. Redaelli
On 09/13/2017 04:12 PM, Bruce Richardson wrote: [...] > + > +# for static libs, treat the drivers as regular libraries, otherwise > +# for shared libs, put them in a driver folder > +if get_option('default_library') == 'static' > + driver_install_path = get_option('libdir') > +else > + driv

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Burakov, Anatoly
On 20-Sep-17 10:59 AM, Kuba Kozak wrote: Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- Acked-by

[dpdk-dev] [PATCH] linuxapp/eal: fix memory leak

2017-09-20 Thread Yong Wang
In func rte_eal_init(), dynamic memory stored in 'logid' allocated through func 'strdup' is lost when return. Fix it by freeing the memory before return. Signed-off-by: Yong Wang --- lib/librte_eal/linuxapp/eal/eal.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH] net/ixgbe: fix VFIO interrupt mapping in VF

2017-09-20 Thread Wei Dai
When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in ixgbevf_dev_init( ). In ixgbevf_dev_start(), if previous VFIO interrupt mapping set in ixgbevf_dev_init( ) is not cleard, it will fail when calling rte_intr_enable( ) tries to map Rx queue interrupt to o

Re: [dpdk-dev] [PATCH v3 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-20 Thread Bruce Richardson
On Wed, Sep 20, 2017 at 12:10:19PM +0200, Timothy M. Redaelli wrote: > On 09/13/2017 04:12 PM, Bruce Richardson wrote: > [...] > > + > > +# for static libs, treat the drivers as regular libraries, otherwise > > +# for shared libs, put them in a driver folder > > +if get_option('default_library') ==

Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class

2017-09-20 Thread santosh
Hi Anatoly, On Wednesday 20 September 2017 02:39 PM, Burakov, Anatoly wrote: > Hi Santosh, > > On 19-Sep-17 6:29 PM, santosh wrote: >> Hi Anatoly, >> >> >> On Tuesday 19 September 2017 10:07 PM, Burakov, Anatoly wrote: >>> On 18-Sep-17 11:42 AM, Santosh Shukla wrote: Introducing rte_pci_get_

[dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

2017-09-20 Thread Wei Dai
When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound ixgbe VF Rx queue interrupts can be mapped in vector 1. And as current igb_uio only sup

Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-09-20 Thread Ferruh Yigit
On 9/20/2017 4:20 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, September 15, 2017 7:01 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush >> >> On 9/6/2017 10:11 AM, Ferruh Yi

Re: [dpdk-dev] [PATCH v3 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-20 Thread Timothy M. Redaelli
On September 20, 2017 12:24:15 PM GMT+02:00, Bruce Richardson wrote: >On Wed, Sep 20, 2017 at 12:10:19PM +0200, Timothy M. Redaelli wrote: >> On 09/13/2017 04:12 PM, Bruce Richardson wrote: >> [...] >> > + >> > +# for static libs, treat the drivers as regular libraries, >otherwise >> > +# for sha

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush

2017-09-20 Thread Ferruh Yigit
On 9/15/2017 4:13 AM, Wei Zhao wrote: > This feature enable queue regions configuration for RSS in PF/VF, > so that different traffic classes or different packet > classification types can be separated to different queues in > different queue regions.This patch can set queue region range, > it incl

[dpdk-dev] [PATCH] net/ixgbe: fix VFIO interrupt mapping in PF

2017-09-20 Thread Wei Dai
When a PF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in ixgbe_dev_init( ). In ixgbe_dev_start(), if previous VFIO interrupt mapping set in ixgbe_dev_init( ) is not cleard, it will fail when calling rte_intr_enable( ) tries to map Rx queue interrupt to other V

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for configuration of queue region

2017-09-20 Thread Ferruh Yigit
On 9/15/2017 4:13 AM, Wei Zhao wrote: > This patch add a API configuration of queue region in rss. > It can parse the parameters of region index, queue number, > queue start index, user priority, traffic classes and so on. > According to commands from command line, it will call i40e > private API a

[dpdk-dev] [PATCH 0/3] minor build enhancements and fixes

2017-09-20 Thread Bruce Richardson
No major changes, just cleanups. Bruce Richardson (3): build: sort meson options alphabetically build: fix driver install path build/x86: add SSE cpuflags config/x86/meson.build | 10 ++ meson.build| 2 +- meson_options.txt | 24 3 files c

[dpdk-dev] [PATCH 1/3] build: sort meson options alphabetically

2017-09-20 Thread Bruce Richardson
Wrap each entry at the description value to avoid really long lines also. Signed-off-by: Bruce Richardson --- meson_options.txt | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index fb945db91..29b548f5a 100644 --

[dpdk-dev] [PATCH 2/3] build: fix driver install path

2017-09-20 Thread Bruce Richardson
To comply with the "hier" standard [Ref: man 7 hier], the driver .so files should not be placed in $datadir. Therefore we install them in a sub-directory of $libdir instead. Fixes: d123bba2dfbe ("build: add initial infrastructure for meson & ninja builds") Reported-by: Timothy M. Redaelli Signe

[dpdk-dev] [PATCH 3/3] build/x86: add SSE cpuflags

2017-09-20 Thread Bruce Richardson
Previous code only added in AVX, and a few other non-SSE flags to the compile-time cpuflags because all SSE instruction set levels are now required for an x86 build. However, some apps may still be checking for the existing SSE ones in the legacy build system, so add them here for completeness and

Re: [dpdk-dev] [PATCH 02/11] doc: add details of rte security

2017-09-20 Thread Akhil Goyal
Hi Jerin, On 9/18/2017 4:43 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 14 Sep 2017 13:56:42 +0530 From: Akhil Goyal To: dev@dpdk.org CC: declan.dohe...@intel.com, pablo.de.lara.gua...@intel.com, hemant.agra...@nxp.com, radu.nico...@intel.com, bor...@mellanox.com, avia...@

Re: [dpdk-dev] [PATCH 02/11] doc: add details of rte security

2017-09-20 Thread Akhil Goyal
Hi John, On 9/18/2017 9:08 PM, Mcnamara, John wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal Sent: Thursday, September 14, 2017 9:27 AM To: dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; Nicolau, Radu ; bor

Re: [dpdk-dev] [PATCH 00/53] net/qede/base: update PMD to 2.6.0.1

2017-09-20 Thread Ferruh Yigit
On 9/19/2017 2:29 AM, Rasesh Mody wrote: > Hi, > > This patch set adds support for new firmware 8.30.12.0, includes > enahncements, code cleanup and bug fixes. This patch set updates > PMD version to 2.6.0.1. > > Thanks! > Rasesh > > Rasesh Mody (53): > net/qede/base: add NVM config options >

Re: [dpdk-dev] [PATCH] app/testpmd: port info prints dynamically mapped flow types

2017-09-20 Thread Ferruh Yigit
On 9/1/2017 5:23 PM, Kirill Rybalchenko wrote: > Port info command prints information about all supported flow types, > including dynamically mapped ones. > > Signed-off-by: Kirill Rybalchenko > --- > app/test-pmd/config.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > dif

Re: [dpdk-dev] [PATCH v3] mbuf: use refcnt = 0 when debugging

2017-09-20 Thread Olivier MATZ
Hi Chas, On Thu, Sep 07, 2017 at 05:21:51PM -0400, Charles (Chas) Williams wrote: > After commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") is it > much harder to detect a "double free". If the developer makes a copy > of an mbuf pointer and frees it twice, this condition is never detec

[dpdk-dev] [PATCH v9 2/9] eal/pci: get iommu class

2017-09-20 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Patch also adds rte_pci_get_iommu_class definition for: - bsdapp: api returns default iova mode. - linuxapp: Has stub implementation, Followup patch

[dpdk-dev] [PATCH v9 3/9] linuxapp/eal_pci: get iommu class

2017-09-20 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Patch also introduces RTE_PCI_DRV_IOVA_AS_VA drv flag. Flag used when driver needs to operate in iova=va mode. Algorithm for iova scheme selection for PCI bus: 0. If no device bound then return with RTE

[dpdk-dev] [PATCH v9 0/9] Infrastructure to detect iova mapping on the bus

2017-09-20 Thread Santosh Shukla
v9: - Added Tested-By: to series. - Includes minor changes related to linuxapp api stub in [02/09] (Suggested by Anatoly) - Series rebased on tip commit : aee62e90 v8: Includes minor review changes per v7 review comment from Anatoly. Patches rebased on Tip commit:3d2e0448eb. v7: Includes no maj

[dpdk-dev] [PATCH v9 4/9] bus: get iommu class

2017-09-20 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate through bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Mode selection sc

[dpdk-dev] [PATCH v9 1/9] eal/pci: export match function

2017-09-20 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Maxime Coquelin Reviewed-by: Anatoly Burakov Tested-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/commo

[dpdk-dev] [PATCH v9 5/9] eal: introduce helper API for iova mode

2017-09-20 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin Tested-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal

[dpdk-dev] [PATCH v9 6/9] eal: auto detect iova mode

2017-09-20 Thread Santosh Shukla
For auto detection purpose: * Below calls moved up in the eal initialization order: - eal_option_device_parse - rte_bus_scan Based on the result of rte_bus_scan_iommu_class - select iova mapping mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime C

[dpdk-dev] [PATCH v9 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-09-20 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin Acked-by: Anatoly Burakov Tested-by: Hemant Agrawal --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 delet

[dpdk-dev] [PATCH v9 9/9] eal/rte_malloc: honor iova mode in virt2phy

2017-09-20 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin Reviewed-by: Anatoly Burakov Tested-by: Hemant Agrawal --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v9 8/9] linuxapp/eal_memory: honor iova mode in virt2phy

2017-09-20 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin Reviewed-by: Anatoly Burakov Tested-by: Hemant Agrawal --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/li

Re: [dpdk-dev] [PATCH 2/3] build: fix driver install path

2017-09-20 Thread Bruce Richardson
+Timothy, since git doesn't seem to automatically add reporters on CC. On Wed, Sep 20, 2017 at 11:51:06AM +0100, Bruce Richardson wrote: > To comply with the "hier" standard [Ref: man 7 hier], the driver .so files > should not be placed in $datadir. Therefore we install them in a > sub-directory o

[dpdk-dev] [PATCH v2 2/2] test/ring: do not mask result of enqueue or dequeue

2017-09-20 Thread Olivier Matz
The define RTE_RING_SZ_MASK is the maximum size supported by the rte_ring. The size is checked at ring creation. There is no reason today to mask the result of rte_ring_sp_enqueue_burst() or rte_ring_sc_dequeue_burst() with this value. The flag RTE_RING_QUOT_EXCEED was previously included in the r

[dpdk-dev] [PATCH v2 1/2] ring: increase maximum ring size

2017-09-20 Thread Olivier Matz
There is no reason to prevent ring from being larger than 0x0FFF. Increase the maximum size to 0x7FFF, which is the maximum possible without changing the code and the structure definition (size is stored on a uint32_t). Link: http://dpdk.org/ml/archives/dev/2017-September/074701.html Sugg

Re: [dpdk-dev] [PATCH 01/11] lib/rte_security: add security library

2017-09-20 Thread Akhil Goyal
Hi Hemant, On 9/15/2017 11:02 AM, Hemant Agrawal wrote: Hi, On 9/14/2017 1:56 PM, Akhil Goyal wrote: .. diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c new file mode 100644 index 000..5776246 --- /dev/null +++ b/lib/librte_security/rte_security.c @@ -0

Re: [dpdk-dev] [PATCH v9 2/9] eal/pci: get iommu class

2017-09-20 Thread Burakov, Anatoly
On 20-Sep-17 12:23 PM, Santosh Shukla wrote: Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Patch also adds rte_pci_get_iommu_class definition for: - bsdapp: api returns default iova mode. - lin

Re: [dpdk-dev] [PATCH] lib/librte_pipeline:fix the array index out of bound

2017-09-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Rongqiang XIE [mailto:xie.rongqi...@zte.com.cn] > Sent: Wednesday, August 23, 2017 8:06 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Rongqiang XIE > Subject: [PATCH] lib/librte_pipeline:fix the array index out of bound > > In function rte_pipeline_comp

Re: [dpdk-dev] [PATCH 0/3] minor build enhancements and fixes

2017-09-20 Thread Luca Boccassi
On Wed, 2017-09-20 at 11:51 +0100, Bruce Richardson wrote: > No major changes, just cleanups. > > Bruce Richardson (3): >   build: sort meson options alphabetically >   build: fix driver install path >   build/x86: add SSE cpuflags > >  config/x86/meson.build | 10 ++ >  meson.build   

Re: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and delete functions

2017-09-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, September 18, 2017 4:30 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: RE: [dpdk-d

Re: [dpdk-dev] [PATCH v7] net/mlx5: support upstream rdma-core

2017-09-20 Thread Nélio Laranjeiro
On Mon, Sep 18, 2017 at 02:49:52PM +, Shachar Beiser wrote: > This removes the dependency on specific Mellanox OFED libraries by > using the upstream rdma-core and linux upstream community code. > Both rdma-core upstream and Mellanox OFED are Linux user-space packages: > 1. Rdma-core is Linux

Re: [dpdk-dev] [PATCH v5 2/6] librte_table: fix acl lookup function

2017-09-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, September 7, 2017 5:43 PM > To: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > ; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH v5 2/6] librte_table: fi

Re: [dpdk-dev] [PATCH 0/3] minor build enhancements and fixes

2017-09-20 Thread Bruce Richardson
On Wed, Sep 20, 2017 at 01:05:19PM +0100, Luca Boccassi wrote: > On Wed, 2017-09-20 at 11:51 +0100, Bruce Richardson wrote: > > No major changes, just cleanups. > > > > Bruce Richardson (3): > >   build: sort meson options alphabetically > >   build: fix driver install path > >   build/x86: add SS

[dpdk-dev] [PATCH] doc: add Linux flower support check in TAP guide

2017-09-20 Thread Thomas Monjalon
The flow API is supported in TAP PMD if flower is supported in Linux. Some commands are combined to suggest a convenient check of its support by the running kernel. Signed-off-by: Thomas Monjalon --- doc/guides/nics/tap.rst | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --gi

Re: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP guide

2017-09-20 Thread Pascal Mazon
Acked-by: Pascal Mazon On 20/09/2017 15:03, Thomas Monjalon wrote: > The flow API is supported in TAP PMD if flower is supported in Linux. > Some commands are combined to suggest a convenient check of its support > by the running kernel. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/nic

Re: [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal

2017-09-20 Thread Dumitrescu, Cristian
Hi Pavan, I think moving rte_reciprocal.[hc] to a common code area like EAL is a very good idea, so thanks for doing this work! One ask from my side: please do not change the existing code. 1. Keep the existing name for the 32-bit API functions and data structures (no _u32 name suffix), add the

[dpdk-dev] [PATCH v3] sched: make RED scaling configurable

2017-09-20 Thread alangordondewar
From: Alan Dewar The RED code stores the maximum threshold is a 32-bit integer as a pseudo fixed-point floating number with 10 fractional bits. Twelve other bits are used to encode the filter weight, leaving just 10 bits for the queue length. This limits the maximum queue length supported by RE

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-20 Thread Dumitrescu, Cristian
Hi Pavan, Same ask as for the first patch: -Do not change existing code in rte_reciprocal.[hc]: no _u32 suffix, please -Do not add lots of CR+LF to existing code > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, September 6, 2017 11:2

Re: [dpdk-dev] [PATCH v2] net/af_packet: make bypass configurable

2017-09-20 Thread Ferruh Yigit
On 9/19/2017 10:45 PM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > In certain situations, low speed interfaces, it may be desirable to > have the flow control provided by the kernel queueing disciplines. Out of curiosity, do you have any compression of performance numbers with and

Re: [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal

2017-09-20 Thread Pavan Nikhilesh Bhagavatula
On Wed, Sep 20, 2017 at 01:10:53PM +, Dumitrescu, Cristian wrote: > Hi Pavan, Hi Cristian, > > I think moving rte_reciprocal.[hc] to a common code area like EAL is a very > good idea, so thanks for doing this work! > > One ask from my side: please do not change the existing code. > 1. Keep the

Re: [dpdk-dev] [PATCH 1/2] eal: move bitmap from lib sched

2017-09-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, September 7, 2017 3:40 PM > To: Dumitrescu, Cristian ; > step...@networkplumber.org > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 1/2] eal: move bitmap from lib sched

[dpdk-dev] [PATCH v2] net/virtio: fix of untrusted scalar value

2017-09-20 Thread Daniel Mrzyglod
The unscrutinized value may be incorrectly assumed to be within a certain range by later operations. In vhost_user_read: An unscrutinized value from an untrusted source used in a trusted context - the value of sz_payload may be harmfull and we need limit them to the max value of payload. Coverity

Re: [dpdk-dev] [PATCH 1/2] eal: move bitmap from lib sched

2017-09-20 Thread Pavan Nikhilesh Bhagavatula
On Wed, Sep 20, 2017 at 01:27:41PM +, Dumitrescu, Cristian wrote: > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, September 7, 2017 3:40 PM > > To: Dumitrescu, Cristian ; > > step...@networkplumber.org > > Cc: dev@dpdk.org; P

[dpdk-dev] [PATCH v5 0/5]

2017-09-20 Thread Harry van Haaren
This patchset refactors the eventdev API to be more flexible and capable. In particular, the API is capable of returning an error value if an invalid device, port or attribute ID is passed in, which was not possible with the previous APIs. The implementation of this patchset is based on a v1 patch

[dpdk-dev] [PATCH v5 1/5] eventdev: add port attribute function

2017-09-20 Thread Harry van Haaren
This commit reworks the port functions to retrieve information about the port, like the enq or deq depths. Note that "port count" is a device attribute, and is added in a later patch for dev attributes. Signed-off-by: Harry van Haaren --- v4: feedback from http://dpdk.org/dev/patchwork/patch/28

[dpdk-dev] [PATCH v5 3/5] eventdev: add queue attribute function

2017-09-20 Thread Harry van Haaren
This commit adds a generic queue attribute function. It also removes the previous rte_event_queue_priority() and priority() functions, and updates the map files and unit tests to use the new attr functions. Signed-off-by: Harry van Haaren --- v4: [feedback http://dpdk.org/dev/patchwork/patch/28

[dpdk-dev] [PATCH v5 2/5] eventdev: add dev attribute get function

2017-09-20 Thread Harry van Haaren
This commit adds a device attribute function, allowing flexible fetching of device attributes, like port count or queue count. The unit tests and .map file are updated to the new function. Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob --- v4: [feedback http://dpdk.org/dev/patchwork/pat

[dpdk-dev] [PATCH v5 4/5] eventdev: add device started attribute

2017-09-20 Thread Harry van Haaren
This commit adds an attribute to the eventdev, allowing applications to retrieve if the eventdev is running or stopped. Note that no API or ABI changes were required in adding the statistic, and code changes are minimal. Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob --- lib/librte_event

[dpdk-dev] [PATCH v5 5/5] eventdev: bump library version

2017-09-20 Thread Harry van Haaren
This commit bumps the library version to refect the ABI change caused by removing the individual rte_event_port_count, queue_count, and other get functions. These functions are superseded by the get-attribute style API, which allows fetching values without API/ABI changes. Signed-off-by: Harry van

Re: [dpdk-dev] [PATCH 1/2] net/bonding: rename map file to standard name

2017-09-20 Thread Ferruh Yigit
On 9/14/2017 4:57 PM, Bruce Richardson wrote: > Naming convention for net drivers is "rte_pmd__version.map" > > Signed-off-by: Bruce Richardson Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 2/2] net/xenvirt: rename map file to standard name

2017-09-20 Thread Ferruh Yigit
On 9/14/2017 4:57 PM, Bruce Richardson wrote: > Naming convention for net drivers is "rte_pmd__version.map" > > Signed-off-by: Bruce Richardson This one not get, because xenvirt will be removed this release.

Re: [dpdk-dev] [PATCH v5] ethdev: add return code to rte_eth_stats_reset()

2017-09-20 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > On 9/1/2017 3:26 AM, David Harton wrote: > > Some devices do not support reset of eth stats. An application may > > need to know not to clear shadow stats if the device cannot. > > > > rte_eth_stats_reset is u

  1   2   >