Re: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: add new PMD benchmarking mode

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, September 12, 2017 10:36 AM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [PATCH v2 2/2] app/crypto-perf: add new PMD benchmarking > mode > > This patch adds a new benchmarking mode, which is

Re: [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t

2017-09-18 Thread Burakov, Anatoly
Hi Santosh, On 14-Aug-17 4:15 PM, Santosh Shukla wrote: Signed-off-by: Santosh Shukla --- v1 note: - As changes percolate to all possible dpdk subsystem.. so its difficult to tag subject with one common title, but since, core of changeset is at eal layer so keeping 'eal:' as title.

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Thursday, September 14, 2017 12:53 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Wu, Jingjing > > Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode > > Add followin

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add DES support

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Monday, September 18, 2017 11:56 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add DES support > > > > On 9/15/2017 3:09 AM, Pablo de Lara wrote: > > Th

Re: [dpdk-dev] [PATCH v2 1/6] net/i40e: support RSS for GTP-C and GTP-U

2017-09-18 Thread Bruce Richardson
On Thu, Sep 07, 2017 at 07:20:58PM +0800, Beilei Xing wrote: > GTP-C and GTP-U are supported by new profile. > Enable RSS for GTP-C and GTP-U after downloading > profile. > > Signed-off-by: Beilei Xing > --- I get compilation errors when applying this patch. /Bruce CC i40e_ethdev.o /home/bruc

Re: [dpdk-dev] [PATCH v2 1/6] net/i40e: support RSS for GTP-C and GTP-U

2017-09-18 Thread Bruce Richardson
On Mon, Sep 18, 2017 at 03:17:43PM +0100, Bruce Richardson wrote: > On Thu, Sep 07, 2017 at 07:20:58PM +0800, Beilei Xing wrote: > > GTP-C and GTP-U are supported by new profile. > > Enable RSS for GTP-C and GTP-U after downloading > > profile. > > > > Signed-off-by: Beilei Xing > > --- > I get c

Re: [dpdk-dev] [PATCH 1/4] bus/dpaa: scan for DPAA Crypto devices

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agra...@nxp.com; Akhil Goyal > > Subject: [PATCH 1/4] bus/dpaa: scan for DPAA Cry

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-18 Thread Shahaf Shuler
Monday, September 18, 2017 2:38 PM, Bruce Richardson > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > 18/09/2017 13:11, Ananyev, Konstantin: > > > From: Richardson, Bruce > > > > > > > > > > I think we all in favor to have a separate API here. > > > > > Though from the discuss

Re: [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t

2017-09-18 Thread santosh
On Monday 18 September 2017 07:36 PM, Burakov, Anatoly wrote: > Hi Santosh, > > On 14-Aug-17 4:15 PM, Santosh Shukla wrote: >> Signed-off-by: Santosh Shukla >> --- >> v1 note: >> - As changes percolate to all possible dpdk subsystem.. >>so its difficult to tag subject with one common title, >

Re: [dpdk-dev] [PATCH 4/4] doc: add NXP DPAA SEC

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agra...@nxp.com; Akhil Goyal > > Subject: [PATCH 4/4] doc: add NXP DPAA SEC > >

Re: [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t

2017-09-18 Thread Burakov, Anatoly
Why was this added? (This also causes a compile issue according to build automation) Thanks, Anatoly Never mind, didn't notice v2 was out :/

Re: [dpdk-dev] [PATCH v2 0/6] NXP DPAA2: Refactor bus scan/probe code

2017-09-18 Thread santosh
On Monday 11 September 2017 07:36 PM, Ferruh Yigit wrote: > On 8/25/2017 11:19 AM, Shreyansh Jain wrote: >> Change Log: >> ~~~ >> v2: >>- Minor updates for logging (removed some logs and changed others >> to make it cleaner when application starts) >> >> Brief: >> ~~ >> >> -

[dpdk-dev] [PATCH v3 4/6] net/mlx5: remove verbs fork check

2017-09-18 Thread Xueming Li
Verbs API prohibited resources inheritance by default, this further disabled PMD forked secondary process that replis on memory inherited from parent process. This patch removes verbs fork check to enable DPDK forked process. Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net

[dpdk-dev] [PATCH v3 3/6] net/mlx5: allocate verbs object into shared memory

2017-09-18 Thread Xueming Li
PMD uses Verbs object which were not available in the shared memory. This patch modify the location where Verbs objects are allocated (from process memory address space to shared memory address space) and thus allow a secondary process to use those object by mapping this shared memory space its ow

[dpdk-dev] [PATCH v3 0/6] net/mlx5 multi-process support

2017-09-18 Thread Xueming Li
This patchset enhances Mellanox multi-process by supporting all multi-process examples, also support reading ethdev (x)stats in secondary process. Start from V2, this patchset depends on upstream rdma-core enhancement and l2fork example bug fix: http://www.dpdk.org/ml/archives/dev/2017-August/073

[dpdk-dev] [PATCH v3 6/6] net/mlx5: multi-process document update

2017-09-18 Thread Xueming Li
This patch update the feature list and NIC guide to be multi-process enabled. Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/ni

[dpdk-dev] [PATCH v3 1/6] net/mlx5: change eth device reference for secondary process

2017-09-18 Thread Xueming Li
rte_eth_dev created by primary process were not available in secondary process, it was not possible to use the primary process local memory object from a secondary process. This patch modify the reference of primary rte_eth_dev object, use local rte_eth_dev secondary process instead. Signed-off-b

[dpdk-dev] [PATCH v3 2/6] net/mlx5: install a socket to exchange a file descriptor

2017-09-18 Thread Xueming Li
Use a unix socket to get back the communication channel with the Kernel driver from the primary process, this is necessary to remap those pages in the secondary process memory space and thus use the same Tx queues. This is only supported from rdma-core (v15). Signed-off-by: Nelio Laranjeiro Sign

[dpdk-dev] [PATCH v3 5/6] net/mlx5: add operations for secondary process

2017-09-18 Thread Xueming Li
Add operations that are safe for secondary processes: * (x)stats * device info get * rx/tx descriptor status Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c| 16 +++- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 11

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-18 Thread Thomas Monjalon
18/09/2017 16:27, Shahaf Shuler: > Monday, September 18, 2017 2:38 PM, Bruce Richardson > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > > 18/09/2017 13:11, Ananyev, Konstantin: > > > > From: Richardson, Bruce > > > > > > > > > > > > I think we all in favor to have a separat

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-18 Thread Bruce Richardson
On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote: > Monday, September 18, 2017 2:38 PM, Bruce Richardson > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > > 18/09/2017 13:11, Ananyev, Konstantin: > > > > From: Richardson, Bruce > > > > > > > > > > > > I think we

Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal <...> > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map > b/drivers/bus/dpaa/rte_bus_dpaa_version.map > new file mode 100644 > index 000..d97a009 > --- /dev/null > +++ b/drive

Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > From: Hemant Agrawal > > Linked list, bit operations and compatibility macros. > > Signed-off-by: Geoff Thorpe > Signed-off-by: Hemant Agrawal <...> > diff --git a/drivers/bus/dpaa/include/compat.h > b/drivers/bus/dpaa/include/compat.h > new fil

Re: [dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > This layer is used by Bus driver's scan function. Devices are parsed > using OF parser and added to DPAA device list. So this is device tree parser in DPDK. Do we really want this, and as long as DPDK target the bare metal why not get device informatio

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes

2017-09-18 Thread Bruce Richardson
On Thu, Sep 07, 2017 at 02:45:27PM +0300, Vladimir Kuramshin wrote: > Current version is compatible with PQOS version 1.3 > but not compatible with higher versions. This change > makes l2fwd-cat example compatible with versions since 1.4 > > Signed-off-by: Vladimir Kuramshin > --- > Version 2 cha

[dpdk-dev] [PATCH v7] net/mlx5: support upstream rdma-core

2017-09-18 Thread Shachar Beiser
This removes the dependency on specific Mellanox OFED libraries by using the upstream rdma-core and linux upstream community code. Both rdma-core upstream and Mellanox OFED are Linux user-space packages: 1. Rdma-core is Linux upstream user-space package.(Generic) 2. Mellanox OFED is Mellanox's

Re: [dpdk-dev] [PATCH v4 05/41] bus/dpaa: introducing FMan configurations

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > FMan or Frame Manager, inspects traffic, splits it into queueson ingress. > It is also responsible for directing traffic on queues on egress. > > This patch introduces FMan configurational interfaces. This layer is > used by Bus driver for configuring

Re: [dpdk-dev] [PATCH v4 07/41] bus/dpaa: enable DPAA IOCTL portal driver

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > Userspace applications interact with DPAA blocks using this IOCTL driver. > > Signed-off-by: Geoff Thorpe > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +static int fd = -1; > +static pthread_mutex_t fd_init_lock = PTHREAD

Re: [dpdk-dev] [PATCH v4 13/41] bus/dpaa: add support for FMAN frame queue lookup

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Geoff Thorpe > Signed-off-by: Roy Pledge > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > > +#if !defined(CONFIG_FSL_QMAN_FQ_LOOKUP) && defined(RTE_ARCH_ARM64) > +#error "_ARM64 requires _FSL_QMAN_FQ_LOOKUP"

Re: [dpdk-dev] [PATCH v4 11/41] bus/dpaa: add QMan driver core routines

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Geoff Thorpe > Signed-off-by: Roy Pledge > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +#ifdef RTE_LIBRTE_DPAA_CHECKING This is not defined anywhere, it looks this will come from config file in further patc

Re: [dpdk-dev] [PATCH v4 17/41] doc: add NXP DPAA PMD documentation

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +Config File Options > +~~~ > + > +The following options can be modified in the ``config`` file. > +Please note that enabling debugging options may affect system p

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > + for (loop = 0; loop < num_cores; loop++) { > + ret = dpaa_tx_queue_init(&dpaa_intf->tx_queues[loop], > + fman_intf); > +

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-18 Thread Laatz, Kevin
> > -Original Message- > > From: Matej Vido [mailto:v...@cesnet.cz] > > Sent: Wednesday, September 13, 2017 4:14 PM > > To: Yigit, Ferruh ; Yang, Zhiyong > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > > > On 11.09.2017 12:23, Ferruh Yigit wrote: >

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > + > +/* Handle all mbufs on an external pool (non-dpaa2) */ minor typo, but is intention dpaa ? > +static inline uint16_t > +tx_on_external_pool(struct qman_fq *txq, struct rte_

Re: [dpdk-dev] [PATCH v4 36/41] net/dpaa: add support for packet type parsing

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Add support for parsing the packet type and L2/L3 checksum offload > capability information. > > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain > --- > doc/guides/nics/features/dpaa.ini | 2 + > drivers/net/dpaa/dpaa_ethdev.c|

Re: [dpdk-dev] [PATCH v4 28/41] net/dpaa: add support for link status update

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +static int dpaa_eth_link_update(struct rte_eth_dev *dev, > + int wait_to_complete __rte_unused) > +{ > + struct dpaa_if *dpaa_intf = dev->data->de

Re: [dpdk-dev] [PATCH v4 40/41] net/dpaa: support for firmware version get API

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > From: Hemant Agrawal > > Signed-off-by: Hemant Agrawal <...> > +static int > +dpaa_fw_version_get(struct rte_eth_dev *dev __rte_unused, > + char *fw_version, > + size_t fw_size) > +{ > + int ret; > + FILE *

Re: [dpdk-dev] [PATCH v4 41/41] net/dpaa: support for extended statistics

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > From: Hemant Agrawal > > Signed-off-by: Hemant Agrawal <...> > +static int > +dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, > + unsigned int n) > +{ > + struct dpaa_if *dpaa_intf = dev->data->dev_pri

Re: [dpdk-dev] [PATCH v2 3/5] eal/memory: rename memseg member phys to iova addr

2017-09-18 Thread Burakov, Anatoly
On 05-Sep-17 11:31 AM, Santosh Shukla wrote: Renaming rte_memseg {.phys_addr} to {.iova_addr} Signed-off-by: Santosh Shukla --- v1 --> v2: - includes freebsdp v1 build fixes. lib/librte_eal/bsdapp/eal/eal_memory.c | 4 ++-- lib/librte_eal/common/eal_common_memory.c | 2 +- lib/librte_

Re: [dpdk-dev] [PATCH v2 3/5] eal/memory: rename memseg member phys to iova addr

2017-09-18 Thread santosh
Hi Anatoly, On Monday 18 September 2017 08:34 PM, Burakov, Anatoly wrote: > On 05-Sep-17 11:31 AM, Santosh Shukla wrote: >> Renaming rte_memseg {.phys_addr} to {.iova_addr} >> >> Signed-off-by: Santosh Shukla >> --- >> v1 --> v2: >> - includes freebsdp v1 build fixes. >> >> lib/librte_eal/bsda

Re: [dpdk-dev] [PATCH] test: support to check AVX512F

2017-09-18 Thread Bruce Richardson
suggest title as: test: add check for AVX512F On Fri, Sep 08, 2017 at 03:44:54PM +0800, Zhiyong Yang wrote: > The CPUs which support AVX512 have been released. Add the support > of checking AVX512F instruction set. > s/the support of/support for/ > Signed-off-by: Zhiyong Yang > --- Simple enough

Re: [dpdk-dev] [PATCH v2 3/5] eal/memory: rename memseg member phys to iova addr

2017-09-18 Thread Burakov, Anatoly
On 18-Sep-17 4:08 PM, santosh wrote: Hi Anatoly, On Monday 18 September 2017 08:34 PM, Burakov, Anatoly wrote: On 05-Sep-17 11:31 AM, Santosh Shukla wrote: Renaming rte_memseg {.phys_addr} to {.iova_addr} Signed-off-by: Santosh Shukla --- v1 --> v2: - includes freebsdp v1 build fixes. l

[dpdk-dev] [PATCH v2 00/19] bnxt patch set

2017-09-18 Thread Ajit Khaparde
This patch set includes some bug fixes and also adds support for new dev_ops like rx_queue_count, rx_descriptor_status and tx_descriptor_status. It also adds support for the flow_filter funciton to add Flow API functionality. Please apply. doc/guides/nics/features/bnxt.ini | 3 + doc/guid

[dpdk-dev] [PATCH v2 01/19] net/bnxt: fix HWRM_*() macros and locking

2017-09-18 Thread Ajit Khaparde
Obtain the spinlock in HWRM_PREP() Eliminate two unnecessary arguments in HWRM_PREP(). Unlock the spinlock before returning in HWRM_ERROR_CHECK() Add new HWRM_UNLOCK() macro Update usage of the thre macros. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments --- drivers/net/bnxt/

[dpdk-dev] [PATCH v2 02/19] net/bnxt: use 64-bits of address for vlan_table

2017-09-18 Thread Ajit Khaparde
We are wrongly using just 16 bits of address from rte_mem_virt2phy while filling the vlan table address instead of 64-bytes. Most likely a copy-paste error. Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2

[dpdk-dev] [PATCH v2 03/19] net/bnxt: fix an issue with group id calculation

2017-09-18 Thread Ajit Khaparde
start_grp_id is incremented wrongly. Fixing it. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 0793

[dpdk-dev] [PATCH v2 04/19] net/bnxt: fix calculation of number of pools

2017-09-18 Thread Ajit Khaparde
The calculation for number of pools is wrong. We are wrongly overwriting the calculated value with ETH_64_POOLS. Fix the log message as well. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 3 +-- 1 file changed, 1 insert

[dpdk-dev] [PATCH v2 05/19] net/bnxt: handle multi queue mode properly

2017-09-18 Thread Ajit Khaparde
We are currently not handling multi queue RX/RSS modes correctly. If RSS is not requested, create one VNIC per RXQ. Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/bnxt/bnxt_rxq.c| 198 ++

[dpdk-dev] [PATCH v2 08/19] net/bnxt: fix usage of ETH_VMDQ_* flags

2017-09-18 Thread Ajit Khaparde
Map ETH_VMDQ_ACCEPT_HASH_UC to the promiscuous bit. Also, set ALLMULTI and MCAST when MCAST is set to ensure multicast traffic is received regardless of the VF driver list. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- d

[dpdk-dev] [PATCH v2 07/19] net/bnxt: fix an issue with broadcast traffic

2017-09-18 Thread Ajit Khaparde
In bnxt_hwrm_cfa_l2_set_rx_mask, we are ignoring the previous setting of HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST and setting it again, thereby wrongly enabling Broadcast. Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- 1 f

[dpdk-dev] [PATCH v2 06/19] net/bnxt: fix rx handling and buffer allocation logic

2017-09-18 Thread Ajit Khaparde
Even when rx buffer allocation fails, we are wrongly updating the producer index. This patch fixes that. Also in case of a buffer allocation failure, reattempt buffer allocation before the rx handler exits. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- dri

[dpdk-dev] [PATCH v2 09/19] net/bnxt: set checksum offload flags correctly

2017-09-18 Thread Ajit Khaparde
We are not correctly setting hw checksum offload for all the offload flags. This patch fixes that. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 32 +--- drivers/net/bnxt/bnxt_txr.h | 21 +

[dpdk-dev] [PATCH v2 10/19] net/bnxt: update status of Rx IP/L4 CKSUM

2017-09-18 Thread Ajit Khaparde
update ol_flags with the appropriate status of IP/L4 cksum in Rx path. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 11 +++ drivers/net/bnxt/bnxt_rxr.h | 16 2 files changed, 27 insertions(+) diff --

[dpdk-dev] [PATCH v2 11/19] net/bnxt: add support for xstats get by id

2017-09-18 Thread Ajit Khaparde
This patch adds support for xstats_get_by_id/xstats_get_names_by_id. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ drivers/net/bnxt/bnxt_stats.c | 47 ++ drivers/net/bnxt/bnxt_stats.h |

[dpdk-dev] [PATCH v2 12/19] net/bnxt: fix config rss update

2017-09-18 Thread Ajit Khaparde
We are not configuring the RSS settings updated by rss_hash_update(). Fix it. Fixes: cc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 ++ drivers/net/bnxt/bnxt_ethdev.c | 4 drivers/net/bnxt/bnxt_rxq.c| 5 + 3

[dpdk-dev] [PATCH v2 13/19] net/bnxt: set the hash_key_size

2017-09-18 Thread Ajit Khaparde
We were not setting the dev_info.hash_key_size. Setting it now. Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v2 15/19] net/bnxt: add support for rx_descriptor_status

2017-09-18 Thread Ajit Khaparde
add support for rx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 39 +++ 2 files changed, 40 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH v2 16/19] net/bnxt: add support for tx_descriptor_status

2017-09-18 Thread Ajit Khaparde
add support for tx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 38 ++ drivers/net/bnxt/bnxt_txr.c | 3 +++ 3 files change

[dpdk-dev] [PATCH v2 14/19] net/bnxt: add support for rx_queue_count

2017-09-18 Thread Ajit Khaparde
add support for rx_queue_count dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_cpr.h| 6 +- drivers/net/bnxt/bnxt_ethdev.c | 46 ++ drivers/net/bnxt/bnxt_rxr.c| 12 +-- 3 files chan

[dpdk-dev] [PATCH v2 17/19] net/bnxt: add new HWRM structs to support flow filtering

2017-09-18 Thread Ajit Khaparde
HWRM structs added: hwrm_cfa_ntuple_filter_alloc, hwrm_cfa_ntuple_filter_free, hwrm_cfa_ntuple_filter_cfg, hwrm_cfa_em_flow_alloc, hwrm_cfa_em_flow_free, hwrm_cfa_em_flow_cfg Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 984 + 1 file c

[dpdk-dev] [PATCH v2 18/19] net/bnxt: add support for flow filter ops

2017-09-18 Thread Ajit Khaparde
This patch adds support for flow validate/create/destroy/flush ops. Also update doc/guides/nics/features/bnxt.ini to indicate this. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt.h | 7 + drive

[dpdk-dev] [PATCH v2 19/19] doc: update release notes

2017-09-18 Thread Ajit Khaparde
Update release doc briefly describing updates to bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_17_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8bf91bd..1bd7b31 1006

Re: [dpdk-dev] [PATCH v2 1/5] eal: rename phys_addr_t to iova_addr_t

2017-09-18 Thread Burakov, Anatoly
On 05-Sep-17 11:31 AM, Santosh Shukla wrote: Renamed data type from phys_addr_t to iova_addr_t. Signed-off-by: Santosh Shukla --- v1 --> v2: - clang build fix for v1 for linuxapp. v1 note: - As changes percolate to all possible dpdk subsystem.. so its difficult to tag subject with one commo

Re: [dpdk-dev] [PATCH v2 2/5] eal/memory: rename buf_physaddr to buf_iovaaddr

2017-09-18 Thread Burakov, Anatoly
On 05-Sep-17 11:31 AM, Santosh Shukla wrote: Signed-off-by: Santosh Shukla --- v1 notes: Since crux of change is at eal/memory area so using that as title. doc/guides/prog_guide/img/mbuf1.svg| 2 +- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h| 2

Re: [dpdk-dev] [PATCH v2 3/5] eal/memory: rename memseg member phys to iova addr

2017-09-18 Thread Burakov, Anatoly
On 05-Sep-17 11:31 AM, Santosh Shukla wrote: Renaming rte_memseg {.phys_addr} to {.iova_addr} Signed-off-by: Santosh Shukla --- v1 --> v2: - includes freebsdp v1 build fixes. lib/librte_eal/bsdapp/eal/eal_memory.c | 4 ++-- lib/librte_eal/common/eal_common_memory.c | 2 +- lib/librte_

Re: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and delete functions

2017-09-18 Thread Singh, Jasvinder
Hi Bernard, > --- a/lib/librte_table/rte_table_acl.c > +++ b/lib/librte_table/rte_table_acl.c > @@ -316,8 +316,7 @@ struct rte_table_acl { > if (status == 0) { > *key_found = 1; > *entry_ptr = &acl->memory[i * acl->entry_size]; > -

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-18 Thread Van Haaren, Harry
> From: Rao, Nikhil > Sent: Wednesday, September 13, 2017 7:53 PM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > > Cc: Eads, Gage ; dev@dpdk.org; tho...@monjalon.net; Van > Haaren, Harry ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; Vangati, Narender ; Carrillo, > Erik G ; Gujjar, Ab

Re: [dpdk-dev] [PATCH 02/11] doc: add details of rte security

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, September 14, 2017 9:27 AM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; Nicolau, Radu > ; bor...@mellanox.com; avia...@mellanox.com; >

Re: [dpdk-dev] [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-09-18 Thread Van Haaren, Harry
> From: Rao, Nikhil > Sent: Tuesday, September 12, 2017 1:29 PM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > > Cc: Eads, Gage ; dev@dpdk.org; tho...@monjalon.net; Van > Haaren, Harry ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; Vangati, Narender ; Carrillo, > Erik G ; Gujjar, Abhi

Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream rdma-core

2017-09-18 Thread Yigit, Ferruh
Thanks Shachar, I have seen v7 [1], I will wait this and depended two patches to be acked before getting them. Thanks, ferruh [1] http://dpdk.org/dev/patchwork/patch/28852/ > -Original Message- > From: Shachar Beiser [mailto:shacha...@mellanox.com] > Sent: Monday, September 18, 2017 2:

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes

2017-09-18 Thread Vladimir Kuramshin
I agree with you but the problem is that in this case I should also change Makefile in order to add version checking there also but I don't know how to write correct condition in Makefile that checks if it's higher or lower version, e.g. if PQOS_VERSION > 1.3 then ... else ... If there was som

Re: [dpdk-dev] [PATCH v4 05/41] bus/dpaa: introducing FMan configurations

2017-09-18 Thread Thomas Monjalon
18/09/2017 16:50, Ferruh Yigit: > On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > > FMan or Frame Manager, inspects traffic, splits it into queueson ingress. > > It is also responsible for directing traffic on queues on egress. > > > > This patch introduces FMan configurational interfaces. This laye

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes

2017-09-18 Thread Bruce Richardson
On Mon, Sep 18, 2017 at 07:07:18PM +0300, Vladimir Kuramshin wrote: > I agree with you but the problem is that in this case I should also change > Makefile in order to add version checking there also but I don't know how to > write correct condition in Makefile that checks if it's higher or lower >

Re: [dpdk-dev] [PATCH v3 3/3] doc: update timer lib docs

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Erik Gabriel Carrillo > Sent: Wednesday, September 13, 2017 11:05 PM > To: rsanf...@akamai.com > Cc: dev@dpdk.org; Ananyev, Konstantin ; > step...@networkplumber.org; Wiles, Keith ; Vangati, > Narender > Subject:

Re: [dpdk-dev] [PATCH v4 1/4] net/softnic: add softnic PMD

2017-09-18 Thread Singh, Jasvinder
Hi Thomas, I don't see this patch in patchwork, although it is present in email archive. Any guess why it is not showing up there? Thank you, Jasvinder > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Monday, September 18, 2017 10:10 AM

Re: [dpdk-dev] [PATCH v4 05/41] bus/dpaa: introducing FMan configurations

2017-09-18 Thread Hemant Agrawal
On 9/18/2017 9:45 PM, Thomas Monjalon wrote: 18/09/2017 16:50, Ferruh Yigit: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: FMan or Frame Manager, inspects traffic, splits it into queueson ingress. It is also responsible for directing traffic on queues on egress. This patch introduces FMan config

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Wednesday, September 13, 2017 6:47 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet > > Signed-off-by: Ravi Kumar Thanks for the doc. Some comm

Re: [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification

2017-09-18 Thread Yongseok Koh
> On Sep 17, 2017, at 3:42 AM, Shachar Beiser wrote: > > Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification") > Cc: sta...@dpdk.org > > Signed-off-by: Shachar Beiser > --- > I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 > verification > --- I thin

Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: replace network to host macros

2017-09-18 Thread Yongseok Koh
> On Sep 17, 2017, at 3:42 AM, Shachar Beiser wrote: > > Signed-off-by: Shachar Beiser > --- > I have rebased [PATCH v3 1/2] net/mlx5: replace network to host macros > I have fixed a rebase conflict in mlx5_rxtx.h in line 609 > -rte_wmb(); > +rte_io_wmb(); > > --- Acked-by: Yongseok Koh Than

Re: [dpdk-dev] [PATCH 2/4] crypto/dpaa_sec: add crypto driver for NXP DPAA platform

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agra...@nxp.com; Akhil Goyal > > Subject: [PATCH 2/4] crypto/dpaa_sec: add crypto

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-18 Thread Shahaf Shuler
Monday, September 18, 2017 5:45 PM, Bruce Richardson: > > On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote: > > Monday, September 18, 2017 2:38 PM, Bruce Richardson > > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > > > 18/09/2017 13:11, Ananyev, Konstantin: >

Re: [dpdk-dev] [PATCH 3/4] test/crypto: add dpaa crypto test cases

2017-09-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agra...@nxp.com; Akhil Goyal > > Subject: [PATCH 3/4] test/crypto: add dpaa crypt

Re: [dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core turbo APIs

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, September 13, 2017 11:44 AM > To: dev@dpdk.org > Cc: Hunt, David > Subject: [dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core > turbo APIs > > Signed-off-by: David Hu

Re: [dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 11, 2017 5:34 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Yigit, Ferruh ; Stephen Hurd > ; Ajit Khaparde ; > Wu, Jingjing ; Zhang, Helin > ; Zhang, Helin ; Ananyev, > Konstantin > Subject: [PATCH 2/2] doc: add API docu

Re: [dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 11, 2017 5:34 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Yigit, Ferruh ; Stephen Hurd > ; Ajit Khaparde ; > Wu, Jingjing ; Zhang, Helin > ; Zhang, Helin ; Ananyev, > Konstantin > Subject: [PATCH 1/2] doc: add shared l

Re: [dpdk-dev] [PATCH v4 17/41] doc: add NXP DPAA PMD documentation

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Saturday, September 9, 2017 12:21 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; hemant.agra...@nxp.com > Subject: [dpdk-dev] [PATCH v4 17/41] doc: add NXP DPAA PMD documentation > > Signed-of

Re: [dpdk-dev] [PATCH] doc: add arm64 to linux_gsg

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Brian Brooks > Sent: Wednesday, September 6, 2017 4:55 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Brian Brooks > Subject: [dpdk-dev] [PATCH] doc: add arm64 to linux_gsg > > Signed-off-by: Brian Brooks > R

Re: [dpdk-dev] [PATCH] bonding: fix wrong slaves capacity check

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 11:24 AM, Doherty, Declan wrote: > On 27/07/2017 1:00 PM, Tomasz Kulasek wrote: >> For fortville NIC bond_ethdev_8023ad_flow_verify fails when action queue >> index indicates unavailable queue before slaves configuration. >> >> This fix verifies flow settings for queue 0, which is alwa

Re: [dpdk-dev] [PATCH v3 7/7] doc: add membership documentation

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 6, 2017 1:00 AM > To: dev@dpdk.org > Cc: Tai, Charlie ; Gobriel, Sameh > ; Wang, Ren ; Wang, Yipeng1 > ; Mcnamara, John > Subject: [PATCH v3 7/7] doc: add membership documentation > > This patch adds the documentati

Re: [dpdk-dev] [PATCH] net/nfp: add info about RSS capabilities

2017-09-18 Thread Ferruh Yigit
On 9/11/2017 2:27 PM, Alejandro Lucero wrote: > NFP supports RSS but it is not being advertised. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v1 4/4] doc: remove dpdk iova aware notice

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Santosh Shukla > Sent: Monday, August 14, 2017 4:16 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; tho...@monjalon.net; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Santosh Shukla > > Subject: [

Re: [dpdk-dev] [PATCH v2 19/19] doc: update release notes

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ajit Khaparde > Sent: Monday, September 18, 2017 4:18 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2 19/19] doc: update release notes > > Update release doc briefly describing updates

[dpdk-dev] [PATCH 2/2] net/tap: fix unregistering callback with invalid fd

2017-09-18 Thread Ferruh Yigit
From: Vipin Varghese tap_intr_handle_set() called by tap_dev_start(), and if LSC is disabled (dev_conf.intr_conf.lsc == 0), it tries to unregister interrupt callback without checking the interrupt file descriptor. Fixes: c0bddd3a057f ("net/tap: add link status notification") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-09-18 Thread Ferruh Yigit
From: Vipin Varghese tap speed argument is not working without generating any error. This patch sets the configured speed during device start. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Cc: sta...@dpdk.org Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 27

Re: [dpdk-dev] [PATCH v3 6/6] net/mlx5: multi-process document update

2017-09-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > Sent: Monday, September 18, 2017 3:36 PM > To: Nelio Laranjeiro ; Adrien Mazarguil > > Cc: Xueming Li ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 6/6] net/mlx5: multi-process document update > >

Re: [dpdk-dev] [PATCH] net/nfp: remove firmware ABI check

2017-09-18 Thread Ferruh Yigit
On 9/11/2017 2:44 PM, Alejandro Lucero wrote: > Link speed is not advertised in old firmwares. However, it is safe > to remove the check because reading NFP_NET_CFG_STS returns 0 in > those cases. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/nfp: configure L2 broadcast and multicast

2017-09-18 Thread Ferruh Yigit
On 9/13/2017 12:27 PM, Alejandro Lucero wrote: > This is required in some NFP firmwares when working with VFs. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4 1/4] net/softnic: add softnic PMD

2017-09-18 Thread Thomas Monjalon
18/09/2017 18:58, Singh, Jasvinder: > Hi Thomas, > > I don't see this patch in patchwork, although it is present in email archive. > Any guess why it is not showing up there? No idea. Not a big deal, others are there.

Re: [dpdk-dev] [PATCH] net/nfp: configure capabilities by default

2017-09-18 Thread Ferruh Yigit
On 9/13/2017 12:28 PM, Alejandro Lucero wrote: > These capabilities are enabled in current NFP firmwares by > default, but it could be they are not with NFP firmwares to come. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR

2017-09-18 Thread Ferruh Yigit
On 9/13/2017 9:55 PM, Alejandro Lucero wrote: > VFs rely on config BAR for getting the MAC address, although a > random one is created a valid address is not found. > > A PF port has a fixed MAC which is currently acquired using the NSPU > interface. Some NFP firmwares require the MAC being writin

<    1   2   3   >