On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > Signed-off-by: Shreyansh Jain <shreyansh.j...@nxp.com> > Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
<...> > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map > b/drivers/bus/dpaa/rte_bus_dpaa_version.map > new file mode 100644 > index 0000000..d97a009 > --- /dev/null > +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map > @@ -0,0 +1,7 @@ > +DPDK_17.11 { > + global: > + > + rte_dpaa_driver_register; > + rte_dpaa_driver_unregister; "local *;" ? <...> > +struct rte_dpaa_device { > + TAILQ_ENTRY(rte_dpaa_device) next; > + struct rte_device device; > + union { > + struct rte_eth_dev *eth_dev; > + struct rte_cryptodev *crypto_dev; > + }; Bus struct should be independt from functionality, this has been done in PCI, can same thing be done for dpaa bus too? <...> > + * @return > + * 0 in case of success, error otherwise > + */ > +int rte_dpaa_portal_init(void *arg); Definition is not in this patch. > + > +/** > + * Cleanup a DPAA Portal > + */ > +void dpaa_portal_finish(void *arg); Definition is not in this patch. <...>