[dpdk-dev] [PATCH 0/4] update ixgbe base driver to version 2017-03-29

2017-04-18 Thread Wei Dai
This patch set has following 4 patches. No any new device id is added. net/ixgbe/base: acquire PHY semaphore before device reset net/ixgbe/base: add support for 2.5G KX physical layer net/ixgbe/base: add MAC X550em/X557 LED on/off support net/ixgbe/base: update base driver version to 2017.

[dpdk-dev] [PATCH 3/4] net/ixgbe/base: add MAC X550em/X557 LED on/off support

2017-04-18 Thread Wei Dai
This patch updates ixgbe_led_[on|off]_t_X550em for MAC or PHY connected LEDs. To support both MAC or PHY connected LEDs, both MAC and PHY led control registers are configured. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_x550.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(

[dpdk-dev] [PATCH 1/4] net/ixgbe/base: acquire PHY semaphore before device reset

2017-04-18 Thread Wei Dai
A recent firmware change fixed an issue to acquire the PHY semaphore before accessing PHY registers. This led to a case where SW can issue a device reset clearing the MDIO registers. This patch makes SW acquire the PHY semaphore before issuing a device reset. Signed-off-by: Wei Dai --- drivers/n

[dpdk-dev] [PATCH 2/4] net/ixgbe/base: add support for 2.5G KX physical layer

2017-04-18 Thread Wei Dai
Add another define for the 2.5G KX physical layer. This requires all variables and support functions that deal with "physical_layer" to be bumped to u64 as this is the 33rd define. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_82598.c | 4 ++-- drivers/net/ixgbe/base/ixgbe_82598.h |

[dpdk-dev] [PATCH 4/4] net/ixgbe/base: update base driver version to 2017.03.29

2017-04-18 Thread Wei Dai
* Acquire PHY semaphore before device reset * Add support for 2.5G KX physical layer * Add MAC X550em/X557 LED on|off support Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/i

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, Ferruh, Thank you for spotting these issues. I'm on it, I will send a patch to fix them asap. Olivier On Fri, 14 Apr 2017 16:32:57 +0100, Ferruh Yigit wrote: > Hi Olivier, > > On 4/4/2017 5:40 PM, Olivier Matz wrote: > > Example of use: > > ./app/test-pmd --log-level='pmd\.i40e

[dpdk-dev] [PATCH 0/5] improve tap behavior

2017-04-18 Thread Pascal Mazon
The tap does not behave properly in some cases. It is generally expected that a real device should be available once the probing has been done. It is also better to check if an operation (here, setting MAC) is mandatory before performing it. Typically in cases where the remote netdevice is a VF w

[dpdk-dev] [PATCH v2 1/5] net/tap: add debug messages

2017-04-18 Thread Pascal Mazon
Print a detailed debug message inside tap_ioctl() directly. The caller now only needs to check for return value. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v2 2/5] net/tap: remove unnecessary functions

2017-04-18 Thread Pascal Mazon
These functions are only two lines each and are used only once. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 0c89b6

[dpdk-dev] [PATCH v2 3/5] net/tap: drop unnecessary nested block

2017-04-18 Thread Pascal Mazon
This is cosmetic; the code is functionally equivalent. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index c9d107

[dpdk-dev] [PATCH v2 4/5] net/tap: create netdevice during probing

2017-04-18 Thread Pascal Mazon
This has three main benefits: - tun_alloc is now generic again for any queue, - mtu no longer needs to be handled in tap_setup_queue(), - an actual netdevice is created as soon as the device is probed. On top of it, code in eth_dev_tap_create() has been reworked to have a more logical behavior;

[dpdk-dev] [PATCH v2 5/5] net/tap: do not set remote MAC if not necessary

2017-04-18 Thread Pascal Mazon
Check for the current MAC address on both the remote and the tap netdevices before setting a new value. While there, remove wrong empty lines and ensure tap_ioctl() return value is negative, just like what is done throughout this code. Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic c

Re: [dpdk-dev] [PATCH] vhost: fix use after free

2017-04-18 Thread Maxime Coquelin
On 04/17/2017 09:27 AM, Yuanhan Liu wrote: A "return" is missing on error, which could lead to a "use after free" issue (about var "conn"). Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode") Coverity issue: 143476 Reported-by: John McNamara Signed-off-by: Yuanhan Liu ---

[dpdk-dev] [PATCH] net/mlx5: fix empty RSS flow action

2017-04-18 Thread Nelio Laranjeiro
Empty RSS action is causing a segmentation fault. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- v3: - Cleanup code change as per discussion in http://dpdk.org/dev/patchwork/patch/23262/ test/test/test_mempool_perf.c | 61 ++- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/tes

[dpdk-dev] [PATCH v3 2/3] test/test/mempool_perf: Free mempool on exit

2017-04-18 Thread Santosh Shukla
Mempool_perf test not freeing pool memory. Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla Acked-by: Shreyansh Jain --- v1--> v2: - patch context fix test/test/test_mempool_perf.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/test/test/t

[dpdk-dev] [PATCH v3 3/3] test/test/mempool_perf: support default mempool autotest

2017-04-18 Thread Santosh Shukla
Mempool_perf autotest currently does perf regression for: * nochache * cache Introducing default_pool, mainly targeted for ext-mempool regression test. Ext-mempool don't need 'cache' modes so only adding test-case support for 'nocache' mode. So to run ext-mempool perf regression, user has to se

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: > Hi Olivier, > > If I understand it correctly, this patch is to shift log level setting > earlier. But we did not remove the one in eal_parse_common_option(). So > we can see this parameter will be analyzed twice. Does i

[dpdk-dev] [PATCH] net/i40e: add check for invalid VF queue number

2017-04-18 Thread Beilei Xing
Add check to avoid invalid VF queue number is used in tunnel filter. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 8fe626c..0a0181

[dpdk-dev] VTP packet reception in X540

2017-04-18 Thread Karthikraj palanichamy
I am using DPDK for Intel X540-AT2 card. In my environment, there will be a flow of lot of layer2 protocol packets. I could not receive a specific protocol packet - VTP(https://en.wikipedia.org/wiki/VLAN_Trunking_Protocol). It's ethertype is 0x0055. However, I could receive this protocol frames

Re: [dpdk-dev] [PATCH] crypto/qat: fix AES-GCM authentication length

2017-04-18 Thread Jain, Deepak K
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 13, 2017 10:29 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix AES-GCM authentication length > > This

Re: [dpdk-dev] [PATCH] net/mlx5: change calculating inline room for Tx

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 7:43 AM, Nélio Laranjeiro wrote: > On Thu, Apr 13, 2017 at 10:46:51AM -0700, Yongseok Koh wrote: >> Current implementation is error-prone if the max inline size >> (txq->max_inilne) is decoupled from txq->inline_en and becomes zero. If it >> becomes zero, HW can crash due to WQ overflo

Re: [dpdk-dev] [PATCH] crypto/qat: fix IV zero physical address

2017-04-18 Thread Jain, Deepak K
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, April 14, 2017 9:09 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix IV zero physical address > > This commit f

Re: [dpdk-dev] Working of pipeline in a given config file and regarding user-defined actions in IP_PIPELINE application

2017-04-18 Thread Dumitrescu, Cristian
From: Nidhia Varghese [mailto:nidhiavarghes...@gmail.com] Sent: Tuesday, April 18, 2017 6:40 AM To: Dumitrescu, Cristian Cc: Singh, Jasvinder ; dev@dpdk.org; us...@dpdk.org Subject: Re: [dpdk-dev] Working of pipeline in a given config file and regarding user-defined actions in IP_PIPELINE appli

Re: [dpdk-dev] [PATCH] net/mlx5: fix empty RSS flow action

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 9:30 AM, Nelio Laranjeiro wrote: > Empty RSS action is causing a segmentation fault. > > Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") > > Signed-off-by: Nelio Laranjeiro > Acked-by: Shahaf Shuler > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, than

Re: [dpdk-dev] [PATCH v3] eal: redefine logtype values

2017-04-18 Thread Olivier MATZ
Hi Pablo, On Thu, 13 Apr 2017 14:42:47 +0100, Pablo de Lara wrote: > After the changes in commit c1b5fa94a46f > ("eal: support dynamic log types"), logtype is not treated as a > bitmask, but a decimal value. Therefore, values have to be > converted. > > Fixes: c1b5fa94a46f ("eal: support dynami

[dpdk-dev] [PATCH] event/sw: fix credit return on invalid queue id

2017-04-18 Thread Harry van Haaren
This patch returns a credit when an rte_event is enqueued with an invalid queue_id. Previously a credit was leaked from the system. Note that the eventdev instance does not attempt to free any resources that the rte_event owns. As a result, resources owned by the rte_event are leaked. Eg. if the r

Re: [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used

2017-04-18 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, April 13, 2017 10:53 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo ; > Zhang, Qi ; Iremonger, Bernard > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fi

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/i40e: fix to ensure vector mode is not used

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 10:58 AM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger >> Sent: Thursday, April 13, 2017 10:53 AM >> To: dev@dpdk.org >> Cc: Xing, Beilei ; Lu, Wenzhuo >> ; Zhang, Qi ; Iremonger, Bernard >> ;

Re: [dpdk-dev] [PATCH] event/sw: fix credit return on invalid queue id

2017-04-18 Thread Hunt, David
On 18/4/2017 10:58 AM, Harry van Haaren wrote: This patch returns a credit when an rte_event is enqueued with an invalid queue_id. Previously a credit was leaked from the system. Note that the eventdev instance does not attempt to free any resources that the rte_event owns. As a result, resourc

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix PMD specific parameters defaults

2017-04-18 Thread Shahaf Shuler
With the Enhanced multi packet send addition, the defaults were made in order to get the maximum out of the box performance. Features like tso, don't use the enhanced send, however the defaults are still valid. This cause Tx queue creation to fail. Fixes: aea00c008140 ("net/mlx5: add hardware TSO

[dpdk-dev] [PATCH v2 1/2] net/mlx5: modify PMD args process

2017-04-18 Thread Shahaf Shuler
Currently the argument process is done without indication which parameter was forced by the application and which one is on it default value. This becomes problematic when different features requires different defaults. For example, Enhanced multi packet send and TSO. This commit modifies the argu

[dpdk-dev] [PATCH v2] crypto/scheduler: improve commandline parsing

2017-04-18 Thread Fan Zhang
This patch improves the cryptodev scheduler PMD's commandline parsing capability. Originally, the scheduler's slave option requires the slave vdev(s) being declared prior to it. This patch removes this limitation by storing the slave names temporarily and attaching them later. This patch depends o

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Tan, Jianfeng
On 4/18/2017 4:50 PM, Olivier MATZ wrote: Hi Jianfeng, On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: Hi Olivier, If I understand it correctly, this patch is to shift log level setting earlier. But we did not remove the one in eal_parse_common_option(). So we can see this param

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-18 Thread Alejandro Lucero
On Thu, Apr 6, 2017 at 11:10 AM, Burakov, Anatoly wrote: > Hi Alejandro, > > > Yes, the code was not aware of that possibility. Being honest, I knew > about that, but not in my mind when implementing the code. I have just > cards where each PF even VF have their own VFIO group. This could be a >

[dpdk-dev] [PATCH v3] crypto/scheduler: improve commandline parsing

2017-04-18 Thread Fan Zhang
This patch improves the cryptodev scheduler PMD's commandline parsing capability. Originally, the scheduler's slave option requires the slave vdev(s) being declared prior to it. This patch removes this limitation by storing the slave names temporarily and attaching them later. Signed-off-by: Fan Z

[dpdk-dev] [PATCH v3] crypto/scheduler: fix Doxygen comments

2017-04-18 Thread Fan Zhang
This patch adds the missing doxygen comments and updated inline comments to cryptodev scheduler Fixes: d58a3f312545 ("crypto/scheduler: add documentation") Signed-off-by: Fan Zhang Acked-by: John McNamara --- v3: - updated based on the comments v2: - fixed typo doc/api/doxy-api-index.md

[dpdk-dev] [PATCH] examples/l2fwd-crypto: add cryptodev mask option

2017-04-18 Thread Fan Zhang
Previously, l2fwd-crypto application did not give user the flexibility to decide which crypto device(s) will be used. In this patch, a new cryptodev_mask option is added to the application. Same as portmask, the cryptodev_mask avails the user to mask out the unwanted crypto devices in the system.

[dpdk-dev] [PATCH 1/2] test/crypto: create only one virtual device if needed

2017-04-18 Thread Pablo de Lara
Instead of creating two virtual devices per PMD, if they have not been initialized from EAL already, create only one, as only the first device is used for the crypto tests. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 144 ++-- test/test/

[dpdk-dev] [PATCH 2/2] test/crypto: create unique driver name

2017-04-18 Thread Pablo de Lara
Since commit ("vdev: make virtual bus use its device struct"), rte_eal_vdev_init cannot be called with same name twice. If several devices with the same driver are needed (as in the crypto scheduler test), then driver name argument has to be unique, concatenating the driver name and an index. Si

Re: [dpdk-dev] [PATCH 1/2] test/crypto: create only one virtual device if needed

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 18, 2017 12:40 PM > To: dev@dpdk.org > Cc: zbigniew.bo...@caviumnetworks.com; > jerin.ja...@caviumnetworks.com; Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH 1/2] test/crypto: create only one virtual devi

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, On Tue, 18 Apr 2017 19:15:51 +0800, "Tan, Jianfeng" wrote: > On 4/18/2017 4:50 PM, Olivier MATZ wrote: > > Hi Jianfeng, > > > > On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" > > wrote: > >> Hi Olivier, > >> > >> If I understand it correctly, this patch is to shift log leve

Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build

2017-04-18 Thread Olivier MATZ
On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain wrote: > Signed-off-by: Shreyansh Jain Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver") Acked-by: Olivier Matz > --- > Context: > From the discussion in [1], it was observed that application should > have a default pool alrea

[dpdk-dev] [PATCH v2 1/5] ethdev: introduce device removal event

2017-04-18 Thread Gaetan Rivet
This new API allows reacting to a device removal. A device removal is the sudden disappearance of a device from its bus. PMDs implementing support for this notification guarantee that the removal of the underlying device does not incur a risk to the application. In particular, Rx/Tx bursts and al

[dpdk-dev] [PATCH v2 0/5] add device removal event

2017-04-18 Thread Gaetan Rivet
This new event represents the sudden removal of a device from its bus. The underlying resources exposed by the bus are expected not to be available anymore. The application should thus be able to react and possibly clean up related resources that it reserved for the removed device. This event is d

[dpdk-dev] [PATCH v2 2/5] net/mlx4: device removal event support

2017-04-18 Thread Gaetan Rivet
Extend the LSC event handling to support the device removal as well. The Verbs library will send several related events, that can conflict with the LSC event itself. The event handling has thus been made capable of receiving and signaling several event types at once. Signed-off-by: Gaetan Rivet

[dpdk-dev] [PATCH v2 4/5] app/testpmd: request link status interrupt

2017-04-18 Thread Gaetan Rivet
For drivers supporting the LSC event, enable it. This allows to test LSC event support. Add the --no-lsc-interrupt parameter to explicitly disable the link status change interrupt. Signed-off-by: Gaetan Rivet --- app/test-pmd/parameters.c | 4 app/test-pmd/testpmd.c| 13 +

[dpdk-dev] [PATCH v2 5/5] app/testpmd: request device removal interrupt

2017-04-18 Thread Gaetan Rivet
Enable device removal event for PMD supporting it. Add the --no-rmv-interrupt parameter to explicitly disable it. Signed-off-by: Gaetan Rivet Signed-off-by: Elad Persiko --- app/test-pmd/parameters.c | 4 app/test-pmd/testpmd.c| 43 +++ app/test

[dpdk-dev] [PATCH v2 3/5] app/testpmd: generic event handler

2017-04-18 Thread Gaetan Rivet
This is a rather simple handler that prints a message with the name of the current event. It can be used to check PMD callback registration and triggers. Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c | 47 +++ 1 file changed, 47 insertions(+)

Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build

2017-04-18 Thread Shreyansh Jain
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Tuesday, April 18, 2017 5:34 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; tho...@monjalon.net; bruce.richard...@intel.com; > john.mil...@atomicrules.com > Subject: Re: [PATCH] mk: link ring mempoo

[dpdk-dev] [PATCH] net/sfc: remove logically dead code

2017-04-18 Thread Andrew Rybchenko
Coverity issue: 1419717 Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/s

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

2017-04-18 Thread Olivier MATZ
Hi Yuanhan, On Thu, 6 Apr 2017 13:45:23 +0800, Yuanhan Liu wrote: > Hi Olivier, > > On Tue, Apr 04, 2017 at 06:28:05PM +0200, Olivier Matz wrote: > > Change the size of m->port and m->nb_segs to 16 bits. > > But all the ethdev APIs are still using 8 bits. 16 bits won't really > take effect w

[dpdk-dev] [PATCH 2/3] net/sfc: use zero RSS channels as disabled RSS indicator

2017-04-18 Thread Andrew Rybchenko
Enabled RSS enables RSS hash computation and provision in pseudo header. It still makes sense for applications even if only one Rx queue is used. Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver attach") Fixes: 088e17210a7a ("net/sfc: query RSS key and hash types config")

[dpdk-dev] [PATCH 3/3] net/sfc: correct RSS hash availability condition

2017-04-18 Thread Andrew Rybchenko
RSS hash is computed by hardware if corresponding Rx filter (for example, default Rx filters) has RSS flag set which is set if the number of RSS channels is greater than zero. Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver attach") Signed-off-by: Andrew Rybchenko Revie

[dpdk-dev] [PATCH 1/3] net/sfc: reset RSS channels back to 0 on close

2017-04-18 Thread Andrew Rybchenko
Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver attach") Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index ddf9217..9f51

Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-18 Thread Olivier MATZ
Hi Ferruh, On Fri, 14 Apr 2017 14:10:33 +0100, Ferruh Yigit wrote: > On 4/5/2017 10:37 AM, Thomas Monjalon wrote: > > 2017-04-04 18:27, Olivier Matz: > >> Based on discussions done in [1] and in this thread, this patchset > >> reorganizes > >> the mbuf. > >> > >> The main changes are: > >> - r

Re: [dpdk-dev] [PATCH 2/2] test/crypto: create unique driver name

2017-04-18 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, April 18, 2017 12:40 PM > To: dev@dpdk.org > Cc: zbigniew.bo...@caviumnetworks.com; > jerin.ja...@caviumnetworks.com; Doherty, Declan > ; De Lara Guarch, Pablo > > Subject: [dpdk-dev]

[dpdk-dev] [RFC] [PATCH] eventdev: abstract ethdev HW capability to inject packets to eventdev

2017-04-18 Thread Jerin Jacob
Some Ethdev Hardware is capable of injecting the events(Ethernet packets) to eventdev without the need for dedicated service cores on Rx path. Since eventdev API is device capability agnostic, we need to address three combinations of ethdev and eventdev PMD drivers. 1) Ethdev HW is not capable of

Re: [dpdk-dev] [PATCH] net/i40e: add check for invalid VF queue number

2017-04-18 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Tuesday, April 18, 2017 9:46 AM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: add check for invalid VF queue > number > > Add check to avoid invalid VF queue num

Re: [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread Olivier MATZ
Hi Santosh, On Tue, 18 Apr 2017 14:04:46 +0530, Santosh Shukla wrote: > Cc: sta...@dpdk.org > Signed-off-by: Santosh Shukla > --- > v3: > - Cleanup code change as per discussion in >http://dpdk.org/dev/patchwork/patch/23262/ > > test/test/test_mempool_perf.c | 61 >

[dpdk-dev] [PATCH] net/kni: fix crash

2017-04-18 Thread Ferruh Yigit
eth_dev->device is now NULL, and accessing eth_dev->device->driver crashes. No need to set this value, removed completely. Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove") Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 1 - 1 file changed, 1 deletion(-

[dpdk-dev] [PATCH] doc: revise sample testpmd flow commands

2017-04-18 Thread Bernard Iremonger
Stop port before enabling QinQ. Add commands to set inner and outer TPID's and start port. Remove TPID's from flow validate and and flow create commands. Signed-off-by: Bernard Iremonger --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 33 ++--- 1 file changed, 21 insert

[dpdk-dev] [PATCH] kni: fix possible memory leak

2017-04-18 Thread Ferruh Yigit
alloc_q and rx_q fifos holds physical address of the mbufs, and not able to free those mbufs explicitly. But kernel thread reads from rx_q and puts used mbufs into free_q (with their virtual addresses.) And kernel thread stopped when application close the /dev/kni file on exit. So rx_q has time to

[dpdk-dev] [PATCH 5/6] eal: fix log level regexp matching

2017-04-18 Thread Olivier Matz
Fix misuse of regular expression functions, which was producing a segfault. After the patch, it works properly: $ ./build/app/test --no-huge --log-level=pmd,3 RTE>>dump_log_types [...] id 30: user7, level is debug id 31: user8, level is debug id 32: pmd.i40e.init, level is critical

[dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

2017-04-18 Thread Olivier Matz
This field is only used in the initialization phase. Remove it since the global log level can also be retrieved using a public API: rte_log_get_global_level(). Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c| 2 -- lib/librte_eal/common/eal_common_log.c | 6

[dpdk-dev] [PATCH 2/6] eal: move internal config initialization

2017-04-18 Thread Olivier Matz
It's better to initialize the internal config in rte_eal_init() instead of eal_log_level_parse(), since this structure is not only about logs. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c | 3 ++- lib/librte_eal/linuxapp/eal/eal.c | 3 ++- 2 files changed, 4 insertions(+), 2

[dpdk-dev] [PATCH 4/6] eal: remove undue printf

2017-04-18 Thread Olivier Matz
Remove the printf displaying the log level at initialization. It was introduced for debug purpose, but was not intended to be pushed. Fixes: 845afe51e428 ("eal: change specific log levels at startup") Reported-by: Ferruh Yigit Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_op

[dpdk-dev] [PATCH 1/6] eal: fix default log level

2017-04-18 Thread Olivier Matz
The initialization of the default log level (from configuration) was removed by mistake in a previous commit. The global log level was wrongly set to debug when no --log-level argument was passed. Restore this initialization. Before: $ ./build/app/test RTE>>dump_log_types global log level is

[dpdk-dev] [PATCH 6/6] eal: fix dump of registered logs when disabled

2017-04-18 Thread Olivier Matz
When we pass --log-level=0, it disables the logs. This level is not displayed properly by the function that dumps the registered log types (it shows "unknown"). Show "disabled" instead. Before: ./build/app/test --log-level=0 RTE>>dump_log_types global log level is unknown ... After: .

Re: [dpdk-dev] [PATCH] ethtool: disable promiscuous mode by default

2017-04-18 Thread Remy Horton
Probably ought to also add a new command so that promiscuous mode can be enabled if needed. On 12/04/2017 20:58, Qi Zhang wrote: Disable promiscuous mode by default since VLAN filter does not work when promiscuous mode is enabled. Signed-off-by: Qi Zhang --- examples/ethtool/ethtool-app/main

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-04-18 Thread Dai, Wei
First of all, I agree usage of IXGBE_FLAG_NEED_LINK_CONFIG to trigger link setup when link is up again. Both ixgbe_get_link_capabilities( ) and ixgbe_setup_link( ) calls different sub-function for different ixgbe MAC type including 82598, 82599, X540 and X550 and so on. I think ixgbe_setup_lin

[dpdk-dev] [PATCH 1/2] drivers/crypto: check if name is NULL

2017-04-18 Thread Pablo de Lara
Check if virtual device name is NULL, to avoid possible segmentation faults. Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove") Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 ++ drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 ++ drivers/

[dpdk-dev] [PATCH 2/2] drvers/crypto: do not create unique name internally

2017-04-18 Thread Pablo de Lara
Crypto devices of the same type could be initialized with the same name, since internally this name was suffixed with an index. Since commit ("vdev: make virtual bus use its device struct"), this is not allowed anymore. Therefore, there is no need to create an unique name at device initializatio

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix crypto operation resubmission

2017-04-18 Thread Fan Zhang
This patch fixes the crypto operation resubmission problem in crypto perferformance test. Originally, when needed crypto ops amount is smaller than the enqueued crypto ops in the last round, one or more processed crypto operations will be re-enqueued. Fixes: f8be1786b1b8 ("app/crypto-perf: introdu

Re: [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread santosh
Hi Olivier, On Tuesday 18 April 2017 07:12 PM, Olivier MATZ wrote: > Hi Santosh, > > On Tue, 18 Apr 2017 14:04:46 +0530, Santosh Shukla > wrote: >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla >> --- >> v3: >> - Cleanup code change as per discussion in >>http://dpdk.org/dev/patch

[dpdk-dev] [PATCH v4 2/3] test/test/mempool_perf: Free mempool on exit

2017-04-18 Thread Santosh Shukla
Mempool_perf test not freeing pool memory. Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla Acked-by: Shreyansh Jain --- v1 --> v2: - Fix patch context v2 -- v3 --> v4 - Done changes because of [1/3] patch test/test/test_mempool_perf.c | 30 ++ 1 file changed, 1

[dpdk-dev] [PATCH v4 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- v3 --> v4: - removed extra mp local var. - Includes nit changes refer http://dpdk.org/dev/patchwork/patch/23680/ test/test/test_mempool_perf.c | 63 +-- 1 file changed, 30 insertions(+), 33 deletio

[dpdk-dev] [PATCH v4 3/3] test/test/mempool_perf: support default mempool autotest

2017-04-18 Thread Santosh Shukla
Mempool_perf autotest currently does perf regression for: * nochache * cache Introducing default_pool, mainly targeted for ext-mempool regression test. Ext-mempool don't need 'cache' modes so only adding test-case support for 'nocache' mode. So to run ext-mempool perf regression, user has to se

[dpdk-dev] [PATCH v3] app/test-crypto-perf: fix crypto operation resubmission

2017-04-18 Thread Fan Zhang
This patch fixes the crypto operation resubmission problem in crypto perferformance test. Originally, when needed crypto ops amount is smaller than the enqueued crypto ops in the last round, one or more processed crypto operations will be re-enqueued. Fixes: f8be1786b1b8 ("app/crypto-perf: introdu

[dpdk-dev] app/testpmd: overriding previous setting of vlan offload when reconfiguring a device

2017-04-18 Thread Angela Czubak
Hi, I think I might have found a bug in test-pmd, but I want to make sure. One can set VLAN stripping to be on or off with "vlan set strip off/on all" etc. Let's assume that user stops all ports ("port stop all"), then modifies max-pkt-len and disbales VLAN stripping ("port config all max-pkt

Re: [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 3:22 PM, Olivier Matz wrote: > This field is only used in the initialization phase. Remove it since the > global log level can also be retrieved using a public API: > rte_log_get_global_level(). > > Signed-off-by: Olivier Matz <...> > diff --git a/lib/librte_eal/common/eal_common_l

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix Doxygen comments

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 18, 2017 12:33 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v3] crypto/scheduler: fix Doxygen comments > > This patch adds the missing doxygen comments and updated > inline comments to cryptodev sch

Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix crypto operation resubmission

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 18, 2017 3:49 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.com > Subject: [PATCH v3] app/test-crypto-perf: fix crypto operation resubmission > > This patch fixes the crypto operation resubmission problem

Re: [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

2017-04-18 Thread Olivier MATZ
Hi Ferruh, On Tue, 18 Apr 2017 16:00:45 +0100, Ferruh Yigit wrote: > On 4/18/2017 3:22 PM, Olivier Matz wrote: > > This field is only used in the initialization phase. Remove it since the > > global log level can also be retrieved using a public API: > > rte_log_get_global_level(). > > > > Signe

Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix crypto operation resubmission

2017-04-18 Thread De Lara Guarch, Pablo
CC'ing sta...@dpdk.org. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, April 18, 2017 4:24 PM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: sta...@dpdk.com > Subject: Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix crypto

Re: [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 4:26 PM, Olivier MATZ wrote: > Hi Ferruh, > > On Tue, 18 Apr 2017 16:00:45 +0100, Ferruh Yigit > wrote: >> On 4/18/2017 3:22 PM, Olivier Matz wrote: >>> This field is only used in the initialization phase. Remove it since the >>> global log level can also be retrieved using a public

Re: [dpdk-dev] [PATCH 1/6] eal: fix default log level

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 3:22 PM, Olivier Matz wrote: > The initialization of the default log level (from configuration) was > removed by mistake in a previous commit. The global log level was > wrongly set to debug when no --log-level argument was passed. Restore > this initialization. > > Before: > $ ./bu

Re: [dpdk-dev] [PATCH v4 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread Olivier MATZ
On Tue, 18 Apr 2017 20:11:28 +0530, Santosh Shukla wrote: > Cc: sta...@dpdk.org > Signed-off-by: Santosh Shukla Series: Acked-by: Olivier Matz Note for Thomas when applying: you may want to remove one "test/" in the title and remove the uppercase letter.

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: improve commandline parsing

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 18, 2017 12:28 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v3] crypto/scheduler: improve commandline parsing > > This patch improves the cryptodev scheduler PMD's commandline > parsing capability.

Re: [dpdk-dev] [PATCH 1/2] test/crypto: create only one virtual device if needed

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, April 18, 2017 12:41 PM > To: dev@dpdk.org > Cc: zbigniew.bo...@caviumnetworks.com; > jerin.ja...@caviumnetworks.com; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 1/2]

Re: [dpdk-dev] [PATCH 2/2] test/crypto: create unique driver name

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 18, 2017 2:12 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: zbigniew.bo...@caviumnetworks.com; > jerin.ja...@caviumnetworks.com; Doherty, Declan; De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH 2/2] test/crypto

[dpdk-dev] [PATCH] doc: postpone ABI change in ethdev

2017-04-18 Thread Bernard Iremonger
The change of _rte_eth_dev_callback_process has not been done in 17.05. Let's postpone to 17.08. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/deprecation.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/re

[dpdk-dev] [PATCH] doc: postpone deprecation of functions in ethdev

2017-04-18 Thread Bernard Iremonger
The deprecation of the bypass functions in the ethdev has not been done in 17.05. Let's postpone to 17.08. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/deprecation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/gui

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: improve commandline parsing

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, April 18, 2017 4:36 PM > To: Zhang, Roy Fan; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] crypto/scheduler: improve > commandline parsing > > > > > -Original Me

Re: [dpdk-dev] [PATCH] net/sfc: remove logically dead code

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 1:51 PM, Andrew Rybchenko wrote: > Coverity issue: 1419717 > Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] crypto/qat: fix IV zero physical address

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Tuesday, April 18, 2017 10:40 AM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John > Subject: RE: [PATCH] crypto/qat: fix IV zero physical address > > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH] crypto/qat: fix AES-GCM authentication length

2017-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Tuesday, April 18, 2017 10:23 AM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John > Subject: RE: [PATCH] crypto/qat: fix AES-GCM authentication length > > > > -Original Message- >

Re: [dpdk-dev] [PATCH 1/3] net/sfc: reset RSS channels back to 0 on close

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 2:03 PM, Andrew Rybchenko wrote: > Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver > attach") > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/kni: fix crash

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 3:00 PM, Ferruh Yigit wrote: > eth_dev->device is now NULL, and accessing eth_dev->device->driver > crashes. > No need to set this value, removed completely. > > Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove") > > Signed-off-by: Ferruh Yigit Applied to dp

[dpdk-dev] [PATCH 0/2] next-net: remove ethdev driver

2017-04-18 Thread Ferruh Yigit
There are two PMDs in next-net and not merged into main tree: - ARK - DPAA2 These drivers also needs to get these updates. And to prevent breaking build these changes can be squashed into PMD in next-net before integration. This means these changes needs to be merged promptly. ARK PMD updates ar

  1   2   >