Re: [dpdk-dev] [PATCH 1/3] app/testpmd: add port reset command into testpmd

2017-03-27 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, March 14, 2017 3:58 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH 1/3] app/testpmd: add port reset command > into testpmd > > Hi, Ferruh > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH v3 02/14] ring: create common structure for prod and cons metadata

2017-03-27 Thread Olivier Matz
On Fri, 24 Mar 2017 17:09:56 +, Bruce Richardson wrote: > create a common structure to hold the metadata for the producer and > the consumer, since both need essentially the same information - the > head and tail values, the ring size and mask. > > Signed-off-by: Bruce Richardson Acked-by:

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-27 Thread Olivier Matz
Hi Shreyansh, [...] > > Also, the MAINTAINERS file should be updated. > > Yes, that is something I thought of updating but left it out before > sending the patch. > One confirmation: I assume that maintainers need to be added with > "drivers/mempool/ring" and "drivers/mempool/stack" folders.

Re: [dpdk-dev] [PATCH v2] vhost: fix virtio_net false sharing

2017-03-27 Thread Maxime Coquelin
On 03/23/2017 04:44 PM, Kevin Traynor wrote: The broadcast_rarp field in the virtio_net struct is checked in the dequeue datapath regardless of whether descriptors are available or not. As it is checked with cmpset leading to a write, false sharing on the virtio_net struct can happen between e

Re: [dpdk-dev] [PATCH 1/1] net/cxgbe: check return value of malloc

2017-03-27 Thread Rahul Lakkireddy
On Saturday, March 03/25/17, 2017 at 18:14:29 +0530, caihe wrote: >Hi rahul, > >There is a bug without check the return value of alloc memory in function >t4_wr_mbox_meat_timeout, if we should fix it as below: > >diff --git a/drivers/net/cxgbe/base/t4_hw.c >b/drivers/net/cxgbe

Re: [dpdk-dev] [PATCH v4 09/10] eal: make virtual bus use rte_vdev_device

2017-03-27 Thread Jan Blunck
On Mon, Mar 13, 2017 at 6:51 PM, Thomas Monjalon wrote: > 2017-03-06 11:56, Jan Blunck: >> This allows the virtual bus to be rescanned and probed by tracking the >> creation of rte_vdev_device. >> >> Signed-off-by: Jan Blunck >> Tested-by: Ferruh Yigit >> Acked-by: Shreyansh Jain > > There are

Re: [dpdk-dev] [PATCH v5 06/20] event/sw: add support for event queues

2017-03-27 Thread Jerin Jacob
On Fri, Mar 24, 2017 at 04:53:01PM +, Harry van Haaren wrote: > From: Bruce Richardson > > Add in the data structures for the event queues, and the eventdev > functions to create and destroy those queues. > > Signed-off-by: Bruce Richardson > Signed-off-by: Harry van Haaren > --- > driver

Re: [dpdk-dev] [PATCH 3/5] net/virtio-user: support to report net status

2017-03-27 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Friday, March 17, 2017 2:55 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; david.march...@6wind.com > Subject: Re: [PATCH 3/5] net/virtio-user: support to report net status > > On Fri, Mar 03, 2017 at 05:56

Re: [dpdk-dev] [PATCH v4 03/10] eal: move virtual device probing into a bus

2017-03-27 Thread Jan Blunck
On Mon, Mar 13, 2017 at 6:44 PM, Thomas Monjalon wrote: > 2017-03-06 11:56, Jan Blunck: >> +static int >> +vdev_scan(void) >> +{ >> + /* for virtual devices we don't need to scan anything */ >> + return 0; >> +} > > The vdev_scan could save the devargs. > The vdev args are the equivalent o

Re: [dpdk-dev] [PATCH v4 00/10] Rework vdev probing to use rte_bus infrastructure

2017-03-27 Thread Jan Blunck
On Mon, Mar 13, 2017 at 6:55 PM, Thomas Monjalon wrote: > 2017-03-06 11:56, Jan Blunck: >> Jan Blunck (10): >> eal: probe legacy PCI devices before other bus devices >> eal: probe new virtual bus after other bus devices >> eal: move virtual device probing into a bus >> eal: remove unused r

Re: [dpdk-dev] [PATCH v2] vhost: fix virtio_net false sharing

2017-03-27 Thread Yuanhan Liu
On Mon, Mar 27, 2017 at 09:34:19AM +0200, Maxime Coquelin wrote: > > > On 03/23/2017 04:44 PM, Kevin Traynor wrote: > >The broadcast_rarp field in the virtio_net struct is checked in the > >dequeue datapath regardless of whether descriptors are available or not. > > > >As it is checked with cmpse

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header includes

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, March 20, 2017 4:40 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio; Doherty, Declan > Subject: [PATCH] crypto/scheduler: fix header includes > > Fixes: 097ab0bac017 ("crypto/scheduler: add API") > Fix

Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

2017-03-27 Thread Andriy Berestovskyy
Hey Qiming, On 27.03.2017 08:15, Yang, Qiming wrote: I don't think this is a bug. Return errors when configure an invalid max_rx_pkt_len is suitable for this generic API. It is not a bug, it is an inconsistency. At the moment we can set max_rx_pkt_len for normal frames and if it is out of ra

Re: [dpdk-dev] [PATCH] mk: fix message when test application is not built

2017-03-27 Thread Thomas Monjalon
2017-03-20 11:35, Ferruh Yigit: > On 3/17/2017 5:09 PM, Olivier Matz wrote: > > To build the tests, we should use "make test-build". > > > > Fixes: 64592d97c1ae ("mk: do not build tests by default") > > > > Signed-off-by: Olivier Matz > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] mk: remove invalid phony target

2017-03-27 Thread Thomas Monjalon
2017-03-20 11:34, Ferruh Yigit: > On 3/17/2017 5:08 PM, Olivier Matz wrote: > > There was a typo in the .PHONY for the test-build target. If we fix the > > typo, the test-build target does not work, because it won't match the > > '%' target anymore. > > > > So just remove the .PHONY. > > > > Fixe

Re: [dpdk-dev] [PATCH v5 06/20] event/sw: add support for event queues

2017-03-27 Thread Bruce Richardson
On Mon, Mar 27, 2017 at 01:15:06PM +0530, Jerin Jacob wrote: > On Fri, Mar 24, 2017 at 04:53:01PM +, Harry van Haaren wrote: > > From: Bruce Richardson > > > > Add in the data structures for the event queues, and the eventdev > > functions to create and destroy those queues. > > > > Signed-o

[dpdk-dev] [PATCH] vhost: fix fd leaks for vhost-user server mode

2017-03-27 Thread Yuanhan Liu
A vhost-user server socket could have many connections, thus many connfd. However, we currently just use one single int var to store it. Meaning, it will get overwritten every time a new connection is created. While this will not create fatal issue as it sounds (since the correct connfd is closure

Re: [dpdk-dev] [PATCH v5 07/20] event/sw: add support for event ports

2017-03-27 Thread Jerin Jacob
On Fri, Mar 24, 2017 at 04:53:02PM +, Harry van Haaren wrote: > From: Bruce Richardson > > Add in the data-structures for the ports used by workers to send > packets to/from the scheduler. Also add in the functions to > create/destroy those ports. > > Signed-off-by: Bruce Richardson > Signe

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header includes

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, March 27, 2017 9:36 AM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: Gonzalez Monroy, Sergio; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header inclu

Re: [dpdk-dev] [PATCH 0/2] add support for "unsupported testcases" in test framework

2017-03-27 Thread Thomas Monjalon
2017-03-19 19:07, Jerin Jacob: > This patchset adds support for marking "unsupported" test case > if the test case returns -ENOTSUP. > The change was driven by the need that captured in the following link > > http://dpdk.org/ml/archives/dev/2017-March/059950.html > > Jerin Jacob (2): > test: st

Re: [dpdk-dev] Segm fault to the update acl context

2017-03-27 Thread Ananyev, Konstantin
Hi Victor, > hello, > > I'm running l3fwd-acl example as a daemon and trying to update acl context > with as a "swap" acl context, but the program stops with a segment fault > statement. Even using variables to direct which acl context the main loop > has to use, the program breaks. > > I have n

[dpdk-dev] [PATCH] doc: add known igb_uio issue for i40e

2017-03-27 Thread Qiming Yang
When insmod "igb_uio" with "intr_mode=legacy and test link status interrupt. Since INTx interrupt is not supported by X710/XL710/XXV710, it will cause Input/Output error when reading file descriptor. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 13 + 1 file changed, 13 i

Re: [dpdk-dev] [PATCH 1/2] net/tap: improve link_update

2017-03-27 Thread Pascal Mazon
On Fri, 24 Mar 2017 16:02:48 + Ferruh Yigit wrote: > On 3/22/2017 2:11 PM, Wiles, Keith wrote: > > > >> On Mar 22, 2017, at 3:40 AM, Pascal Mazon > >> wrote: > >> > >> Reflect device link status according to the state of the tap > >> netdevice and the remote netdevice (if any). If both are

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: rework tunnel filter functions

2017-03-27 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, March 23, 2017 6:46 PM > To: Wu, Jingjing > Cc: Zhang, Helin ; dev@dpdk.org > Subject: [PATCH v2 1/4] net/i40e: rework tunnel filter functions > > Rework tunnel filter functions to align with the new command buffer for > add/re

[dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Shreyansh Jain
Fixes: 17a4c3c16f5c ("doc: add DPAA2 NIC details") Signed-off-by: Shreyansh Jain --- doc/guides/nics/dpaa2.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst index 7d7a6c5..46225b6 100644 --- a/doc/guides/nics/dpaa2.rst

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Shreyansh Jain
On Monday 27 March 2017 03:25 PM, Shreyansh Jain wrote: Fixes: 17a4c3c16f5c ("doc: add DPAA2 NIC details") Signed-off-by: Shreyansh Jain --- doc/guides/nics/dpaa2.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst ind

Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

2017-03-27 Thread Thomas Monjalon
2017-03-24 17:09, Bruce Richardson: > The size and mask fields are duplicated in both the producer and > consumer data structures. Move them out of that into the top level > structure so they are not duplicated. > > Signed-off-by: Bruce Richardson > Acked-by: Olivier Matz Sorry Bruce, I encount

Re: [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF

2017-03-27 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, March 23, 2017 6:46 PM > To: Wu, Jingjing > Cc: Zhang, Helin ; dev@dpdk.org > Subject: [PATCH v2 3/4] net/i40e: support tunnel filter to VF > > Previously, only tunnel filter to PF is supported. > This patch adds i40e_dev_consi

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Ferruh Yigit
On 3/27/2017 10:57 AM, Shreyansh Jain wrote: > On Monday 27 March 2017 03:25 PM, Shreyansh Jain wrote: >> Fixes: 17a4c3c16f5c ("doc: add DPAA2 NIC details") >> >> Signed-off-by: Shreyansh Jain >> --- >> doc/guides/nics/dpaa2.rst | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> dif

Re: [dpdk-dev] [PATCH] eal: Fix device registration on FreeBSD

2017-03-27 Thread Thomas Monjalon
2017-03-27 11:34, Shreyansh Jain: > On Wednesday 22 March 2017 12:02 AM, Ben Walker wrote: > > The FreeBSD implementation wasn't registering new devices > > with the device framework on start up. However, common > > code attempts to unregister them on shutdown which causes > > a SEGFAULT. This fix

Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

2017-03-27 Thread Bruce Richardson
On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > 2017-03-24 17:09, Bruce Richardson: > > The size and mask fields are duplicated in both the producer and > > consumer data structures. Move them out of that into the top level > > structure so they are not duplicated. > > > > Signe

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Mcnamara, John
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Monday, March 27, 2017 10:55 AM > To: Yigit, Ferruh > Cc: hemant.agra...@nxp.com; dev@dpdk.org; Mcnamara, John > ; Shreyansh Jain > Subject: [PATCH] doc: fix DPAA2 guide build warning > > Fixes: 17a4c3c

Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

2017-03-27 Thread Bruce Richardson
On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > 2017-03-24 17:09, Bruce Richardson: > > The size and mask fields are duplicated in both the producer and > > consumer data structures. Move them out of that into the top level > > structure so they are not duplicated. > > > > Signe

Re: [dpdk-dev] [PATCH] doc: move i40e know issue to new file

2017-03-27 Thread Mcnamara, John
> -Original Message- > From: Yang, Qiming > Sent: Monday, March 27, 2017 2:44 AM > To: Mcnamara, John ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH] doc: move i40e know issue to new file > > > You are right, it's no need to introduce a new file, but Wenzhuo told me

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Monday, March 27, 2017 11:16 AM > To: Shreyansh Jain ; Yigit, Ferruh > > Cc: hemant.agra...@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning > >

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: rework tunnel filter functions

2017-03-27 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Monday, March 27, 2017 5:47 PM > To: Xing, Beilei > Cc: Zhang, Helin ; dev@dpdk.org; Iremonger, > Bernard > Subject: RE: [PATCH v2 1/4] net/i40e: rework tunnel filter functions > > > > > -Original Message- > > From: Xing, Beil

Re: [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF

2017-03-27 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Monday, March 27, 2017 5:55 PM > To: Xing, Beilei > Cc: Zhang, Helin ; dev@dpdk.org > Subject: RE: [PATCH v2 3/4] net/i40e: support tunnel filter to VF > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Thursday, Mar

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Shreyansh Jain
On Monday 27 March 2017 03:46 PM, Mcnamara, John wrote: -Original Message- From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] Sent: Monday, March 27, 2017 10:55 AM To: Yigit, Ferruh Cc: hemant.agra...@nxp.com; dev@dpdk.org; Mcnamara, John ; Shreyansh Jain Subject: [PATCH] doc: fix

Re: [dpdk-dev] [PATCH v3 00/46] LiquidIO PMD

2017-03-27 Thread Ferruh Yigit
On 3/25/2017 6:24 AM, Shijith Thotton wrote: > The patch series provides initial version of virtual function poll mode > driver for Cavium LiquidIO II server adapters. This version adds support > for LiquidIO II CN23XX 210SV adapters. > > Patch series includes driver documentation doc/guides/nics/

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Shreyansh Jain
On Monday 27 March 2017 04:01 PM, Mcnamara, John wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John Sent: Monday, March 27, 2017 11:16 AM To: Shreyansh Jain ; Yigit, Ferruh Cc: hemant.agra...@nxp.com; dev@dpdk.org Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string

2017-03-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Allain Legacy [mailto:allain.leg...@windriver.com] > Sent: Thursday, March 9, 2017 1:11 PM > To: Richardson, Bruce ; Dumitrescu, Cristian > > Cc: yuanhan@linux.intel.com; dev@dpdk.org > Subject: [PATCH v2 6/6] cfgfile: add support for empty value string >

[dpdk-dev] [PATCH v2] vfio: add hotplug support

2017-03-27 Thread Alejandro Lucero
Current device hotplug is just supported by UIO managed devices. This patch adds same functionality with VFIO. It has been validated through tests using IOMMU and also with VFIO and no-iommu mode. Signed-off-by: Alejandro Lucero --- app/Makefile | 1 + doc/

Re: [dpdk-dev] [PATCH 1/1] net/i40e: check return value of rte_zmalloc

2017-03-27 Thread Ferruh Yigit
On 3/25/2017 12:30 PM, caihe wrote: > Hi helin, > > There is a bug without check the return value of alloc memory in function > i40evf_add_del_all_mac_addr, > if we should fix it as below: Hi Caihe, Thank you for the patches. There are a few details to pay attention while sending patches, can

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Ferruh Yigit
On 3/27/2017 10:57 AM, Ferruh Yigit wrote: > On 3/27/2017 10:57 AM, Shreyansh Jain wrote: >> On Monday 27 March 2017 03:25 PM, Shreyansh Jain wrote: >>> Fixes: 17a4c3c16f5c ("doc: add DPAA2 NIC details") >>> >>> Signed-off-by: Shreyansh Jain >>> --- >>> doc/guides/nics/dpaa2.rst | 3 +-- >>> 1 fi

Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string

2017-03-27 Thread Legacy, Allain
We have a legacy file format that we need to support. Other parts of our system are able to handle a "key=" entry in the file so we are trying to gain parity with those parsers. Allain Allain Legacy, Software Developer direct 613.270.2279  fax 613.492.7870 skype allain.legacy   > -Or

Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string

2017-03-27 Thread Legacy, Allain
> -Original Message- > From: Legacy, Allain > Sent: Monday, March 27, 2017 7:13 AM > To: DUMITRESCU, CRISTIAN FLORIN; RICHARDSON, BRUCE > Cc: yuanhan@linux.intel.com; dev@dpdk.org > Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string > > We have a legacy file format

Re: [dpdk-dev] [PATCH v2 3/6] cfgfile: configurable comment character

2017-03-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Allain Legacy [mailto:allain.leg...@windriver.com] > Sent: Thursday, March 9, 2017 1:11 PM > To: Richardson, Bruce ; Dumitrescu, Cristian > > Cc: yuanhan@linux.intel.com; dev@dpdk.org > Subject: [PATCH v2 3/6] cfgfile: configurable comment character > >

Re: [dpdk-dev] [PATCH v5 08/20] event/sw: add support for linking queues to ports

2017-03-27 Thread Jerin Jacob
On Fri, Mar 24, 2017 at 04:53:03PM +, Harry van Haaren wrote: > From: Bruce Richardson > > Signed-off-by: Bruce Richardson > Signed-off-by: Harry van Haaren > --- > drivers/event/sw/sw_evdev.c | 81 > + > 1 file changed, 81 insertions(+) > > di

Re: [dpdk-dev] [PATCH 1/2] net/tap: improve link_update

2017-03-27 Thread Ferruh Yigit
On 3/27/2017 10:45 AM, Pascal Mazon wrote: > On Fri, 24 Mar 2017 16:02:48 + > Ferruh Yigit wrote: > >> On 3/22/2017 2:11 PM, Wiles, Keith wrote: >>> On Mar 22, 2017, at 3:40 AM, Pascal Mazon wrote: Reflect device link status according to the state of the tap netdevic

Re: [dpdk-dev] [PATCH] doc: fix DPAA2 guide build warning

2017-03-27 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 27, 2017 12:12 PM > To: Shreyansh Jain > Cc: hemant.agra...@nxp.com; dev@dpdk.org; Mcnamara, John > > Subject: Re: [PATCH] doc: fix DPAA2 guide build warning > > On 3/27/2017 10:57 AM, Ferruh Yigit wrote: > > On 3/27/2017

Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string

2017-03-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Legacy, Allain [mailto:allain.leg...@windriver.com] > Sent: Monday, March 27, 2017 12:13 PM > To: Dumitrescu, Cristian ; Richardson, Bruce > > Cc: yuanhan@linux.intel.com; dev@dpdk.org > Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value str

[dpdk-dev] [PATCH v2 1/9] app/crypto-perf: remove cyclecount test type

2017-03-27 Thread Pablo de Lara
Cyclecount test was not implemented, so it is removed. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_options.h | 1 - app/test-crypto-perf/cperf_options_parsing.c | 4 app/test-crypto-perf/main.c | 2 -- 3 files changed, 7 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH v2 0/9] Crypto performance app improvements

2017-03-27 Thread Pablo de Lara
This patchset makes the following changes in the crypto-perf app: - Adds the option to run performance tests on different buffer and burst sizes, in a single run, instead of having to run the application several times. - Cleans up the application, by removing unused functions and separating

[dpdk-dev] [PATCH v2 3/9] app/crypto-perf: fix AES CBC 128 test vectors

2017-03-27 Thread Pablo de Lara
Ciphertext and digests for different buffer sizes were incorrect. CC: sta...@dpdk.org Fixes: 5f1d85c5a8ab ("app/crypto-perf: add test vectors files") Signed-off-by: Pablo de Lara --- app/test-crypto-perf/data/aes_cbc_128_sha.data | 439 - 1 file changed, 219 insertions(+

[dpdk-dev] [PATCH v2 2/9] app/crypto-perf: remove unused file

2017-03-27 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_verify_parser.c | 314 - 1 file changed, 314 deletions(-) delete mode 100644 app/test-crypto-perf/cperf_verify_parser.c diff --git a/app/test-crypto-perf/cperf_verify_parser.c b/app/test-crypto-perf/cperf_v

[dpdk-dev] [PATCH v2 5/9] app/crypto-perf: do not append digest if not used

2017-03-27 Thread Pablo de Lara
When testing cipher only operations, there is no need to append digest at the end of the buffer. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_latency.c| 8 +--- app/test-crypto-perf/cperf_test_throughput.c | 10 ++ app/test-crypto-perf/cperf_test_verify.c

[dpdk-dev] [PATCH v2 4/9] app/crypto-perf: move verify as single test type

2017-03-27 Thread Pablo de Lara
From: Sergio Gonzalez Monroy In order to simplify throughput and latency tests, verify option has been removed from these and moved as a separate test. Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/Makefile| 1 + app/test-crypto-perf/cperf_ops.h |

[dpdk-dev] [PATCH v2 6/9] app/crypto-perf: display results in test runner

2017-03-27 Thread Pablo de Lara
Instead of printing the test results in the destructor function, print them just after each run. This will be useful for after the commit that allows a range of buffer and burst sizes. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_latency.c| 150 ++-

[dpdk-dev] [PATCH v2 7/9] app/crypto-perf: add range/list of sizes

2017-03-27 Thread Pablo de Lara
So far, the crypto performance application was only able to test one buffer size and one burst size. With this commit, multiple sizes can be passed, either as a range of values or as a list of values. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c | 20 +- ap

[dpdk-dev] [PATCH v2 8/9] app/crypto-perf: add extra option checks

2017-03-27 Thread Pablo de Lara
When using the verify test, test name is necessary to be passed when digest is needed. Also, when using an block cipher algorithm (CBC, ECB), the buffer size has to be aligned to the block size. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_options_parsing.c | 52 +

[dpdk-dev] [PATCH v2 9/9] app/crypto-perf: reorg options structure

2017-03-27 Thread Pablo de Lara
Reorganize options structure, to have all the parameters used in a single run in the first bytes of the structure, so all fit in a single cache line. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_options.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff -

Re: [dpdk-dev] [PATCH 1/2] net/tap: improve link_update

2017-03-27 Thread Pascal Mazon
On Mon, 27 Mar 2017 12:21:45 +0100 Ferruh Yigit wrote: > > There isn't time left for this release, proposal (v1) deadline is > passed long ago. Almost integration deadline is hit (end of this > week). > > If your other patches slip into next release, can you please send a > release notes updates

Re: [dpdk-dev] [PATCH v2 0/9] Crypto performance app improvements

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, March 27, 2017 12:26 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 0/9] Crypto performance app improvements > > This patchset makes the following changes in the crypto-perf app: >

[dpdk-dev] [PATCH] doc: add option to install PMD driver shared library

2017-03-27 Thread Reshma Pattan
Update the document with the available EAL command line option to install the pmd drivers that are built as shared libraries. Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/build_sample_apps.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg

Re: [dpdk-dev] [RFC] specifications for asymmetric crypto algorithms

2017-03-27 Thread Declan Doherty
On 22/03/2017 10:16 AM, Umesh Kartha wrote: This RFC contains specifications for asymmetric crypto algorithms. Asymmetric crypto algorithms are essential part of protocols such as SSL/TLS. As the current DPDK crypto library lacks support for asymmetric crypto algorithms, this RFC is an attempt t

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-27 Thread Sergio Gonzalez Monroy
On 09/03/2017 12:57, Ilya Maximets wrote: On 08.03.2017 16:46, Sergio Gonzalez Monroy wrote: Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quota limit on hu

Re: [dpdk-dev] [PATCH v11 08/18] lib: add symbol versioning to distributor

2017-03-27 Thread Thomas Monjalon
2017-03-20 10:08, David Hunt: > Also bumped up the ABI version number in the Makefile It would be good to explain the intent of versioning here. > Signed-off-by: David Hunt > Acked-by: Bruce Richardson > --- > lib/librte_distributor/Makefile| 2 +- > lib/librte_distributor

Re: [dpdk-dev] [PATCH v11 14/18] examples/distributor: tweaks for performance

2017-03-27 Thread Thomas Monjalon
2017-03-20 10:08, David Hunt: > Approximately 10% performance increase due to these changes. It would have been better to explain what are the changes. > Signed-off-by: David Hunt > Acked-by: Bruce Richardson > --- > examples/distributor/main.c | 36 +++- > 1 fi

Re: [dpdk-dev] [PATCH v11 0/18] distributor lib performance enhancements

2017-03-27 Thread Thomas Monjalon
2017-03-20 10:08, David Hunt: > This patch aims to improve the throughput of the distributor library. The patchset compiles, have been reviewed and acked. I have only 2 comments that can be addressed without sending a new version. Let's conclude in the commenting mails. Thanks

Re: [dpdk-dev] [PATCH v11 07/18] lib: make v20 header file private

2017-03-27 Thread Thomas Monjalon
2017-03-20 10:08, David Hunt: > Signed-off-by: David Hunt > Acked-by: Bruce Richardson [...] > SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h > -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h There is no explanation for this change. I think it w

Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

2017-03-27 Thread Thomas Monjalon
2017-03-27 11:15, Bruce Richardson: > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > > 2017-03-24 17:09, Bruce Richardson: > > > The size and mask fields are duplicated in both the producer and > > > consumer data structures. Move them out of that into the top level > > > struct

Re: [dpdk-dev] [PATCH v2] vfio: fix compile on older kernels

2017-03-27 Thread Thomas Monjalon
2017-03-23 12:56, Anatoly Burakov: > From: "Burakov, Anatoly" > > Fixing compile failures for kernels without sPAPR IOMMU support. > > Fixes: 0fe9830b5345 ("eal/ppc: support sPAPR IOMMU for vfio-pci") A blank line is missing also here ;) > Signed-off-by: Burakov, Anatoly > --- > v2: Fixed whi

Re: [dpdk-dev] [PATCH 0/3] cryptodev: change device configuration API

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Friday, February 17, 2017 12:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH 0/3] cryptodev: change device configuration API > > This patchset changes the cryptodev library's device configuration API > and updates

Re: [dpdk-dev] [PATCH] examples/dpdk-qat: remove app

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, March 22, 2017 4:57 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [PATCH] examples/dpdk-qat: remove app > > On Fri, Mar 03, 2017 at 04:10:49PM +, Pablo de Lara wrote: > > Remove DPDK QAT sample app,

Re: [dpdk-dev] [PATCH v5 09/20] event/sw: add worker core functions

2017-03-27 Thread Jerin Jacob
On Fri, Mar 24, 2017 at 04:53:04PM +, Harry van Haaren wrote: > From: Bruce Richardson > > add the event enqueue, dequeue and release functions to the eventdev. > These also include tracking of stats for observability in the load of > the scheduler. > Internally in the enqueue function, the v

Re: [dpdk-dev] [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto operations

2017-03-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Friday, March 24, 2017 9:58 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > Mcnamara, John; nhor...@tuxdriver.com; hemant.agra...@nxp.com; > Akhil Goyal >

Re: [dpdk-dev] [PATCH v7 00/14] eal: Remove most causes of panic on init

2017-03-27 Thread Thomas Monjalon
2017-03-23 14:04, Bruce Richardson: > On Wed, Mar 22, 2017 at 04:19:26PM -0400, Aaron Conole wrote: > > In many cases, it's enough to simply let the application know that the > > call to initialize DPDK has failed. A complete halt can then be > > decided by the application based on error returned

[dpdk-dev] doc: detail new tap features in release note

2017-03-27 Thread Pascal Mazon
Signed-off-by: Pascal Mazon --- doc/guides/rel_notes/release_17_05.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index dee63919efe7..4ab3e1a740c0 100644 --- a/doc/guides/rel_notes/release_17_05

[dpdk-dev] [PATCH 1/2] net/mlx4: fix returned values upon failed probing

2017-03-27 Thread Gaetan Rivet
Let error messages in place, but return unambiguous values upon probing errors. Fixes: 66e1591687ac ("mlx4: avoid init errors when kernel modules are not loaded") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 14 ++ 1 file

[dpdk-dev] [PATCH 2/2] net/mlx5: fix returned values upon failed probing

2017-03-27 Thread Gaetan Rivet
Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH] devtools: add test build to default build

2017-03-27 Thread Ferruh Yigit
Test build removed from default build, it needs to be added explicitly to the test-build script. Fixes: 7d3b1ec47fae ("test: move unit tests to separate directory") Signed-off-by: Ferruh Yigit --- devtools/test-build.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/de

[dpdk-dev] [PATCH] mk: use icc default inline limit

2017-03-27 Thread Ferruh Yigit
ICC build time Before this patch (bnx2x PMD enabled [1]) real8m16.622s After this patch (bnx2x enabled) real0m35.140s [1] bnx2x cause the build take a lot, otherwise build times are more sane numbers. ICC has a default inline limit and when this limit is hit it generates a warning, and i

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-27 Thread Ilya Maximets
On 27.03.2017 16:01, Sergio Gonzalez Monroy wrote: > On 09/03/2017 12:57, Ilya Maximets wrote: >> On 08.03.2017 16:46, Sergio Gonzalez Monroy wrote: >>> Hi Ilya, >>> >>> I have done similar tests and as you already pointed out, 'numactl >>> --interleave' does not seem to work as expected. >>> I ha

Re: [dpdk-dev] doc: detail new tap features in release note

2017-03-27 Thread Wiles, Keith
> On Mar 27, 2017, at 9:02 AM, Pascal Mazon wrote: > > Signed-off-by: Pascal Mazon Acked-by: Keith Wiles > --- > doc/guides/rel_notes/release_17_05.rst | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/guides/rel_notes/release_17_05.rst > b/doc/guides/rel_notes/relea

[dpdk-dev] [PATCH] drivers/crypto: fix drivers to use ring size function

2017-03-27 Thread Bruce Richardson
Rather than reading the size directly from the ring structure, use the dedicated ring function for that purpose. Previous commits to do this only did so for the null crypto driver which was the only one compiled in by default, but all other drivers need to be similarly updated. Fixes: b11c78a2e0c6

Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

2017-03-27 Thread Bruce Richardson
On Mon, Mar 27, 2017 at 03:13:04PM +0200, Thomas Monjalon wrote: > 2017-03-27 11:15, Bruce Richardson: > > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > > > 2017-03-24 17:09, Bruce Richardson: > > > > The size and mask fields are duplicated in both the producer and > > > > cons

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-27 Thread Ferruh Yigit
On 3/3/2017 3:40 PM, Gaetan Rivet wrote: > Most ConnectX-3 adapters expose two physical ports on a single PCI bus > address. > > Add a new port parameter allowing the user to choose > either or both physical ports to be used by the application. > > This parameter is used as follows: > > Selectin

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e

2017-03-27 Thread Ferruh Yigit
On 2/24/2017 3:24 AM, Wenzhuo Lu wrote: > This patch set enables several QoS features on i40e. > 1, VF max bandwidth setting. > 2, TC min bandwidth setting on a VF. > 3, TC max bandwidth setting on a VF. > 4, TC TX scheduling mode setting. > As there're no new interface between PF and VF defined, a

Re: [dpdk-dev] [PATCH v5 06/20] event/sw: add support for event queues

2017-03-27 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 27, 2017 8:45 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [PATCH v5 06/20] event/sw: add support for event queues > > On Fri, Mar 24, 2017 at 04:53:01PM +, Harry van Haaren w

Re: [dpdk-dev] [PATCH v8 0/3] new API to free consumed buffers in Tx ring

2017-03-27 Thread Thomas Monjalon
2017-03-24 14:55, Billy McFall: > See request from 11/21/2016: > http://dpdk.org/ml/archives/dev/2016-November/050585.html > > Add a new API to free consumed buffers on TX ring. This addresses two > scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Incre

Re: [dpdk-dev] [PATCH v5 02/20] event/sw: add new software-only eventdev driver

2017-03-27 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Saturday, March 25, 2017 6:24 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [PATCH v5 02/20] event/sw: add new software-only eventdev driver > > On Fri, Mar 24, 2017 at 04:52:57PM +, Harry v

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-27 Thread Gaƫtan Rivet
Hi Ferruh, On Mon, Mar 27, 2017 at 04:08:51PM +0100, Ferruh Yigit wrote: On 3/3/2017 3:40 PM, Gaetan Rivet wrote: Most ConnectX-3 adapters expose two physical ports on a single PCI bus address. Add a new port parameter allowing the user to choose either or both physical ports to be used by the

[dpdk-dev] [PATCH v2 1/1] net/mlx4: add port parameter

2017-03-27 Thread Gaetan Rivet
Most ConnectX-3 adapters expose two physical ports on a single PCI bus address. Add a new port parameter allowing the user to choose either or both physical ports to be used by the application. This parameter is used as follows: Selecting only the second port: -w 00:00.0,port=1 Selecting bot

Re: [dpdk-dev] [PATCH v5 11/20] event/sw: add start stop and close functions

2017-03-27 Thread Jerin Jacob
On Fri, Mar 24, 2017 at 04:53:06PM +, Harry van Haaren wrote: > From: Bruce Richardson > > Signed-off-by: Bruce Richardson > Signed-off-by: Harry van Haaren > --- > drivers/event/sw/sw_evdev.c | 74 > + > 1 file changed, 74 insertions(+) > > di

[dpdk-dev] Query for QAT software running in SR-IOV mode at VM

2017-03-27 Thread Pankaj Joshi
Hello Team, I have followed the steps given in section 10.4 in below link : http://dpdk.org/doc/guides/cryptodevs/qat.html 1. Export

[dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-27 Thread Allain Legacy
From: Matt Peters The current packet buffer alloc failures of the vhost dequeue operations can flood the log system with error logs due to logging a runtime error condition within the data path. In order to prevent this condition, but still enable debugging, the logs are being changed to debug l

[dpdk-dev] [PATCH] net/i40e: mbuf alloc failed counter not incremented

2017-03-27 Thread Allain Legacy
From: Matt Peters When an mbuf alloc fails during the mempool get operation for the i40e bulk alloc receive function, the rx_mbuf_alloc_failed counter is not incremented to record the error. This fix ensures consistency with the other i40e receive procedures and other net drivers. Signed-off-by

Re: [dpdk-dev] [PATCH v1] mempool/dpaa2: add DPAA2 hardware offloaded mempool

2017-03-27 Thread Olivier Matz
Hi Hemant, On Fri, 24 Mar 2017 17:42:46 +0100, Olivier Matz wrote: > > > From high level, I'm still a little puzzled by the amount of references > > > to mbuf in a mempool handler code, which should theorically handle any > > > kind of objects. > > > > > > Is it planned to support other kind of

Re: [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF

2017-03-27 Thread Ferruh Yigit
On 3/9/2017 6:08 AM, Xing, Beilei wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, March 8, 2017 11:50 PM >> To: Xing, Beilei ; Wu, Jingjing >> >> Cc: Zhang, Helin ; dev@dpdk.org; Iremonger, >> Bernard ; Liu, Yong >> Subject: Re: [dpdk-dev] [PATCH 3/4] net/i4

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx4: add port parameter

2017-03-27 Thread Ferruh Yigit
On 3/27/2017 4:41 PM, Gaetan Rivet wrote: > Most ConnectX-3 adapters expose two physical ports on a single PCI bus > address. > > Add a new port parameter allowing the user to choose > either or both physical ports to be used by the application. > > This parameter is used as follows: > > Selecti

  1   2   >