[dpdk-dev] ip_pipeline firewall : fragmented packets filtering

2017-03-10 Thread Shyam Shrivastav
Hi All Filtering based on TCP/UDP fields like src/dest port range works correctly only on non-fragmented packets , that means reassembly must be done before packets hit firewall rules table. Also packets must be fragmented before transmission if larger than port mtu. This is unsupported currently

Re: [dpdk-dev] [PATCH v3 1/6] net/tap: add MAC address management ops

2017-03-10 Thread Pascal Mazon
On Thu, 9 Mar 2017 14:05:51 + Ferruh Yigit wrote: > On 3/7/2017 4:31 PM, Pascal Mazon wrote: > > Set a random MAC address when probing the device, as to not leave an > > empty MAC in pmd->eth_addr. > > > > This MAC will be set on the tap netdevice as soon as it's been > > created using tun_a

Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

2017-03-10 Thread Pascal Mazon
On Thu, 9 Mar 2017 16:05:47 + Ferruh Yigit wrote: > On 3/9/2017 2:36 PM, Wiles, Keith wrote: > > > >> On Mar 9, 2017, at 8:18 AM, Yigit, Ferruh > >> wrote: > >> > >> On 3/7/2017 4:31 PM, Pascal Mazon wrote: > >>> Tap PMD is flexible, it supports any speed. > >>> > >>> Signed-off-by: Pascal

Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

2017-03-10 Thread Pascal Mazon
On Fri, 10 Mar 2017 10:03:12 +0100 Pascal Mazon wrote: > On Thu, 9 Mar 2017 16:05:47 + > Ferruh Yigit wrote: > > > On 3/9/2017 2:36 PM, Wiles, Keith wrote: > > > > > >> On Mar 9, 2017, at 8:18 AM, Yigit, Ferruh > > >> wrote: > > >> > > >> On 3/7/2017 4:31 PM, Pascal Mazon wrote: > > >>> T

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-10 Thread Gaëtan Rivet
On Thu, Mar 09, 2017 at 09:15:14AM +, Bruce Richardson wrote: On Wed, Mar 08, 2017 at 11:54:02AM -0500, Neil Horman wrote: On Wed, Mar 08, 2017 at 04:15:33PM +0100, Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes

Re: [dpdk-dev] [PATCH v3 3/4] net/tap: add netlink back-end for flow API

2017-03-10 Thread Pascal Mazon
On Thu, 9 Mar 2017 15:29:01 + Ferruh Yigit wrote: > On 3/7/2017 4:35 PM, Pascal Mazon wrote: > > Each kernel netdevice may have queueing disciplines set for it, > > which determine how to handle the packet (mostly on egress). That's > > part of the TC (Traffic Control) mechanism. > > This is

Re: [dpdk-dev] [PATCH v3 1/4] net/tap: move private elements to external header

2017-03-10 Thread Pascal Mazon
On Thu, 9 Mar 2017 15:28:31 + Ferruh Yigit wrote: > On 3/7/2017 4:35 PM, Pascal Mazon wrote: > > In the next patch, access to struct pmd_internals will be necessary > > in tap_flow.c to store the flows. > > > > Signed-off-by: Pascal Mazon > > Acked-by: Olga Shern > > --- > > drivers/net/t

Re: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for latencystats

2017-03-10 Thread Van Haaren, Harry
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Cc: dev@dpdk.org; Van Haaren, Harry ; Thomas > Monjalon > ; Pattan, Reshma > Subject: Re: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for > latencystats > > On Thu, 9 Mar 2017 16:25:32 + > Remy Horton wrote: >

Re: [dpdk-dev] DPDK17.02 flow classification can not take effect

2017-03-10 Thread Shyam Shrivastav
I am using 16.11 and noticed the same thing, mbuf->packet_type is not populated == 0 . On Thu, Mar 9, 2017 at 12:57 PM, Chillance Zen wrote: > previous 16.07 works well , when I examine the rte_mbuf->packet_type,I can > get the well-corresponded packet type. after migrating code to 17.02 ,I > w

Re: [dpdk-dev] [PATCH] devtools: make commits with stable tag outstanding

2017-03-10 Thread Thomas Monjalon
2017-02-23 10:49, Yuanhan Liu: > So that, as a stable maintainer while picking commits to a stable release, > I could pay less attention to those have it and pay more attention to those > don't have it. Good idea > + stable="-" > + git show $id | grep -qi 'Cc: .*sta...@dpdk.org' && stabl

Re: [dpdk-dev] FW: Issues with ixgbe and rte_flow

2017-03-10 Thread Adrien Mazarguil
Hi, On Fri, Mar 10, 2017 at 07:12:24AM +, Lu, Wenzhuo wrote: > Some replies in line. > Send it again with off the us...@dpdk.org. Seems I cannot send the mail > successfully with it. I'm removing everyone from the CC list and putting back dev@dpdk.org then, let's not break everyone's DPDK-r

[dpdk-dev] [PATCH 0/3] add support of musl

2017-03-10 Thread Wei Dai
musl is an alternative LIBC to GLIBC. It is an implementation of the userspace portion of the standard library functionality described in the ISO C and POSIX standards, plus common extensions. Some DPDK customers fail to build DPDK with musl. But so far execinfo.h is not supported by musl. In o

[dpdk-dev] [PATCH 1/3] examples/performance-thread: remove reference to execinfo.h

2017-03-10 Thread Wei Dai
There is no function to refer any part of it, so remove the reference to it. And there is no this file in musl. So need to remove it to support musl. The musl is an alternative LIBC to GLIBC and provides the standard C/POSIX library and extensions. The musl can be got from http://www.musl-libc.org

[dpdk-dev] [PATCH 2/3] config: add support of musl

2017-03-10 Thread Wei Dai
When building DPDK with musl, there is need to generate the MACRO named RTE_LIBC_MUSL in rte_config.h to remove some references to execinfo.h which is not supported by musl now. Got more details about musl from http://www.musl-libc.org . Signed-off-by: Wei Dai --- config/common_linuxapp | 1 +

[dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl

2017-03-10 Thread Wei Dai
execinfo.h is not supported by musl now. need to remove references to execinfo.h to build DPDK with musl. musl is an implementation of the userspace portion of the standard library functionality described in the ISO C and POSIX standards, plus common extensions. Get more details about musl from h

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

2017-03-10 Thread Ananyev, Konstantin
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Friday, March 10, 2017 3:28 AM > To: dev@dpdk.org; Ananyev, Konstantin > Cc: Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] examples/ip_fragmentation: fix check of packet type > > The packet_type in mbuf is not correctly filled by ixgb

Re: [dpdk-dev] [PATCH v3 5/6] net/tap: add packet type management

2017-03-10 Thread Pascal Mazon
On Thu, 9 Mar 2017 14:26:08 + Ferruh Yigit wrote: > On 3/7/2017 4:31 PM, Pascal Mazon wrote: > > Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet > > type. > > > > Signed-off-by: Pascal Mazon > > --- > > doc/guides/nics/features/tap.ini | 1 + > > drivers/net/tap/rte_eth_t

Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl

2017-03-10 Thread Thomas Monjalon
2017-03-10 19:58, Wei Dai: > @@ -47,6 +50,7 @@ > /* dump the stack of the calling core */ > void rte_dump_stack(void) > { > +#ifndef RTE_LIBC_MUSL > void *func[BACKTRACE_SIZE]; > char **symb = NULL; > int size; > @@ -64,6 +68,7 @@ void rte_dump_stack(void) > } > >

Re: [dpdk-dev] [PATCH] app/pdump: fix pdump can't find the driver when compiled dpdk to shared libraries

2017-03-10 Thread Thomas Monjalon
2017-03-03 17:27, zhaozhanxu: > When I compiled dpdk With configuration "CONFIG_RTE_BUILD_SHARED_LIB=y", > I get error message "EAL: no driver found for net_pcap_rx_0" and > "EAL: Driver cannot attach the device (net_pcap_rx_0)" by running pdump. > So I add library librte_pmd_pcap.so. [...] > +ifeq

Re: [dpdk-dev] [PATCH] kni: fast data availability check in thread_single loop

2017-03-10 Thread Thomas Monjalon
2017-01-18 07:11, Jay Rolette: > On Wed, Jan 18, 2017 at 5:05 AM, Sergey Vyazmitinov < > s.vyazmiti...@brain4net.com> wrote: > > > On Thu, Jan 12, 2017 at 12:29 AM, Ferruh Yigit > > wrote: > > > > > On 12/29/2016 11:23 PM, Sergey Vyazmitinov wrote: > > > > This allow to significant reduces packe

Re: [dpdk-dev] [PATCH v2 3/3] app/test: update test code

2017-03-10 Thread Thomas Monjalon
2017-03-07 04:19, Qi Zhang: > Update the test code to algin with callback function change. I think this patch must be squashed with the change in the header (patch 2). I have not tested but I guess the tests are not compiling between patch 2 and 3.

Re: [dpdk-dev] [PATCH v2 1/3] vfio: keep interrupt source read only

2017-03-10 Thread Thomas Monjalon
+Cc Anatoly, VFIO maintainer 2017-03-07 04:19, Qi Zhang: > Remove the inappropriate modification on get_max_intr > field that keep the intr_source read only. > > Signed-off-by: Qi Zhang

Re: [dpdk-dev] [PATCH] app/testpmd: Fix typos

2017-03-10 Thread Thomas Monjalon
2017-02-28 17:20, Mcnamara, John: > > fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c, > > app/test-pmd/testpmd.c > > > > Signed-off-by: Nirmoy Das > > > Hi Nirmoy, > > Thanks for that. > > Just a small heads-up since this is your first patch. The subject line should >

Re: [dpdk-dev] [PATCH] kni: fast data availability check in thread_single loop

2017-03-10 Thread Jay Rolette
On Fri, Mar 10, 2017 at 6:59 AM, Thomas Monjalon wrote: > 2017-01-18 07:11, Jay Rolette: > > On Wed, Jan 18, 2017 at 5:05 AM, Sergey Vyazmitinov < > > s.vyazmiti...@brain4net.com> wrote: > > > > > On Thu, Jan 12, 2017 at 12:29 AM, Ferruh Yigit > > > > wrote: > > > > > > > On 12/29/2016 11:23 PM

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Thomas Monjalon
2017-02-12 04:34, Wu, Jingjing: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/testpmd.c > > > > @@ -1490,13 +1490,13 @@ stop_port(portid_t pid) > > > > continue; > > > > } > > > > > > > > + rte_eth_dev_stop(pi); > > > > + > > >

Re: [dpdk-dev] [PATCH] app/testpmd: add default MAC set cmd

2017-03-10 Thread Thomas Monjalon
2017-03-03 10:20, Pascal Mazon: > Signed-off-by: Pascal Mazon > --- > app/test-pmd/cmdline.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) This patch looks trivial but waiting for Jingjing approval to be sure.

Re: [dpdk-dev] [PATCH v2 1/3] vfio: keep interrupt source read only

2017-03-10 Thread Burakov, Anatoly
> Remove the inappropriate modification on get_max_intr field that keep the > intr_source read only. > > Signed-off-by: Qi Zhang > --- Acked-by: Anatoly Burakov

Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options.

2017-03-10 Thread Thomas Monjalon
> > > Extended proc-info application to send DPDK port statistics to STDOUT in > > > the > > > format expected by collectd exec plugin. Added HOST ID option to identify > > > the > > > host DPDK process is running on when multiple instance of DPDK are > > > running in > > > parallel. This is nee

[dpdk-dev] [PATCH] net/e1000: advertise offload capabilities for the EM PMD

2017-03-10 Thread Allain Legacy
The hardware offload capabilities are not being advertised for the EM PMD. Because of this, applications that only enable these features if the device advertises them will never do so. Normally this is not an issue since normal packet processing should work even if hardware offload is not availabl

Re: [dpdk-dev] [PATCH] examples: optind should be reset to one not zero

2017-03-10 Thread Thomas Monjalon
2017-03-09 21:11, Wiles, Keith: > > > On Mar 9, 2017, at 2:41 PM, Thomas Monjalon > > wrote: > > > > 2017-02-14 16:09, Keith Wiles: > >> Signed-off-by: Keith Wiles > > > > Please, could explain and describe what was the consequence of this > > wrong reset value? > > You can just reply and I w

Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl

2017-03-10 Thread Jan Blunck
On Fri, Mar 10, 2017 at 1:40 PM, Thomas Monjalon wrote: > 2017-03-10 19:58, Wei Dai: >> @@ -47,6 +50,7 @@ >> /* dump the stack of the calling core */ >> void rte_dump_stack(void) >> { >> +#ifndef RTE_LIBC_MUSL >> void *func[BACKTRACE_SIZE]; >> char **symb = NULL; >> int size;

[dpdk-dev] [PATCH v2] eventdev: remove default queue overriding

2017-03-10 Thread Harry van Haaren
PMDs that only do a specific type of scheduling cannot provide CFG_ALL_TYPES, so the Eventdev infrastructure should not demand that every PMD supports CFG_ALL_TYPES. By not overriding the default configuration of the queue as suggested by the PMD, the eventdev_common unit tests can pass on all PMD

Re: [dpdk-dev] [PATCH v3 01/17] eventdev: fix API docs and test for timeout ticks

2017-03-10 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 6, 2017 10:34 AM > To: Van Haaren, Harry > Subject: Re: [PATCH v3 01/17] eventdev: fix API docs and test for timeout > ticks > > ret = rte_event_dequeue_timeout_ticks(TEST_DEV_ID,

[dpdk-dev] [RFC] New CLI for DPDK

2017-03-10 Thread Wiles, Keith
I would like to request for comments on a new CLI design and get any feedback. I have attached the cli.rst text, which is still a work in progress for you review. I have also ported the CLI to a version of Pktgen on the ‘dev’ branch of the repo in DPDK.org. http://dpdk.org/browse/apps/pktgen-d

[dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target

2017-03-10 Thread Jerin Jacob
Fixes: e438796617dc ("net/thunderx: add PMD skeleton") Signed-off-by: Jerin Jacob --- drivers/net/thunderx/nicvf_struct.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/thunderx/nicvf_struct.h b/drivers/net/thunderx/nicvf_struct.h index c900e12..0e4e1dd

[dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver

2017-03-10 Thread Jerin Jacob
Enable Thunderx nicvf PMD driver in the common config as it does not have any build dependency with any external library and/or architecture. Signed-off-by: Jerin Jacob --- config/common_base | 2 +- config/defconfig_arm64-thunderx-linuxapp-gcc | 10 -- doc/gui

Re: [dpdk-dev] [PATCH v9 04/18] lib: add new distributor code

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:19AM +, David Hunt wrote: > This patch includes public header file which will be used once > we add in the symbol versioning for v20 and v1705 APIs. > > Also includes v1702 header file, and code for new Now 1705. > burst-capable distributor library. This will be

Re: [dpdk-dev] [RFC] New CLI for DPDK

2017-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2017 15:25:31 + "Wiles, Keith" wrote: > I would like to request for comments on a new CLI design and get any > feedback. I have attached the cli.rst text, which is still a work in progress > for you review. > > I have also ported the CLI to a version of Pktgen on the ‘dev’ b

Re: [dpdk-dev] dpdk 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch issue

2017-03-10 Thread Jan Blunck
On Thu, Mar 9, 2017 at 3:22 AM, Wen Chiu wrote: > Hi, > > 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch is now > officially in dpdk 17.02. This is commit 1e2eff64f554 ("net/bonding: reconfigure all slave queues every time"). > But, it caused segmentation fault every time when >

Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote: > Also bumped up the ABI version number in the Makefile > > Signed-off-by: David Hunt > --- > lib/librte_distributor/Makefile| 2 +- > lib/librte_distributor/rte_distributor.c | 57 +++--- > lib/li

Re: [dpdk-dev] [RFC] New CLI for DPDK

2017-03-10 Thread Wiles, Keith
> On Mar 10, 2017, at 10:06 AM, Stephen Hemminger > wrote: > > On Fri, 10 Mar 2017 15:25:31 + > "Wiles, Keith" wrote: > >> I would like to request for comments on a new CLI design and get any >> feedback. I have attached the cli.rst text, which is still a work in >> progress for you rev

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Legacy, Allain
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Friday, March 03, 2017 10:40 AM ... > + errno = 0; > + tmp = strtoul(val, NULL, 0); The robustness of the strtoul() could be improved with something like the following to catch non-inte

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2017 16:24:32 + "Legacy, Allain" wrote: > The robustness of the strtoul() could be improved with something like the > following to catch non-integer characters following the port number. > > char *end = NULL; > tmp = strtoull(val, &end, 0); > if ((val[0] == '\0')

Re: [dpdk-dev] [RFC] New CLI for DPDK

2017-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2017 16:22:49 + "Wiles, Keith" wrote: > > On Mar 10, 2017, at 10:06 AM, Stephen Hemminger > > wrote: > > > > On Fri, 10 Mar 2017 15:25:31 + > > "Wiles, Keith" wrote: > > > >> I would like to request for comments on a new CLI design and get any > >> feedback. I have

Re: [dpdk-dev] [PATCH v9 12/18] examples/distributor: allow for extra stats

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:27AM +, David Hunt wrote: > This will allow us to see what's going on at various stages > throughout the sample app, with per-second visibility > > Signed-off-by: David Hunt > --- > examples/distributor/main.c | 139 > +++

Re: [dpdk-dev] [PATCH v9 13/18] sample: distributor: wait for ports to come up

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:28AM +, David Hunt wrote: > On some machines, ports take several seconds to come up. This > patch causes the app to wait. > > Signed-off-by: David Hunt Title prefix should match other patches. /Bruce

Re: [dpdk-dev] [PATCH v9 14/18] examples/distributor: give distributor a core

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:29AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- Title could do with some rewording - e.g. "make distributor API calls on dedicated core" This also requires an explanation as to why the change is being made. Does it not also need an update to the samp

Re: [dpdk-dev] [PATCH v9 15/18] examples/distributor: limit number of Tx rings

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:30AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- Please explain reason for change. /Bruce

Re: [dpdk-dev] [PATCH] app/testpmd: add default MAC set cmd

2017-03-10 Thread Wu, Jingjing
> -Original Message- > From: Pascal Mazon [mailto:pascal.ma...@6wind.com] > Sent: Friday, March 3, 2017 3:20 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Pascal Mazon > Subject: [PATCH] app/testpmd: add default MAC set cmd > > Signed-off-by: Pascal Mazon Acked-by: Jingjing Wu Just don

Re: [dpdk-dev] [PATCH v9 16/18] examples/distributor: give Rx thread a core

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:31AM +, David Hunt wrote: > This so that with the increased amount of stats we are counting, > we don't interfere with the rx core. > Where are the stats being counted in the current code and how would they interfere? /Bruce

Re: [dpdk-dev] [PATCH v9 00/18] distributor lib performance enhancements

2017-03-10 Thread Bruce Richardson
On Mon, Mar 06, 2017 at 09:10:15AM +, David Hunt wrote: > This patch aims to improve the throughput of the distributor library. > > It uses a similar handshake mechanism to the previous version of > the library, in that bits are used to indicate when packets are ready > to be sent to a worker

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Wu, Jingjing
> > To change minor, we can stop port, then configure VMDQ and then start port. > > > > You make port started in VMDQ config, the Symmetry of stop/start command > is broken and it is not easy to maintain. > > Should we close this patch in patchwork? Yes, I think so. Thanks Jingjing

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Iremonger, Bernard
> -Original Message- > From: Wu, Jingjing > Sent: Friday, March 10, 2017 4:56 PM > To: Thomas Monjalon ; Iremonger, Bernard > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop > > > > To change minor, we can stop port, then configure VMDQ and then st

Re: [dpdk-dev] [RFC] New CLI for DPDK

2017-03-10 Thread Wiles, Keith
> On Mar 10, 2017, at 10:41 AM, Stephen Hemminger > wrote: > > On Fri, 10 Mar 2017 16:22:49 + > "Wiles, Keith" wrote: > >>> On Mar 10, 2017, at 10:06 AM, Stephen Hemminger >>> wrote: >>> >>> On Fri, 10 Mar 2017 15:25:31 + >>> "Wiles, Keith" wrote: >>> I would like to request

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Gaëtan Rivet
Hey, thanks for reading. On Fri, Mar 10, 2017 at 04:24:32PM +, Legacy, Allain wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet Sent: Friday, March 03, 2017 10:40 AM ... + errno = 0; + tmp = strtoul(val, NULL, 0); The robustnes

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Gaëtan Rivet
slight additional remark below. On Fri, Mar 10, 2017 at 06:11:59PM +0100, Gaëtan Rivet wrote: Hey, thanks for reading. On Fri, Mar 10, 2017 at 04:24:32PM +, Legacy, Allain wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet Sent: Friday, Marc

Re: [dpdk-dev] [PATCH v6 00/26] linux/eal: Remove most causes of panic on init

2017-03-10 Thread Aaron Conole
"Richardson, Bruce" writes: >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] >> Sent: Thursday, March 9, 2017 9:26 AM >> To: Richardson, Bruce >> Cc: Aaron Conole ; dev@dpdk.org; Stephen Hemminger >> >> Subject: Re: [dpdk-dev] [PATCH v6 00/26] linux/eal:

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-10 Thread Dumitrescu, Cristian
> -Original Message- > From: O'Driscoll, Tim > Sent: Wednesday, March 8, 2017 9:52 AM > To: Dumitrescu, Cristian ; Thomas Monjalon > > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com; Wiles, Keith

[dpdk-dev] [PATCH v4 01/17] eventdev: increase size of enq deq conf variables

2017-03-10 Thread Harry van Haaren
Large port enqueue sizes were not supported as the value it was stored in was a uint8_t. Using uint8_ts to save space in config apis makes no sense - increasing the 3 instances of uint8_t enqueue / dequeue depths to more appropriate values (based on the context around them). Signed-off-by: Harry v

[dpdk-dev] [PATCH v4 00/17] next-eventdev: event/sw software eventdev

2017-03-10 Thread Harry van Haaren
The following patchset adds software eventdev implementation to the next-eventdev tree. Note that certain tests in this patchset require the queue overriding patch to pass, but it is not a build-time dependency. The main change is the reworked xstats_reset() API, which now includes a "mode" to s

[dpdk-dev] [PATCH v4 03/17] test/eventdev: rework timeout ticks test

2017-03-10 Thread Harry van Haaren
This commit reworks the failing of the timeout_ticks test to pass when -ENOTSUP is returned, as this is a valid return if the PMD does not support waiting on dequeue(). Signed-off-by: Harry van Haaren --- app/test/test_eventdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --g

[dpdk-dev] [PATCH v4 02/17] app/test: eventdev link all queues before start

2017-03-10 Thread Harry van Haaren
The software eventdev can lock-up if not all queues are linked to a port. For this reason, the software evendev fails to start if queues are not linked to anything. This commit creates dummy links from all queues to port 0 in the eventdev setup function and start/stop test, which would otherwise f

[dpdk-dev] [PATCH v4 04/17] eventdev: add APIs for extended stats

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add in APIs for extended stats so that eventdev implementations can report out information on their internal state. The APIs are based on, but not identical to, the equivalent ethdev functions. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v3 -> v

[dpdk-dev] [PATCH v4 05/17] event/sw: add new software-only eventdev driver

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson This adds the minimal changes to allow a SW eventdev implementation to be compiled, linked and created at run time. The eventdev does nothing, but can be created via vdev on commandline, e.g. sudo ./x86_64-native-linuxapp-gcc/app/test --vdev=event_sw0 ... PMD: Creati

[dpdk-dev] [PATCH v4 06/17] event/sw: add device capabilities function

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add in the info_get function to return details on the queues, flow, prioritization capabilities, etc. that this device has. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 23 +++ 1 file changed, 23 i

[dpdk-dev] [PATCH v4 08/17] event/sw: add fns to return default port/queue config

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Signed-off-by: Bruce Richardson --- drivers/event/sw/sw_evdev.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 28a2326..d1fa3a7 100644 --- a/drivers/event/sw/sw_evdev.c

[dpdk-dev] [PATCH v4 07/17] event/sw: add configure function

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 15 +++ drivers/event/sw/sw_evdev.h | 11 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c i

[dpdk-dev] [PATCH v4 09/17] event/sw: add support for event queues

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add in the data structures for the event queues, and the eventdev functions to create and destroy those queues. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v3 -> v4: - return -ENOTSUP for CFG_ALL_TYPES, as it is not supported - fix bug when reor

[dpdk-dev] [PATCH v4 10/17] event/sw: add support for event ports

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add in the data-structures for the ports used by workers to send packets to/from the scheduler. Also add in the functions to create/destroy those ports. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v3 -> v4: - fix port leaking credits on reconfig

[dpdk-dev] [PATCH v4 11/17] event/sw: add support for linking queues to ports

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v3 -> v4 - fix port ordered qid count by adding decrement in unlink() - fix port queue unlink count to allow reconfig from lb to single link --- drivers/event/sw/sw_evdev.c | 81 +++

[dpdk-dev] [PATCH v4 12/17] event/sw: add worker core functions

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson add the event enqueue, dequeue and release functions to the eventdev. These also include tracking of stats for observability in the load of the scheduler. Internally in the enqueue function, the various types of enqueue operations, to forward an existing event, to send a ne

[dpdk-dev] [PATCH v4 13/17] event/sw: add scheduling logic

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add in the scheduling function which takes the events from the producer queues and buffers them before scheduling them to consumer queues. The scheduling logic includes support for atomic, reordered, and parallel scheduling of flows. Signed-off-by: Bruce Richardson Signed

[dpdk-dev] [PATCH v4 15/17] event/sw: add dump function for easier debugging

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Segfault issue resolved when only partially configured and rte_event_dev_dump() is called before start(), Reported-by: Vipin Varghese Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 148 +

[dpdk-dev] [PATCH v4 14/17] event/sw: add start stop and close functions

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 74 + 1 file changed, 74 insertions(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index b1ae2b6..d4d

[dpdk-dev] [PATCH v4 17/17] app/test: add unit tests for SW eventdev driver

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Since the sw driver is a standalone lookaside device that has no HW requirements, we can provide a set of unit tests that test its functionality across the different queue types and with different input scenarios. This also adds the tests to be automatically run by autotes

[dpdk-dev] [PATCH v4 16/17] event/sw: add xstats support

2017-03-10 Thread Harry van Haaren
From: Bruce Richardson Add support for xstats to report out on the state of the eventdev. Useful for debugging and for unit tests, as well as observability at runtime and performance tuning of apps to work well with the scheduler. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren

[dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-10 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds config file read option to build LPM and EM tables. Ravi Kerur (3): examples/l3fwd: merge l3fwd-acl code into l3fwd examples/l3fwd: add config file support for lpm examples/l3fwd: add config file support for exact ex

[dpdk-dev] [PATCH v6 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-10 Thread Ravi Kerur
Merge l3fwd-acl code into l3fwd with '-A' cmdline option to run ACL. Performance critical ACL inline functions are moved from l3fwd-acl/main.c to l3fwd/l3fwd_acl_scalar.h. --- v6: > Change commit message format. v5: > None. v4: > Initialize rss_hf to IP for LPM, EM and AC

[dpdk-dev] [PATCH v6 2/3] examples/l3fwd: add config file support for lpm

2017-03-10 Thread Ravi Kerur
Add support to read from config file to build ipv4 and ipv6 longest prefix match forwarding tables. --- v6: > Change commit message format. v5: > Change is_bypass_line from inline to non-line. v4: > No changes. v3: > Fix additional checkpatch coding style issues.

[dpdk-dev] [PATCH v6 3/3] examples/l3fwd: add config file support for exact

2017-03-10 Thread Ravi Kerur
Add support to read from config file to build ipv4 and ipv6 exact match forwarding tables. --- v6: > Change commit message format v5: > No changes. v4: > No changes. v3: > Fix additional checkpatch coding style issues. v2: > Fix checkpatch warnings. v1:

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-10 Thread Neil Horman
On Fri, Mar 10, 2017 at 10:13:32AM +0100, Gaëtan Rivet wrote: > On Thu, Mar 09, 2017 at 09:15:14AM +, Bruce Richardson wrote: > > On Wed, Mar 08, 2017 at 11:54:02AM -0500, Neil Horman wrote: > > > On Wed, Mar 08, 2017 at 04:15:33PM +0100, Gaetan Rivet wrote: > > > > This PMD intercepts and mana

[dpdk-dev] [PATCH v2 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-10 Thread Yongseok Koh
This patchset is to add the Enhanced Multi-Packet Send feature which is newly introduced for ConnectX-5 families of adaptors. v2: * Resolves conflicts with other patches in review. * Improved performance by relocating code segment. * Changes default values of PMD options. * Fixed comments in the c

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-10 Thread Yongseok Koh
ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx descriptor can carry multiple packets either by including pointers of packets or by inlining packets. Inlining packet data can be helpful to better utilize PCIe bandwidth. In addition, Enhanced MPS supports hybrid mode - mix

[dpdk-dev] [PATCH v2 2/2] doc: update PMD options for mlx5

2017-03-10 Thread Yongseok Koh
Enhanced multi-packet send mode is newly introduced for ConnectX-5 families of adaptors. Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.r

[dpdk-dev] DPDK support for Emulex OneConnect OCe14000

2017-03-10 Thread Jordan Rhody
Hi, I was looking through the dev-dpdk archives to see if there was an answer to my question about support for Emulex. I only see one reference to Emulex and so I wanted to ask -- is there support? I notice that under the list of supported NICs, oce (for Emulex) is listed under 'Attic' but when

[dpdk-dev] [PATCH] net/virtio-user: support changing tap interface name

2017-03-10 Thread Wenfeng Liu
This patch adds a new option 'iface' to change the interface name of tap device with vhost-kernel as backend. Signed-off-by: Wenfeng Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +- drivers/net/virtio/virtio_use

[dpdk-dev] [PATCH] table: fix hash_ext stats update

2017-03-10 Thread Aleksey Katargin
Fixed stats double update. Signed-off-by: Aleksey Katargin --- lib/librte_table/rte_table_hash_ext.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c index e283a3d..353f930 100644