On Fri, Mar 10, 2017 at 1:40 PM, Thomas Monjalon
<thomas.monja...@6wind.com> wrote:
> 2017-03-10 19:58, Wei Dai:
>> @@ -47,6 +50,7 @@
>> /* dump the stack of the calling core */
>> void rte_dump_stack(void)
>> {
>> +#ifndef RTE_LIBC_MUSL
>> void *func[BACKTRACE_SIZE];
>> char **symb = NULL;
>> int size;
>> @@ -64,6 +68,7 @@ void rte_dump_stack(void)
>> }
>>
>> free(symb);
>> +#endif
>> }
>
> There are probably other libc implementations not supporting this feature.
> Instead of calling it "RTE_LIBC_MUSL", it should something like
> "ENABLE_BACKTRACE".
> Then you can add a musl section in the Linux quick start guide.
Also I would improve the code readability by removing the preprocessor
junk from it by moving the rte_dump_stack() function into
eal_backtrace.c and make that conditionally compile based on
CONFIG_ENABLE_BACKTRACE.
