> -----Original Message----- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 6, 2017 10:34 AM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Subject: Re: [PATCH v3 01/17] eventdev: fix API docs and test for timeout > ticks
<snip> > > ret = rte_event_dequeue_timeout_ticks(TEST_DEV_ID, 100, &timeout_ticks); > > - TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); > > + /* -ENOTSUP is a valid return if timeout is not supported by device */ > > + if (ret != -ENOTSUP) > > + TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); > > Header file change looks good. IMO, In the test case, We can introduce > TEST_UNSUPPORTED in addition to TEST_SUCCESS and TEST_FAILED to reflect > the actual status. I guess it will useful for future tests as well. Adding TEST_UNSUPPORTED requires a larger changeset than software eventdev should make to the test infrastructure; my preference is to use the error check solution as above for v4 patchset. Rework of testing infrastructure should be done on mainline dpdk if deemed required, and enable on Eventdev branch after a rebase.
