[dpdk-dev] [PATCH v2 2/2] net/ixgbe: add mac type check for all filters

2017-03-08 Thread Wei Zhao
All kinds of filter need to hardware mac type check to make sure the hardware support that type of fliter. If not, it may cause serious issue. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter") Fixes: eb3539fc8550 ("net/ixgbe: pars

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: move ixgbe 2 mac type check macro

2017-03-08 Thread Wei Zhao
move ixgbe 2 mac type check macro to ixgbe_ethdev.h in order to be used by filter parser functions in file ixgbe_flow.c. Fixes: 6c52c126f27a ("ixgbe: move to drivers/net/") Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 drivers/net/ixg

[dpdk-dev] [PATCH v2 2/2] net/ixgbe: add mac type check for all filters

2017-03-08 Thread Wei Zhao
All kinds of filter need to hardware mac type check to make sure the hardware support that type of fliter. If not, it may cause serious issue. v2: delete useless function declaration Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filt

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: move ixgbe 2 mac type check macro

2017-03-08 Thread Wei Zhao
move ixgbe 2 mac type check macro to ixgbe_ethdev.h in order to be used by filter parser functions in file ixgbe_flow.c. Fixes: 6c52c126f27a ("ixgbe: move to drivers/net/") Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 drivers/net/ixg

[dpdk-dev] checksum and vlan insertion seem not working on X520

2017-03-08 Thread Chillance Zen
Hi ,every one when I was conducting nic offloading exp,I can not make a x520 nic insert vlan ,nor checksum, here is my rx/tx capability: rx offload capability:9f tx offload capability:203f with code like this: while(1){ nr_mbufs=rte_eth_rx_burst(0,queue_id,mbufs,32); for(idx=0;idxhdr_checksum=0;

Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters

2017-03-08 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Zhao1, Wei > Sent: Monday, March 6, 2017 3:44 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all > filters > > Hi, Ferruh > > > -Original Message- > > From: Y

Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

2017-03-08 Thread Olivier MATZ
Hi Hemant, On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal wrote: > Adding NXP DPAA2 architecture specific mempool support. > > This patch also registers a dpaa2 type MEMPOOL OPS > > Signed-off-by: Hemant Agrawal > --- > MAINTAINERS | 1 + > config/common

Re: [dpdk-dev] checksum and vlan insertion seem not working on X520

2017-03-08 Thread Ananyev, Konstantin
Hi Linc, Wonder what TX function are you using? Make sure that you are not using simple TX function that doesn’t support any offloads or multiseg packets. You need something like that at setup phase: rte_eth_dev_info_get(port_id, &dev_info); dev_info.default_txconf.txq_flags = 0; ... rte_eth_tx_

Re: [dpdk-dev] Issues with ixgbe and rte_flow

2017-03-08 Thread Le Scouarnec Nicolas
My response is inline bellow, and further comment on the code excerpt also From: Lu, Wenzhuo Sent: Wednesday, March 8, 2017 4:16 AM To: Le Scouarnec Nicolas; dev@dpdk.org; Adrien Mazarguil (adrien.mazarg...@6wind.com) Cc: Yigit, Ferruh Subject: RE: Issues with ixgbe and rte_flow   >> I have

[dpdk-dev] [PATCH 2/9] mbuf: make raw free function public

2017-03-08 Thread Olivier Matz
Rename __rte_mbuf_raw_free() as rte_mbuf_raw_free() and make it public. The old function is kept for compat but is marked as deprecated. The next commit changes the behavior of rte_mbuf_raw_free() to make it more consistent with rte_mbuf_raw_alloc(). Signed-off-by: Olivier Matz --- drivers/net/

[dpdk-dev] [PATCH 1/9] mbuf: make segment prefree function public

2017-03-08 Thread Olivier Matz
Document the function and make it public, since it is used at several places in the drivers. The old one is marked as deprecated. Signed-off-by: Olivier Matz --- drivers/net/enic/enic_rxtx.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c| 6 +++--- drivers/net/fm10k/fm10k_rxtx

[dpdk-dev] [PATCH 3/9] mbuf: set mbuf fields while in pool

2017-03-08 Thread Olivier Matz
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL when the mbuf is stored inside the mempool (unused). This is done in rte_pktmbuf_prefree_seg(), before freeing or recycling a mbuf. Before this patch, the value of m->refcnt was expected to be 0 while in pool. The objectives are

[dpdk-dev] [PATCH 0/9] mbuf: structure reorganization

2017-03-08 Thread Olivier Matz
Based on discussions done in [1] and in this thread, this patchset reorganizes the mbuf. The main changes are: - reorder structure to increase vector performance on some non-ia platforms. - add a 64bits timestamp field in the 1st cache line. This timestamp is not normalized, i.e. no unit or ti

[dpdk-dev] [PATCH 4/9] drivers/net: don't touch mbuf next or nb segs on Rx

2017-03-08 Thread Olivier Matz
Now that the m->next pointer and m->nb_segs is expected to be set (to NULL and 1 respectively) after a mempool_get(), we can avoid to write them in the Rx functions of drivers. Only some drivers are patched, it's not an exhaustive patch. It gives the idea to do the same in other drivers. Signed-o

[dpdk-dev] [PATCH 8/9] mbuf: add a timestamp field

2017-03-08 Thread Olivier Matz
The field itself is not fully described yet, but this commit reserves the room in the mbuf. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h | 12 2 files changed, 14 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mb

[dpdk-dev] [PATCH 6/9] mbuf: use 2 bytes for port and nb segments

2017-03-08 Thread Olivier Matz
Change the size of m->port and m->nb_segs to 16 bits. It is now possible to reference a port identifier larger than 256 and have a mbuf chain larger than 256 segments. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 4 ++-- .../linuxapp/eal/include

[dpdk-dev] [PATCH 9/9] mbuf: reorder VLAN tci and buffer len fields

2017-03-08 Thread Olivier Matz
Move the vlan_tci field near vlan_tci_outer and buf_len near data_len for more consistency. It opens the door for get/set of the 2 vlan tci at the same time. Suggested-by: Andrey Chilikin Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 7 +++ 1 file changed, 3 insertions(+), 4

[dpdk-dev] [PATCH 7/9] mbuf: move sequence number in second cache line

2017-03-08 Thread Olivier Matz
Move this field in the second cache line, since no driver use it in Rx path. The freed space will be used by a timestamp in next commit. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH 5/9] mbuf: make rearm data address naturally aligned

2017-03-08 Thread Olivier Matz
From: Jerin Jacob To avoid multiple stores on fast path, Ethernet drivers aggregate the writes to data_off, refcnt, nb_segs and port to an uint64_t data and write the data in one shot with uint64_t* at &mbuf->rearm_data address. Some of the non-IA platforms have store operation overhead if the s

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-08 Thread O'Driscoll, Tim
> From: Dumitrescu, Cristian > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Monday, March 6, 2017 8:07 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > > balasubramanian.manoha...@cavium.com; hemant.ag

Re: [dpdk-dev] [PATCH v2 2/5] ring: add a function to return the ring size

2017-03-08 Thread Olivier MATZ
On Thu, 23 Feb 2017 16:42:00 +, Bruce Richardson wrote: > Applications and other libraries should not be reading inside the > rte_ring structure directly to get the ring size. Instead add a fn > to allow it to be queried. > > Signed-off-by: Bruce Richardson Acked-by: Olivier Matz

[dpdk-dev] [PATCH v3 0/4] net/tap: remote netdevice traffic capture

2017-03-08 Thread Pascal Mazon
This patchset adds the special "remote" feature to the tap PMD, that actually enables capturing traffic from another netdevice. This is especially useful to get packets into the DPDK app, when the remote netdevice has no DPDK support. The "remote" feature requires flow API support as flow rules wi

[dpdk-dev] [PATCH v3 1/4] net/tap: add remote netdevice traffic capture

2017-03-08 Thread Pascal Mazon
By default, a tap netdevice is of no use when not fed by a separate process. The ability to automatically feed it from another netdevice allows applications to capture any kind of traffic normally destined to the kernel stack. This patch implements this ability through a new optional "remote" para

[dpdk-dev] [PATCH v3 4/4] net/tap: set MTU on the remote

2017-03-08 Thread Pascal Mazon
Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05ed0a131d63..9edf6b355a47 100644 --- a/drivers/net/tap/rte_eth_tap.

[dpdk-dev] [PATCH v3 3/4] net/tap: use the remote MAC address if available

2017-03-08 Thread Pascal Mazon
The remote on a tap is most likely used with netdevices that are not under DPDK control. Outgoing traffic is supposed to use the source MAC address of the remote netdevice. This commit synchronizes the MAC address of the local tap netdevice with the remote one. Of course, it is still possible to

[dpdk-dev] [PATCH v3 2/4] net/tap: reflect tap flags on the remote

2017-03-08 Thread Pascal Mazon
Synchronize PROMISC and ALLMULTI flags to the remote netdevice if possible. Leave the IFF_UP flag as it is, however. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/rte_eth_tap.c | 37 - drivers/net/tap/tap.h | 2 ++ 2 files cha

Re: [dpdk-dev] [PATCH v2 07/14] ring: make bulk and burst fn return vals consistent

2017-03-08 Thread Olivier MATZ
On Tue, 7 Mar 2017 11:32:10 +, Bruce Richardson wrote: > The bulk fns for rings returns 0 for all elements enqueued and negative > for no space. Change that to make them consistent with the burst functions > in returning the number of elements enqueued/dequeued, i.e. 0 or N. > This change al

[dpdk-dev] [PATCH] eventdev: improve API docs for timeout ticks

2017-03-08 Thread Harry van Haaren
Improve the documentation of the return values of the rte_event_dequeue_timeout_ticks() function, adding a -ENOTSUP value for eventdevs that do not support waiting. Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob --- Discussion and previous Acked from: http://dpdk.org/ml/archives/dev/201

Re: [dpdk-dev] [PATCH] net/ixgbe: delete useless function declaration

2017-03-08 Thread Ferruh Yigit
On 3/8/2017 6:58 AM, Wei Zhao wrote: > delete useless function declarations in file ixgbe_flow.c and > adjust function defination position to aviod compile error. > > Signed-off-by: Wei Zhao Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: move ixgbe 2 mac type check macro

2017-03-08 Thread Ferruh Yigit
On 3/8/2017 7:58 AM, Wei Zhao wrote: > move ixgbe 2 mac type check macro to ixgbe_ethdev.h in > order to be used by filter parser functions in file > ixgbe_flow.c. > > Fixes: 6c52c126f27a ("ixgbe: move to drivers/net/") > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu Series applied to

Re: [dpdk-dev] [PATCH v1 12/14] ring: separate out head index manipulation for enq/deq

2017-03-08 Thread Olivier MATZ
On Thu, 23 Feb 2017 17:24:05 +, Bruce Richardson wrote: > We can write a single common function for head manipulation for enq > and a common one for deq, allowing us to have a single worker function > for enq and deq, rather than two of each. Update all other inline > functions to use the new

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: add port reset command into testpmd

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 4:56 AM, Wei Zhao wrote: > Add vf port reset command into testpmd project, it is the interface for > user to reset vf port. I think it is better to change the order of this patch, first implement new API in ethdev, later this patch implement new API in testpmd. > > Signed-off-by: Wei

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 06, 2017 3:28 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Doherty, Declan; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute > APIs >

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-03-08 Thread Ananyev, Konstantin
Hi Olivier, > > Hi Konstantin, > > On Tue, 28 Feb 2017 22:53:55 +, "Ananyev, Konstantin" > wrote: > > > > Another thing that doesn't look very convenient to me here - > > > > We can have 2 different values of timestamp (both normalized and not) > > > > and there is no clear way for the ap

Re: [dpdk-dev] [PATCH 3/3] net/i40e: implement device reset on port

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 4:56 AM, Wei Zhao wrote: > Implement the device reset function on vf port. > This restart function will detach device then > attach device, reconfigure dev, re-setup the Rx/Tx queues. > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu <...> > +static int i40evf_dev_uninit(stru

Re: [dpdk-dev] checksum and vlan insertion seem not working on X520

2017-03-08 Thread Chillance Zen
Hi Konstantin,Thank you so much ,I really appreciate your suggestion... it works well now ,I love it. Linc On 8 March 2017 at 17:20, Ananyev, Konstantin wrote: > Hi Linc, > > Wonder what TX function are you using? > Make sure that you are not using simple TX functio

Re: [dpdk-dev] i40e queues per VF

2017-03-08 Thread Thomas Monjalon
ping - still waiting for answers to below questions, please 2017-02-16 15:55, Thomas Monjalon: > 2017-02-16 13:58, Wu, Jingjing: > > From: Thomas Monjalon > > > > > > Hi, > > > > > > When reading the documentation, it is not easy to understand the > > > capability of > > > i40evf for the number

Re: [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash.

2017-03-08 Thread Thomas Monjalon
2017-03-02 11:00, Ami Sabo: > The patchset fixes secondary process crash issue when it tries > to access virtio-user pmd (e.g. via rte_eth_rx_burst). > > The crash happens because in virtio_user probing, > eth_dev_attach_secondary is not being called, as it does from > rte_eth_dev_pci_probe. There

Re: [dpdk-dev] [PATCH v2 0/5] net/i40e: support pipeline personalization profile

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 7:39 AM, Beilei Xing wrote: > Add APIs and driver to support load/get > i40e PPP (Pipeline Personalization Profile) Can you please describe what is "Pipeline Personalisation Profile" is? If possible please provide some links to documents. And please feel free to update NIC document abo

Re: [dpdk-dev] [PATCH v1 12/14] ring: separate out head index manipulation for enq/deq

2017-03-08 Thread Bruce Richardson
On Wed, Mar 08, 2017 at 11:49:06AM +0100, Olivier MATZ wrote: > On Thu, 23 Feb 2017 17:24:05 +, Bruce Richardson > wrote: > > We can write a single common function for head manipulation for enq > > and a common one for deq, allowing us to have a single worker function > > for enq and deq, rat

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: support pipeline personalization profile

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 7:39 AM, Beilei Xing wrote: > Add admin queue functions for Pipeline Personalization > Profile AQ commands defined in DCR 287: You can drop DCR reference here. > - Write Recipe Command buffer (Opcode: 0x0270) > - Get Applied Profiles list (Opcode: 0x0271) > This patch will be moved

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: add ppp processing

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 7:39 AM, Beilei Xing wrote: > Add loading profile function. > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 59 > + > drivers/net/i40e/rte_pmd_i40e.h | 7 + Also you need to update *version.map file for new API.

Re: [dpdk-dev] [PATCH v2 07/14] ring: make bulk and burst fn return vals consistent

2017-03-08 Thread Bruce Richardson
On Wed, Mar 08, 2017 at 11:22:40AM +0100, Olivier MATZ wrote: > On Tue, 7 Mar 2017 11:32:10 +, Bruce Richardson > wrote: > > The bulk fns for rings returns 0 for all elements enqueued and negative > > for no space. Change that to make them consistent with the burst functions > > in returning

Re: [dpdk-dev] [PATCH v2 3/5] app/testpmd: add command for writing personalization profile

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 7:39 AM, Beilei Xing wrote: > This patch is to add testpmd CLI for writing personalization > profile. > > Signed-off-by: Beilei Xing <...> > +static void > +cmd_write_ppp_parsed( > + void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((

Re: [dpdk-dev] [PATCH] eventdev: remove default queue overriding

2017-03-08 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 6, 2017 1:45 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH] eventdev: remove default queue overriding > > On Wed, Mar 01, 2017 at 12:49:02PM +, Harry van Haaren

Re: [dpdk-dev] [PATCHv8 00/46] NXP DPAA2 PMD

2017-03-08 Thread Shreyansh Jain
Hello Ferruh, > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 07, 2017 10:31 PM > To: Hemant Agrawal ; dev@dpdk.org > Cc: thomas.monja...@6wind.com; bruce.richard...@intel.com; Shreyansh Jain > ; john.mcnam...@intel.com; > jerin.ja...@cavium

Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

2017-03-08 Thread Jerin Jacob
On Wed, Mar 08, 2017 at 07:29:03AM +, Nipun Gupta wrote: > Thanks Jerin. Patchwork still shows this patch in new state. > Does this matter or shall I move it to accepted state? I have moved to accepted state. Thanks. > > Regards, > Nipun > > > -Original Message- > > From: Jerin Jaco

Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

2017-03-08 Thread Hemant Agrawal
Hi Olivier, Thanks for your detailed review. Please see inline... On 3/8/2017 2:35 PM, Olivier MATZ wrote: Hi Hemant, On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal wrote: Adding NXP DPAA2 architecture specific mempool support. This patch also registers a dpaa2 type MEMPOOL OPS

[dpdk-dev] Reg DPDK & PMD

2017-03-08 Thread raman geetha gopalakrishnan
Hi All, I have the following basic question. Hope to get an answer / link where i can get myself clear. 1. In DPDK PMD is optimized driver for an given NIC to get maximum performance. That being the case why we are talking about DPDK supported NICs. A) My assumption is that NIC interfac

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-08 Thread Sergio Gonzalez Monroy
Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quota limit on hugetlbfs mount point. I would be inclined towards *adding libnuma as dependency* to DPDK to m

Re: [dpdk-dev] [PATCH 1/2] Fix container_of() macro to work with const members

2017-03-08 Thread Thomas Monjalon
2017-02-27 15:14, Bruce Richardson: > On Mon, Feb 27, 2017 at 03:28:14PM +0100, Jan Blunck wrote: > > On Tue, Feb 14, 2017 at 3:36 PM, Jan Blunck wrote: > > > This fixes the usage of structure members that are declared const to get > > > a pointer to the embedding parent structure. > > > > Ping.

Re: [dpdk-dev] Reg DPDK & PMD

2017-03-08 Thread Bruce Richardson
On Wed, Mar 08, 2017 at 07:05:03PM +0530, raman geetha gopalakrishnan wrote: > Hi All, > > I have the following basic question. Hope to get an answer / link where i > can get myself clear. > > 1. In DPDK PMD is optimized driver for an given NIC to get maximum > performance. > That being the c

Re: [dpdk-dev] Reg DPDK & PMD

2017-03-08 Thread Ferruh Yigit
On 3/8/2017 1:35 PM, raman geetha gopalakrishnan wrote: > Hi All, > > I have the following basic question. Hope to get an answer / link where i > can get myself clear. > > 1. In DPDK PMD is optimized driver for an given NIC to get maximum > performance. > That being the case why we are talkin

Re: [dpdk-dev] Reg DPDK & PMD

2017-03-08 Thread Wiles, Keith
> On Mar 8, 2017, at 8:25 AM, Ferruh Yigit wrote: > > On 3/8/2017 1:35 PM, raman geetha gopalakrishnan wrote: >> Hi All, >> >> I have the following basic question. Hope to get an answer / link where i >> can get myself clear. >> >> 1. In DPDK PMD is optimized driver for an given NIC to get max

Re: [dpdk-dev] [PATCH v2 0/5] minor fixes and cleanup

2017-03-08 Thread Thomas Monjalon
2017-02-23 16:41, Bruce Richardson: > This patchset contains some minor fixes and improvements which > I found in the context of preparing a new patchset for the > rte_ring code. Having these merged separately reduces the > number of patches in the ring set so should make everyone's > life easier.

[dpdk-dev] [PATCH v2 02/13] ethdev: add flow API rule copy function

2017-03-08 Thread Gaetan Rivet
Take this helper from the testpmd app to offer it alongside the flow API. This allows PMDs and applications to save flow rules in their generic format for later processing. This is useful when rules cannot be applied immediately, such as when the device is not properly initialized. Signed-off-by:

[dpdk-dev] [PATCH v2 04/13] pci: expose device detach routine

2017-03-08 Thread Gaetan Rivet
Make the pci_detach_all_drivers public. No further changes. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 5 + lib/librte_eal/common/eal_common_pci.c | 6 +++--- lib/librte_eal/common/include/rte_pci.h | 15 +++ lib/librte_ea

[dpdk-dev] [PATCH v2 05/13] pci: expose parse and probe routines

2017-03-08 Thread Gaetan Rivet
Make pci_probe_all_drivers public, no further changes to it. Introduce a public function for pci_scan_one. This functions scan one device, but does not allocate that device or insert it within the device list. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v2 06/13] net/failsafe: add fail-safe PMD

2017-03-08 Thread Gaetan Rivet
Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefits from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes

[dpdk-dev] [PATCH v2 08/13] net/failsafe: add flexible device definition

2017-03-08 Thread Gaetan Rivet
Add the "exec" device type. The parameters given to this type of device will be executed in a shell. The output of this command is then used as a definition for a device. That command can be re-interpreted if the related device is not plugged-in. It allows for a device definition to react to syste

[dpdk-dev] [PATCH v2 10/13] net/failsafe: support offload capabilities

2017-03-08 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 6 ++ drivers/net/failsafe/failsafe_ops.c | 125 +- 2 files changed, 129 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guide

[dpdk-dev] [PATCH v2 11/13] net/failsafe: add fast burst functions

2017-03-08 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_private.h | 8 +++ drivers/net/failsafe/failsafe_rxtx.c| 117 ++-- 2 files changed, 105 insertions(+), 20 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/dri

[dpdk-dev] [PATCH v2 12/13] net/failsafe: support device removal

2017-03-08 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/fail_safe.rst | 14 +++ drivers/net/failsafe/failsafe_args.c| 22 +++ drivers/net/failsafe/failsafe_eal.c | 2 + drivers/net/failsafe/failsafe_ether.c | 67 - dri

[dpdk-dev] [PATCH v2 13/13] net/failsafe: support link status change event

2017-03-08 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 18 ++ drivers/net/failsafe/failsafe_ops.c | 24 drivers/net/failsafe/failsafe_pri

[dpdk-dev] [PATCH v2 01/13] ethdev: save VLAN filter setting

2017-03-08 Thread Gaetan Rivet
Other configuration items (i.e. MAC addresses) are stored within rte_eth_dev_data, but not this one. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 19 ++- lib/librte_ether/rte_ethdev.h | 10 ++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-08 Thread Gaetan Rivet
This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing applications do not need to be modified to benefit from true hot-plugging support. The stacked PMD approach shares many similarities with the

[dpdk-dev] [PATCH v2 09/13] net/failsafe: support flow API

2017-03-08 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_eal.c | 2 + drivers/net/failsafe/failsafe_ether.c | 76 +

[dpdk-dev] [PATCH v2 03/13] ethdev: add deferred intermediate device state

2017-03-08 Thread Gaetan Rivet
This device state means that the device is managed externally, by whichever party has set this state (PMD or application). Note: this new device state is only an information. The related device structure and operators are still valid and can be used normally. It is however made private by device

[dpdk-dev] [PATCH v2 07/13] net/failsafe: add plug-in support

2017-03-08 Thread Gaetan Rivet
Periodically check for the existence of a device. If a device has not been initialized and exists on the system, then it is probed and configured. The configuration process strives to synchronize the states between the plugged-in sub-device and the fail-safe device. Signed-off-by: Gaetan Rivet A

Re: [dpdk-dev] Issues with ixgbe and rte_flow

2017-03-08 Thread Adrien Mazarguil
CC'ing us...@dpdk.org since this issue primarily affects rte_flow users, and several PMD maintainers to get their opinion on the matter, see below. On Wed, Mar 08, 2017 at 09:24:26AM +, Le Scouarnec Nicolas wrote: > My response is inline bellow, and further comment on the code excerpt also >

Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

2017-03-08 Thread Thomas Monjalon
2017-03-08 18:22, Hemant Agrawal: > > On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal > > wrote: > > I think the current mempool handlers should be moved first in a > > separate patch. Yes it should have been done earlier. > Are you seeing any benefit by making it a separate patch series? A s

Re: [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:31 AM, Beilei Xing wrote: > This patch is to support tunnel filter to VF. > > Signed-off-by: Bernard Iremonger > Signed-off-by: Yong Liu > Signed-off-by: Beilei Xing > --- <...> > +/** > + * Tunneling Packet filter configuration. > + */ > +struct i40e_tunnel_filter_conf { There

Re: [dpdk-dev] [PATCH 0/4] support replace filter function

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:31 AM, Beilei Xing wrote: > This patchset adds replace filter function according > to DCR288 and supports cloud filter to VF. Is "cloud filter" common term, or specific to i40e ? Can you please provide small description about "cloud filter" here and provide links for more detailed i

Re: [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:31 AM, Beilei Xing wrote: > Add new admin queue function and extended fields > in DCR 288: > - Add admin queue function for Replace filter >command (Opcode: 0x025F) > - Add General fields for Add/Remove Cloud filters >command > > This patch will be removed to base driver in

Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:31 AM, Beilei Xing wrote: > Add i40e_tunnel_type enumeration type to refine consistent > tunnel filter, it will be esay to add new tunnel type for s/esay/easy > i40e. > > Signed-off-by: Beilei Xing <...> > /** > + * Tunnel type. > + */ > +enum i40e_tunnel_type { > + I40E_TU

Re: [dpdk-dev] [PATCH 2/4] net/i40e: rework tunnel filter functions

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:31 AM, Beilei Xing wrote: > Rework tunnel filter functions to align with the > new command buffer for add/remove cloud filter. > This patch also changes tunnel filter function > name to VXLAN filter function, it will be easy to > add other tunnel type parsing function. Can you pleas

[dpdk-dev] ip_pipeline firewall customization

2017-03-08 Thread Shyam Shrivastav
Hi All I am using ip_pipeline firewall as base for our project, need comments/suggestions/corrections regarding following 1) We can not configure firewall rule to drop packets, as portid is mandatory in command. I am planning to allow this for our requirement with following code changes a)

Re: [dpdk-dev] [PATCH 3/3] net/i40e: enable cloud filter for MPLS

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 9:43 AM, Beilei Xing wrote: > This patch enables MPLSoUDP and MPLSoGRE > cloud filter with replace cloud filter. > > Signed-off-by: Beilei Xing <...> > @@ -1286,6 +1286,9 @@ eth_i40e_dev_init(struct rte_eth_dev *dev) > if (ret < 0) > goto err_init_fdir_filter_lis

Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: add MCDI agnostic wrapper for MAC stats clear

2017-03-08 Thread Ferruh Yigit
On 3/3/2017 12:49 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > If a libefx-based driver needs some way to clear port statistics, > then an MCDI agnostic method is required. > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix incorrect packet index reference

2017-03-08 Thread Ferruh Yigit
On 3/5/2017 5:17 PM, Jianbo Liu wrote: > On 4 March 2017 at 13:00, Jerin Jacob wrote: >> Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") >> >> CC: sta...@dpdk.org >> Signed-off-by: Jerin Jacob >> Signed-off-by: Sunil Kulkarni > Acked-by: Jianbo Liu Applied to dpdk-next-net/mast

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-08 Thread Neil Horman
On Wed, Mar 08, 2017 at 04:15:33PM +0100, Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes them transparently when brought back so that > existing applications do not need to be modified to benefit from true > hot-pluggin

[dpdk-dev] [PATCH v3] app/crypto-perf: fix avoid wrong optype for AEAD algorithms

2017-03-08 Thread Daniel Mrzyglod
When somebody use bad --optype with aead alghorithms segmentation fault could happen. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Daniel Mrzyglod --- Changes for v3: - fix headline of this patch - add ccm alghorithm Changes for v2: - fix

Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: separate limitations on Tx DMA descriptors

2017-03-08 Thread Ferruh Yigit
On 3/6/2017 1:05 PM, Andrew Rybchenko wrote: > Siena has limitation on maximum byte count and 4k boundary crosssing > (which is stricter than maximum byte count). > EF10 has limitation on maximum byte count only. > > Fixes: f7dc06bf35f2 ("net/sfc/base: import 5xxx/6xxx family support") > Fixes: e7

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-08 Thread Ferruh Yigit
On 3/6/2017 4:14 PM, Wiles, Keith wrote: > >> On Mar 6, 2017, at 10:03 AM, Yigit, Ferruh wrote: >> >> On 3/6/2017 3:42 PM, Ferruh Yigit wrote: >>> On 3/6/2017 3:16 PM, Wiles, Keith wrote: > On Mar 6, 2017, at 9:13 AM, Pascal Mazon wrote: > > Store the device name in dev->data->n

Re: [dpdk-dev] [PATCH v5 09/12] doc: add NXP dpaa2 sec in cryptodev

2017-03-08 Thread Mcnamara, John
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, March 3, 2017 7:50 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan ; > De Lara Guarch, Pablo ; Mcnamara, John > ; nhor...@tuxdriver.com; hemant.agra...@nxp.com; > Akhil Goyal > Subj

[dpdk-dev] [PATCH v5 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-08 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds file read options to build LPM and EM tables. Ravi Kerur (3): examples/l3fwd: Merge l3fwd-acl code into l3fwd examples/l3fwd: add config file support for LPM examples/l3fwd: add config file support for EM examples/l3

[dpdk-dev] [PATCH v5 2/3] examples/l3fwd: add config file support for LPM

2017-03-08 Thread Ravi Kerur
Add config file support for v4 and v6 to build forwarding tables. v5: > Changes is_bypass_line from inline to non-line. v4: > No changes. v3: > Fix additional checkpatch coding style issues. v2: > Fix checkpatch warnings related to code > MACRO GET_CB_FIE

[dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM

2017-03-08 Thread Ravi Kerur
Add config file support for v4 and v6 to build exact match forwarding tables. v5: > No changes. v4: > No changes. v3: > Fix additional checkpatch coding style issues. v2: > Fix checkpatch warnings. v1: > Remove static array configuration of Dest IP,Src I

[dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-08 Thread Ravi Kerur
Merge l3fwd-acl code into l3fwd with '-A' cmdline option to run ACL. v5: > None. v4: > Initialize rss_hf to IP for LPM, EM and ACL. > Update rss_hf with l4 in parse_args for ACL. > Fix pending checkpatch code indentation warning. v3: > Fix additional check

Re: [dpdk-dev] [PATCH v6 06/26] eal-common: introduce a way to query cpu support

2017-03-08 Thread Thomas Monjalon
2017-02-28 13:52, Aaron Conole: > +/** > + * This function checks that the currently used CPU supports the CPU features > + * that were specified at compile time. It is called automatically within the > + * EAL, so does not need to be used by applications. This version returns a > + * result so th

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-08 Thread Ravi Kerur
John, Konstantin, Kindly let me know new 'v5' patch follows dpdk guidelines? I just followed what's in the dpdk contributing code guidelines. - git format-patch -3 -o patch/ -v 5 --cover-letter - git send-email --to dev@dpdk.org --in-reply-to patch/* Thanks. On Mon, Mar 6, 2017 at 3:2

Re: [dpdk-dev] [PATCH v6 00/26] linux/eal: Remove most causes of panic on init

2017-03-08 Thread Thomas Monjalon
Hi, Thanks for the work. I think it needs to be completed to have the same behaviour on bsdapp. As a another version is required, I add some small comments about the formatting. I think you should use the form "do not panic on " for most of the commits. Some commits may be squashed (see below):

Re: [dpdk-dev] [PATCH v6 20/26] eal_pci: continue probing even on failures

2017-03-08 Thread Thomas Monjalon
2017-02-28 13:53, Aaron Conole: > + int ret_1 = 0; You do not need to add a new variable. > int ret = 0; > > if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) == 0) > @@ -430,17 +432,20 @@ rte_eal_pci_probe(void) > > /* probe all or only whitelisted dev

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-08 Thread Chao Zhu
> From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] > Sent: 2017年3月6日 23:04 > To: dev@dpdk.org > Cc: Chao Zhu ; Anatoly Burakov > ; Thomas Monjalon > ; Gowrishankar Muthukrishnan > > Subject: [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in > ppc64le > > From: Gowris

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-08 Thread Chao Zhu
Thomas, Thanks for the reminder! I changed the mailer settings and acked again. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: 2017年3月7日 21:08 > To: Chao Zhu > Cc: 'Gowrishankar' ; dev@dpdk.org; > 'Anatoly Burakov' > Subject: Re: [PATCH v3] eal:

[dpdk-dev] dpdk 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch issue

2017-03-08 Thread Wen Chiu
Hi, 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch is now officially in dpdk 17.02. But, it caused segmentation fault every time when I configured bonding. In slave_configure(), "Setup Tx Queues" logic change from for q_id=old_nb_tx_queues to qid=0 which always enters the for

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: enable VF untag drop in testpmd

2017-03-08 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 7, 2017 7:14 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: enable VF untag drop in > testpmd > > On 3/3/2017 1:59 AM, Qi Zhang wrote: > > Add co

Re: [dpdk-dev] [PATCH v2 0/5] net/i40e: support pipeline personalization profile

2017-03-08 Thread Xing, Beilei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 8, 2017 7:43 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: Zhang, Helin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/5] net/i40e: support pipeline > personalization profile > > On 3/3/2017 7:39 AM, Beilei Xing wrote

Re: [dpdk-dev] Reg DPDK & PMD

2017-03-08 Thread raman geetha gopalakrishnan
Thanks a lot Bruce to correct my assumption. This was what i looked for. Thanks Raman On Wed, Mar 8, 2017 at 7:46 PM, Bruce Richardson wrote: > On Wed, Mar 08, 2017 at 07:05:03PM +0530, raman geetha gopalakrishnan > wrote: > > Hi All, > > > > I have the following basic question. Hope to get an

Re: [dpdk-dev] [PATCH 1/2] net/i40e: enable VF untag drop

2017-03-08 Thread Zhang, Qi Z
Hi Ferruh: > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 7, 2017 6:51 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: enable VF untag drop > > On 3/3/2017 1:59 AM, Qi Zhang wrote: > > Add a new pr

  1   2   >