[dpdk-dev] [PATCH v2 1/7] vhost: Enable VIRTIO_NET_F_MTU feature

This patch enables the new VIRTIO_NET_F_MTU feature, which makes possible for the host to advise the guest with its maximum supported MTU. MTU value is set via QEMU parameters, either via Libvirt XML, or directly in virtio-net device command line arguments. Signed-off-by: Maxime Coquelin --- li

[dpdk-dev] [PATCH v2 2/7] vhost: vhost-user: Add MTU protocol feature support

This patch implements the vhost-user MTU protocol feature support. When VIRTIO_NET_F_MTU is negotiated, QEMU notifies the vhost-user backend with the configured MTU if dedicated protocol feature is supported. The value can be used by the application to ensure consistency with value set by the user

[dpdk-dev] [PATCH v2 0/7] virtio/vhost: Add MTU feature support

This series adds support to new Virtio's MTU feature[1]. The MTU value is set via QEMU parameters. If the feature is negotiated (i.e supported by both host andcguest, and valid MTU value is set in QEMU via its host_mtu parameter), QEMU shares the configured MTU value throught dedicated Vhost proto

[dpdk-dev] [PATCH v2 4/7] vhost: Add API to get MTU value

This patch implements the function for the application to get the MTU value. rte_vhost_mtu_get() fills the mtu parameter with the MTU value set in QEMU if VIRTIO_NET_F_MTU has been negotiated and returns 0, -ENOTSUP otherwise. The function returns -EAGAIN if Virtio feature negotiation didn't happ

[dpdk-dev] [PATCH v2 3/7] vhost: Add new ready status flag

This patch adds a new status flag indicating the Virtio device is ready to operate. This is required to be able to call rte_vhost_mtu_get() in the .new_device() callback, as rte_vhost_mtu_get needs that the negotiation is done, but it is too early to rely on running status flag, which is set just

[dpdk-dev] [PATCH v2 5/7] net/vhost: Fill rte_eth_dev's MTU property

This patch adds a call to rte_vhost_mtu_get() at device creation time to fill device's MTU property when available. This makes the MTU value defined in QEMU cmdline accessible to the application by calling rte_eth_dev_get_mtu(). Signed-off-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost

[dpdk-dev] [PATCH v2 7/7] app/testpmd: print MTU value in show port info

This patch adds MTU display to "show port info" command. Signed-off-by: Maxime Coquelin --- app/test-pmd/config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 80491fc..73d9603 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v2 6/7] net/virtio: Add MTU feature support

This patch implements support for the Virtio MTU feature. When negotiated, the host shares its maximum supported MTU, which is used as initial MTU and as maximum MTU the application can set. Signed-off-by: Maxime Coquelin --- doc/guides/nics/features/virtio.ini | 1 + drivers/net/virtio/virtio_

Re: [dpdk-dev] [PATCH] net/mlx5: fix extended statistics counters identification

On Sun, Mar 05, 2017 at 02:02:48PM +0200, Shahaf Shuler wrote: > Checking whether the counter is IB counter was performed with the > wrong index. > > Fixes: a4e3056b7018 ("net/mlx5: add out of buffer counter to extended > statistic") > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler Acked

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

On Wed, Mar 01, 2017 at 08:36:24AM +0100, Maxime Coquelin wrote: > > > On 02/23/2017 06:49 AM, Yuanhan Liu wrote: > >On Wed, Feb 22, 2017 at 10:36:36AM +0100, Maxime Coquelin wrote: > >> > >> > >>On 02/22/2017 02:37 AM, Yuanhan Liu wrote: > >>>On Tue, Feb 21, 2017 at 06:32:43PM +0100, Maxime Coqu

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

On 3/2/2017 9:01 AM, Shahaf Shuler wrote: > Implement support for hardware TSO. > > Signed-off-by: Shahaf Shuler > --- > on v3: > * fix alignment issues > * for warn log > on v2: > * Instead of exposing capability, TSO checks on data path. > * PMD specific parameter to enable TSO. > * differ

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file

On 2/23/2017 10:44 AM, Vasily Philipov wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Wednesday, February 22, 2017 21:05 >> To: Vasily Philipov ; dev@dpdk.org >> Cc: Adrien Mazarguil ; Nélio Laranjeiro >> >> Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

On 3/6/2017 8:50 AM, Ferruh Yigit wrote: > On 3/2/2017 9:01 AM, Shahaf Shuler wrote: >> Implement support for hardware TSO. >> >> Signed-off-by: Shahaf Shuler >> --- >> on v3: >> * fix alignment issues >> * for warn log >> on v2: >> * Instead of exposing capability, TSO checks on data path. >>

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

On 3/2/2017 9:15 AM, Nélio Laranjeiro wrote: > On Thu, Mar 02, 2017 at 11:01:31AM +0200, Shahaf Shuler wrote: >> Implement support for hardware TSO. >> >> Signed-off-by: Shahaf Shuler > Acked-by: Nelio Laranjeiro Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add hardware checksum offload for tunnel packets

On 3/2/2017 9:17 AM, Nélio Laranjeiro wrote: > On Thu, Mar 02, 2017 at 11:05:44AM +0200, Shahaf Shuler wrote: >> Prior to this commit Tx checksum offload was supported only for the >> inner headers. >> This commit adds support for the hardware to compute the checksum for the >> outer headers as wel

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

Hi all. So, what about this change? Best regards, Ilya Maximets. On 16.02.2017 16:01, Ilya Maximets wrote: > Currently EAL allocates hugepages one by one not paying > attention from which NUMA node allocation was done. > > Such behaviour leads to allocation failure if number of > available huge

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix extended statistics counters identification

On 3/6/2017 8:43 AM, Adrien Mazarguil wrote: > On Sun, Mar 05, 2017 at 02:02:48PM +0200, Shahaf Shuler wrote: >> Checking whether the counter is IB counter was performed with the >> wrong index. >> >> Fixes: a4e3056b7018 ("net/mlx5: add out of buffer counter to extended >> statistic") >> Cc: sta..

[dpdk-dev] [PATCH 01/38] eal: add name field to generic device

This adds a name field to the generic struct rte_device. The EAL is checking for the name being populated when registering a device but doesn't enforce global unique names as this is left to the bus implementations. Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/eal_pci.c | 3 +++ l

[dpdk-dev] [PATCH 00/38] Remove struct eth_driver

This series is removing the PCI specific struct eth_driver from rte_ether. The PCI drivers are changed to use the newly introduced header-only helpers instead. Although the virtual drivers did not make use of the ethdev's driver field they are converted to use the VDEV specific allocation helpers.

[dpdk-dev] [PATCH 03/38] net/nfp: use library function for DMA zone reserve

This driver can use the library function rte_eth_dma_zone_reserve() instead of duplicating the code. Signed-off-by: Jan Blunck --- drivers/net/nfp/nfp_net.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net

[dpdk-dev] [PATCH 02/38] eal: parse "driver" device argument before probing drivers

In some cases the virtual device name should be totally different than the driver being used for the device. Therefore lets parse the devargs for the "driver" argument before probing drivers in vdev_probe_all_drivers(). Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 48 +

[dpdk-dev] [PATCH 05/38] ether: add allocation helper for virtual drivers

This helper should be used by ethdev drivers supporting virtual devices to help allocating a new ethdev and properly filling the default fields. Signed-off-by: Jan Blunck --- lib/librte_ether/Makefile | 1 + lib/librte_ether/rte_ethdev_vdev.h | 85 ++

[dpdk-dev] [PATCH 04/38] net/vmxnet3: use library function for DMA zone reserve

This driver can use the library function rte_eth_dma_zone_reserve() instead of duplicating the code. Signed-off-by: Jan Blunck --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rx

[dpdk-dev] [PATCH 06/38] net/tap: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/tap/rte_eth_tap.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 941150f..f6f025f 100644 --- a/drivers/net/tap/rte_eth_tap.c +

[dpdk-dev] [PATCH 07/38] net/vhost: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/vhost/rte_eth_vhost.c | 54 +++ 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index d0d0474..e2dae6f 100644 --- a/drivers/net/vhos

[dpdk-dev] [PATCH 08/38] net/virtio: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/virtio/virtio_user_ethdev.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 42ad8a2..15e3a93 100644 --- a/drivers/net/virtio

[dpdk-dev] [PATCH 09/38] net/af_packet: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/af_packet/rte_eth_af_packet.c | 42 ++- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 77536e8..6f6ba0c 100644 --- a/

[dpdk-dev] [PATCH 10/38] app/test: don't short-circuit null device creation

A virtual device should get initialized through the rte_eal_vdev_init() function to properly initialize the driver. Signed-off-by: Jan Blunck --- drivers/net/null/rte_eth_null.c | 1 + test/test/test_link_bonding_rssconf.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH 11/38] net/null: internalize eth_dev_null_create()

There is no need to export this API. Remaining users should use the rte_eal_vdev_init() function instead. Signed-off-by: Jan Blunck --- drivers/net/null/Makefile | 7 +- drivers/net/null/rte_eth_null.c | 4 +--- drivers/net/null/rte_eth_null.h | 40 -

[dpdk-dev] [PATCH 12/38] net/null: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/null/rte_eth_null.c | 50 ++--- 1 file changed, 17 insertions(+), 33 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 14f35d7..226c2e4 100644 --- a/drivers/net/null/rte_

[dpdk-dev] [PATCH 13/38] net/bonding: make bonding API call through EAL on create/free

To properly embed the generic rte_device into the rte_eth_dev this reworks the bonding API to call through rte_eal_vdev_init(). Signed-off-by: Jan Blunck --- drivers/net/bonding/rte_eth_bond_api.c | 171 +-- drivers/net/bonding/rte_eth_bond_args.c | 2 +- drivers/n

[dpdk-dev] [PATCH 14/38] net/bonding: use ethdev allocation helper for virtual devices

Signed-off-by: Jan Blunck --- drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index c0d08a8..3c80ff5 100644 --- a/drivers/net/bonding/r

[dpdk-dev] [PATCH 15/38] ethdev: add PCI driver helpers

This adds the following helper intended to be used by rte_pci_driver implementations working with ethdev: - rte_eth_dev_pci_allocate - rte_eth_dev_pci_release - rte_eth_dev_pci_generic_probe - rte_eth_dev_pci_generic_remove Signed-off-by: Jan Blunck --- lib/librte_ether/Makefile | 1 +

[dpdk-dev] [PATCH 17/38] net/bnx2x: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/bnx2x/bnx2x_ethdev.c | 64 +++- 1 file changed, 44 insertions(+), 20 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index a0b0dfa..e295951 100644 --- a/drivers/net/bnx2x/b

[dpdk-dev] [PATCH 16/38] net/virtio: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/virtio/virtio_ethdev.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 4dc03b9..a600ca5 100644 --- a/drivers/net/virtio

[dpdk-dev] [PATCH 19/38] net/cxgbe: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/cxgbe/cxgbe_ethdev.c | 29 +++-- drivers/net/cxgbe/sge.c | 6 +++--- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 4d543a7..34fe

[dpdk-dev] [PATCH 18/38] net/bnxt: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/bnxt/bnxt_ethdev.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 6167443..5dc3ff0 100644 --- a/drivers/net/bnxt/bnxt_ethdev.

[dpdk-dev] [PATCH 20/38] net/em: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/e1000/em_ethdev.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 4066ef9..39a62a3 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/dr

[dpdk-dev] [PATCH 22/38] net/ena: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/ena/ena_ethdev.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index b5e6db6..41573ae 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers

[dpdk-dev] [PATCH 24/38] net/fm10k: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/fm10k/fm10k_ethdev.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index c4fe746..5bb0426 100644 --- a/drivers/net/fm10k/fm10k_ethde

[dpdk-dev] [PATCH 21/38] net/igb: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/e1000/igb_ethdev.c | 60 ++ 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a112b38..1a162cc 100644 --- a/drivers/net/e1000/igb_e

[dpdk-dev] [PATCH 23/38] net/enic: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/enic/enic_ethdev.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index bffa870..57f71c7 100644 --- a/drivers/net/enic/enic_ethdev.c +++ b

[dpdk-dev] [PATCH 26/38] net/i40evf: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/i40e/i40e_ethdev_vf.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 55fd344..2a10ad5 100644 --- a/drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH 28/38] net/mlx: Don't reference eth_driver

The eth_driver concept is unused in the mlx drivers so don't reference it. Signed-off-by: Jan Blunck --- drivers/net/mlx4/mlx4.c | 17 +++-- drivers/net/mlx5/mlx5.c | 19 --- 2 files changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/dr

[dpdk-dev] [PATCH 27/38] net/ixgbe: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/ixgbe/ixgbe_ethdev.c | 66 1 file changed, 40 insertions(+), 26 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 7169007..de5e3c2 100644 --- a/drivers/net/ixgbe/i

[dpdk-dev] [PATCH 25/38] net/i40e: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/i40e/i40e_ethdev.c | 36 ++-- drivers/net/i40e/i40e_fdir.c | 2 +- 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 303027b..8d4e509 1

[dpdk-dev] [PATCH 29/38] net/nfp: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/nfp/nfp_net.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index b9dfe80..4cc003e 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp

[dpdk-dev] [PATCH 30/38] net/qede: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/qede/qede_ethdev.c | 60 +- drivers/net/qede/qede_ethdev.h | 1 + 2 files changed, 37 insertions(+), 24 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 0494dbd..8dfd

[dpdk-dev] [PATCH 33/38] net/thunderx: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/thunderx/nicvf_ethdev.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index 1060319..fa17f10 100644 --- a/drivers/net/thunderx

[dpdk-dev] [PATCH 32/38] net/szedata2: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/szedata2/rte_eth_szedata2.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c index fe7a6b3..54212b7 100644 --- a/drivers/

[dpdk-dev] [PATCH 31/38] net/sfc: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/sfc/sfc_ethdev.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 71587fb..ef8970d 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/dr

[dpdk-dev] [PATCH 34/38] net/vmxnet3: Don't use eth_driver

Signed-off-by: Jan Blunck --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index b7b5377..9e6fffa 100644 --- a/drivers/net/vmxn

[dpdk-dev] [PATCH 35/38] ethdev: remove unused ethdev PCI probe/remove

This removes the now unused rte_eth_dev_pci_probe() and rte_eth_dev_pci_remove() functions. Signed-off-by: Jan Blunck --- lib/librte_ether/rte_ethdev.c | 97 -- lib/librte_ether/rte_ethdev.h | 15 -- lib/librte_ether/rte_ethdev_pci.h | 1

[dpdk-dev] [PATCH 38/38] ethdev: don't include PCI header

Since the PCI functionality has been moved to the PCI specific ethdev header we don't need to include rte_pci.h from here anymore. Signed-off-by: Jan Blunck --- lib/librte_ether/rte_ethdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib

[dpdk-dev] [PATCH 36/38] ethdev: remove unused ethdev driver

This removes the now unused struct eth_driver. Signed-off-by: Jan Blunck --- drivers/net/cxgbe/cxgbe_main.c | 1 - drivers/net/ring/rte_eth_ring.c| 1 - lib/librte_ether/rte_ethdev.h | 73 -- lib/librte_ether/rte_ethdev_pci.h | 2 -- lib/librt

[dpdk-dev] [PATCH 37/38] ethdev: remove PCI specific helper from generic ethdev header

This moves the rte_eth_copy_pci_info() into the PCI specific ethdev header. As a side effect this also removes it from the list of symbols exported by the rte_ethdev library. Signed-off-by: Jan Blunck --- drivers/net/cxgbe/cxgbe_main.c | 1 + lib/librte_ether/rte_ethdev.c | 20

Re: [dpdk-dev] [PATCH 1/6] net/sfc: add VFs to the table of PCI IDs for supported NICs

On 3/2/2017 3:46 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andrew Lee > --- > drivers/net/sfc/sfc_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/ne

Re: [dpdk-dev] [PATCH 1/4] ethdev: add retrieving xstats by group and xstats by name

Hi, 2017-03-03 13:54, Kuba Kozak: > From: Jacek Piasecki > > This patch extends library for retriving xstats by specified groups and > single xstat by given name. > > Signed-off-by: Jacek Piasecki > Signed-off-by: Kuba Kozak As you probably know, it is difficult to have a good review (or a s

Re: [dpdk-dev] [PATCH 5/6] net/sfc: port must not fail to start if Rx mode is rejected

On 3/2/2017 3:46 PM, Andrew Rybchenko wrote: > From: Ivan Malov Hi Ivan, Can you please update patch title to indicate what has been done, starting with a verb. It is harder to understand patch content from statements. Thanks, ferruh > > If Rx mode is unacceptable, in particular, when promis

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

Hi Cristian, 2017-03-04 01:10, Cristian Dumitrescu: > struct rte_flow_ops *eth_flow_ops; > int rte = rte_eth_dev_filter_ctrl(eth_port_id, > RTE_ETH_FILTER_GENERIC, RTE_ETH_FILTER_GET, ð_flow_ops); > > Unfortunately, the rte_flow opportunistically uses the > rte_eth_dev_filter_ctrl() > API

Re: [dpdk-dev] [PATCH v3 01/17] eventdev: fix API docs and test for timeout ticks

On Fri, Feb 17, 2017 at 02:53:56PM +, Harry van Haaren wrote: > This commit improves the documentation of the api return > values for rte_event_dequeue_timeout_ticks(), and allows > -ENOTSUP to be returned by devices which do not support > timeouts. > > The unit test is modified to accept -ENO

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-04 01:10, Cristian Dumitrescu: > This patch introduces the generic ethdev API for the traffic manager > capability, which includes: hierarchical scheduling, traffic shaping, > congestion management, packet marking. We already have some API for QoS. Why integrating them in ethdev? ethdev is

Re: [dpdk-dev] [PATCH 0/6] get status of Rx and Tx descriptors

2017-03-02 14:40, Olivier Matz: > On Wed, 1 Mar 2017 21:02:16 +0300, Andrew Rybchenko > wrote: > > On 03/01/2017 08:19 PM, Olivier Matz wrote: > > > This patchset introduces a new ethdev API: > > > - rte_eth_rx_descriptor_status() > > > - rte_eth_tx_descriptor_status() > > > > May be correspon

Re: [dpdk-dev] [PATCH 0/6] get status of Rx and Tx descriptors

2017-03-02 14:43, Olivier Matz: > Hi Stephen, > > On Wed, 1 Mar 2017 10:07:06 -0800, Stephen Hemminger > wrote: > > On Wed, 1 Mar 2017 18:19:06 +0100 > > Olivier Matz wrote: > > > > > This patchset introduces a new ethdev API: > > > - rte_eth_rx_descriptor_status() > > > - rte_eth_tx_descript

[dpdk-dev] [PATCH v4 01/10] eal: probe legacy PCI devices before other bus devices

Make sure that the PCI devices are probed before the virtual devices after the legacy virtual device probing has been moved to a bus. Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 8 lib/librte_eal/linuxapp/eal/eal.c

[dpdk-dev] [PATCH v4 00/10] Rework vdev probing to use rte_bus infrastructure

With the rte_bus infrastructure present in 17.02 it is possible to refactor the virtual device probing into a bus. This series also introduces the rte_vdev_device to better keep track of devices. This patchset depends on: http://dpdk.org/dev/patchwork/patch/20416/ http://dpdk.org/dev/patchwork/pat

[dpdk-dev] [PATCH v4 03/10] eal: move virtual device probing into a bus

This is a refactoring of the virtual device probing which moves into into a proper bus structure. Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 22 - lib/librte_eal/common/eal_common_vdev.c | 44

[dpdk-dev] [PATCH v4 02/10] eal: probe new virtual bus after other bus devices

Also see commit f4ce209a8ce5 ("eal: postpone vdev initialization"). Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common

[dpdk-dev] [PATCH v4 05/10] eal: Refactor vdev driver probe/remove

This is a preparation for the introduction of the struct rte_vdev_device. Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_vdev.c | 44 - 1 file changed, 33 insertions(+), 11 deletions(-) diff --git

[dpdk-dev] [PATCH v4 04/10] eal: remove unused rte_eal_dev_init()

Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 3 --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 - lib/librte_eal/common/eal_common_dev.c | 6 -- lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v4 06/10] eal: add struct rte_vdev_device

This adds the rte_vdev_device structure which embeds a generic rte_device. Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_vdev.c | 5 + lib/librte_eal/common/include/rte_vdev.h | 5 + 2 files changed, 10 insertions(+) d

[dpdk-dev] [PATCH v4 07/10] eal: add virtual device name helper function

This adds the rte_vdev_device_name() helper function to retrieve the rte_vdev_device name which makes moving the name of the low-level device into struct rte_device easier in the future. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_vdev.h | 9

[dpdk-dev] [PATCH v4 08/10] eal: add virtual device arguments helper function

This adds the rte_vdev_device_args() helper function to prepare for changing the virtual drivers probe() functions take a rte_vdev_device pointer instead of the name+args strings. Signed-off-by: Jan Blunck --- lib/librte_eal/common/include/rte_vdev.h | 8 1 file changed, 8 insertions(+)

[dpdk-dev] [PATCH v4 10/10] eal: make virtual driver probe and remove take rte_vdev_device

This is a preparation to embed the generic rte_device into the rte_eth_dev also for virtual devices. Signed-off-by: Jan Blunck --- drivers/crypto/null/null_crypto_pmd.c | 18 -- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- drivers/net/bonding/rte_eth_bond_pmd.c

[dpdk-dev] [PATCH v4 09/10] eal: make virtual bus use rte_vdev_device

This allows the virtual bus to be rescanned and probed by tracking the creation of rte_vdev_device. Signed-off-by: Jan Blunck Tested-by: Ferruh Yigit Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_vdev.c | 195 +--- 1 file changed, 155 insertions(+),

Re: [dpdk-dev] [PATCH 0/6] get status of Rx and Tx descriptors

2017-03-04 21:45, Olivier Matz: > "Venkatesan, Venky" wrote: > > From: Olivier Matz > > > On Fri, 3 Mar 2017 16:18:52 +, "Venkatesan, Venky" wrote: > > > > From: Olivier Matz > > > > > On Thu, 2 Mar 2017 15:32:15 +, Bruce Richardson wrote: > > > > > > On Wed, Mar 01, 2017 at 06:19:06PM

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: add hardware TSO support

Monday, March 6, 2017 11:31 AM, Ferruh Yigit: > On 3/6/2017 8:50 AM, Ferruh Yigit wrote: > > On 3/2/2017 9:01 AM, Shahaf Shuler wrote: > >> Implement support for hardware TSO. > >> > >> Signed-off-by: Shahaf Shuler > >> --- > >> on v3: > >> * fix alignment issues > >> * for warn log > >> on v2:

[dpdk-dev] [PATCH] doc: announce TSO support on mlx5 driver

Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_17_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index 05fe784..8c381a8 100644 --- a/doc/guides/rel_notes/release_17_05.rst +++ b/doc/gui

[dpdk-dev] [PATCH 1/2] net/sfc/base: separate limitations on Tx DMA descriptors

Siena has limitation on maximum byte count and 4k boundary crosssing (which is stricter than maximum byte count). EF10 has limitation on maximum byte count only. Fixes: f7dc06bf35f2 ("net/sfc/base: import 5xxx/6xxx family support") Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support"

[dpdk-dev] [PATCH 2/2] net/sfc: remove Tx DMA descriptor boundary crossing limit

EF10 supported by the PMD has no limitations on address boundary crossing by Tx DMA descriptors. Fixes: 428c7ddd2f16 ("net/sfc: send bursts of packets") Fixes: fec33d5bb3eb ("net/sfc: support firmware-assisted TSO") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_tso.c | 11 ---

Re: [dpdk-dev] [PATCH] eventdev: Fix links_map initialization

On Wed, Mar 01, 2017 at 10:47:36PM -0600, Gage Eads wrote: > This patch initializes the links_map array entries to > EVENT_QUEUE_SERVICE_PRIORITY_INVALID, as expected by > rte_event_port_links_get(). > > Signed-off-by: Gage Eads > --- > lib/librte_eventdev/rte_eventdev.c | 17 - >

Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

On Fri, Feb 10, 2017 at 09:56:50PM +0530, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > Acked-by: Harry van Haaren Applied to dpdk-next-eventdev/master. Thanks. > --- > Changes for v2: > - Fix errors reported by check-git-log.sh > Changes for v3: > - Corrected comment's language > > lib

Re: [dpdk-dev] [PATCH v2] app/crypto-perf: fix for segfault when bad optype is used with gcm alghorithms

Hi Daniel, > -Original Message- > From: Mrzyglod, DanielX T > Sent: Thursday, February 16, 2017 11:27 AM > To: Mrozowicz, SlawomirX; Doherty, Declan; De Lara Guarch, Pablo > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH v2] app/crypto-perf: fix for segfault when bad optype is > u

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > Sent: Sunday, March 5, 2017 7:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; Ravi Kerur > Subject: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd > > This patchset merges l3

Re: [dpdk-dev] [v4 3/3] EM config file read option.

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > Sent: Sunday, March 5, 2017 7:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; Ravi Kerur > Subject: [dpdk-dev] [v4 3/3] EM config file read option. > > v4: > > No ch

Re: [dpdk-dev] [PATCH] eventdev: remove default queue overriding

On Wed, Mar 01, 2017 at 12:49:02PM +, Harry van Haaren wrote: > PMDs that only do a specific type of scheduling cannot provide > CFG_ALL_TYPES, so the Eventdev infrastructure should not demand > that every PMD supports CFG_ALL_TYPES. Sure. Then I think then we can enumerate CFG_ALL_TYPES as ca

[dpdk-dev] [PATCH v2] net/tap: fix dev name look-up

Store the device name in dev->data->name, to have symmetrical behavior between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). The netdevice name (linux interface name) is stored in the name field of struct pmd_internals. There's no need to allocate an rte_eth_dev_data, as it is done in rte

Re: [dpdk-dev] [PATCH 00/12] introduce fail-safe PMD

On Fri, Mar 03, 2017 at 04:14:20PM +, Bruce Richardson wrote: On Fri, Mar 03, 2017 at 04:40:22PM +0100, Gaetan Rivet wrote: This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing application

Re: [dpdk-dev] [v4 2/3] LPM config file read option.

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > Sent: Sunday, March 5, 2017 7:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; Ravi Kerur > Subject: [dpdk-dev] [v4 2/3] LPM config file read option. > > ... > + > +#define

Re: [dpdk-dev] [PATCH 2/6] net/tap: add speed capabilities

On Fri, 3 Mar 2017 15:27:12 + "Wiles, Keith" wrote: > > > On Mar 3, 2017, at 3:46 AM, Pascal Mazon > > wrote: > > > > Tap PMD is flexible, it supports any speed. > > > > Signed-off-by: Pascal Mazon > > --- > > doc/guides/nics/features/tap.ini | 1 + > > drivers/net/tap/rte_eth_tap.c|

[dpdk-dev] [PATCH] Fix doc: dpdk_nic_bind.py renamed to dpdk-devbind.py

From: Julien Castets --- doc/guides/linux_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst index eadade276..9d245737d 100644 --- a/doc/guides/linux_gsg/build_dpdk.rst +++ b/doc/guides

Re: [dpdk-dev] [PATCH 4/6] net/tap: add MTU management

On Fri, 3 Mar 2017 15:23:28 + "Wiles, Keith" wrote: > > > On Mar 3, 2017, at 3:46 AM, Pascal Mazon > > wrote: > > > > The MTU is assigned to the tap netdevice according to the argument, > > but packet transmission and reception just write/read on an fd with > > the default limit being the

Re: [dpdk-dev] [PATCH 1/6] net/sfc: add VFs to the table of PCI IDs for supported NICs

On 03/06/2017 01:10 PM, Ferruh Yigit wrote: On 3/2/2017 3:46 PM, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- drivers/net/sfc/sfc_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix uninitialized values for null operations

> -Original Message- > From: Kulasek, TomaszX > Sent: Friday, February 24, 2017 3:26 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] app/crypto-perf: fix uninitialized values for null operations > > Some values are uninitialized for "cipher null" and "auth null" > op

Re: [dpdk-dev] [PATCH 5/6] net/tap: add packet type management

On Fri, 3 Mar 2017 15:31:14 + "Wiles, Keith" wrote: > > > On Mar 3, 2017, at 3:46 AM, Pascal Mazon > > wrote: > > > > Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet > > type. > > > > Signed-off-by: Pascal Mazon > > --- > > doc/guides/nics/features/tap.ini | 1 + > > dri

Re: [dpdk-dev] [v4 2/3] LPM config file read option.

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Monday, March 6, 2017 1:57 PM > To: Ravi Kerur ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [v4 2/3] LPM config file read option. > > > > > --

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

On 03/06/2017 09:46 AM, Yuanhan Liu wrote: On Wed, Mar 01, 2017 at 08:36:24AM +0100, Maxime Coquelin wrote: On 02/23/2017 06:49 AM, Yuanhan Liu wrote: On Wed, Feb 22, 2017 at 10:36:36AM +0100, Maxime Coquelin wrote: On 02/22/2017 02:37 AM, Yuanhan Liu wrote: On Tue, Feb 21, 2017 at 06:3

Re: [dpdk-dev] [PATCH] net/tap: fix dev name look-up

> On Mar 5, 2017, at 3:35 PM, Yigit, Ferruh wrote: > > On 3/3/2017 8:54 AM, Pascal Mazon wrote: >> The call to rte_eth_dev_allocate(tap_name) sets dev->data->name to >> tap_name (e.g. "dtap0"). >> >> A look-up using tap_name is expected to return this device, not a >> look-up using name (e.g. "

Re: [dpdk-dev] [PATCH 1/4] net/tap: move private elements to external header

On Fri, 3 Mar 2017 15:38:11 + "Wiles, Keith" wrote: > > > On Mar 3, 2017, at 4:45 AM, Pascal Mazon > > wrote: > > > > In the next patch, access to struct pmd_internals will be necessary > > in tap_flow.c to store the flows. > > > > Signed-off-by: Pascal Mazon > > Acked-by: Olga Shern >

Re: [dpdk-dev] [PATCH 06/12] net/failsafe: add fail-safe PMD

On Fri, Mar 03, 2017 at 09:38:11AM -0800, Stephen Hemminger wrote: On Fri, 3 Mar 2017 16:40:28 +0100 Gaetan Rivet wrote: + +static struct rte_eth_dev * +pci_addr_to_eth_dev(struct rte_pci_addr *addr) +{ + uint8_t pid; + + if (addr == NULL) + return NULL; + for

  1   2   3   >