Hi, 2017-03-03 13:54, Kuba Kozak: > From: Jacek Piasecki <jacekx.piase...@intel.com> > > This patch extends library for retriving xstats by specified groups and > single xstat by given name. > > Signed-off-by: Jacek Piasecki <jacekx.piase...@intel.com> > Signed-off-by: Kuba Kozak <kubax.ko...@intel.com>
As you probably know, it is difficult to have a good review (or a simple review at all). The most difficult part in such a change is not writing the code, it is explaining your idea and getting people to agree. Please show you have thought about the API, seen an issue or a lack, and propose an idea with a clear target. In short, we are missing a "why" and "how". You must also explain what is a group, better than a list of #define.
