Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-22 Thread Shreyansh Jain
On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: On Wed, 21 Dec 2016 16:09:44 +0100 Jan Blunck wrote: Only the device itself can decide its PCI or not. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- I would still like to kill dev_pci from the dev_info API. +1. It

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-22 Thread Chen, Jing D
Hi, Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Tuesday, December 20, 2016 11:19 PM > To: Chen, Jing D ; Thomas Monjalon > > Cc: dev@dpdk.org; Yigit, Ferruh ; Wu, Jingjing > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v5 00/29] Suppo

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: enablement of avx512 support in IPsec_mb library

2016-12-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, December 21, 2016 10:05 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: enablement of avx512 > support in IPsec_mb library > > Relea

Re: [dpdk-dev] [PATCH 0/3] net/virtio: a temp to fix few multiple process issues

2016-12-22 Thread Xu, Qian Q
Yaron Could you also share your test case step by step here? I want to learn from u on the cases. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yuanhan Liu > Sent: Thursday, December 22, 2016 3:19 PM > To: dev@dpdk.org > Cc: Yaron Illouz ; Yuanhan Liu > > S

Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter

2016-12-22 Thread Zhao1, Wei
Hi, Yigit > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 21, 2016 1:01 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter > > On 12/2/2016 10:43 AM, Wei Zhao wrote: > > From: wei zhao1

Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter

2016-12-22 Thread Zhao1, Wei
Hi, Yigit > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 21, 2016 12:56 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter > > On 12/2/2016 10:42 AM, Wei Zhao wrote: > > From: wei zhao1 > > > >

[dpdk-dev] [PATCH v2 1/2] crypto/qat: add SGL capability to Intel QuickAssist driver

2016-12-22 Thread Arek Kusztal
This commit adds scatter-gather list capability to Intel QuickAssist Technology driver. Signed-off-by: Arek Kusztal --- doc/guides/rel_notes/release_17_02.rst | 2 + drivers/crypto/qat/qat_adf/qat_algs.h | 14 +++- drivers/crypto/qat/qat_crypto.c| 130 +++-

[dpdk-dev] [PATCH v2 2/2] app/test: add SGL tests to cryptodev QAT suite

2016-12-22 Thread Arek Kusztal
This commit adds GCM tests to use within scatter-gather list. Test use direct chained mbufs created based on the input parameter for max size for in place operations and out of place operations. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev.c | 356 + app/t

[dpdk-dev] [PATCH v2 0/2] Add scatter-gather list capability to Intel(R) QuickAssist Technology driver

2016-12-22 Thread Arek Kusztal
This patchset adds scatter-gather list (SGL) capability to Intel(R) QuickAssist Technology driver and corresponding tests to QAT cryptodev test suite. v2: - removed _priv member from rte_crypto_op - added cookie pool to qat_qp for sgl array entries Arek Kusztal (2): crypto/qat: add SGL capab

Re: [dpdk-dev] [PATCH 1/2] eth: get rid of goto's in rte_eth_dev_detach

2016-12-22 Thread Thomas Monjalon
2016-12-08 10:25, Ferruh Yigit: > On 12/8/2016 1:47 AM, Stephen Hemminger wrote: > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -466,27 +466,20 @@ rte_eth_dev_attach(const char *devargs, uint8_t > > *port_id) > > int > > rte_eth_dev_detach(uint8_t port_id,

Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 9:19 AM, Zhao1, Wei wrote: > Hi, Yigit > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, December 21, 2016 1:01 AM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Lu, Wenzhuo >> Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter >> >> On 12/

Re: [dpdk-dev] [PATCH v6 23/25] app/testpmd: handle i40e in VF VLAN filter command

2016-12-22 Thread Ferruh Yigit
On 12/21/2016 6:34 AM, Wenzhuo Lu wrote: > modify set_vf_rx_vlan function to handle the i40e PMD. > > Signed-off-by: Bernard Iremonger > --- <...> > + > + switch (ret) { > + case 0: > + break; > + case -EINVAL: > + printf("invalid vlan_id %d or vf_mask %lu\n"

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Ferruh Yigit
On 12/21/2016 11:40 AM, Andrew Rybchenko wrote: > On 12/21/2016 02:37 PM, Neil Horman wrote: >> On Wed, Dec 21, 2016 at 12:21:14PM +0300, Andrew Rybchenko wrote: >>> On 12/20/2016 08:26 PM, Thomas Monjalon wrote: >> Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to >> decl

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-22 Thread Thomas Monjalon
2016-12-08 16:34, Remy Horton: > > On 06/12/2016 15:16, Qiming Yang wrote: > [..] > > Qiming Yang (5): > > ethdev: add firmware version get > > net/e1000: add firmware version get > > net/ixgbe: add firmware version get > > net/i40e: add firmware version get > > ethtool: dispaly bus info

Re: [dpdk-dev] Why IP_PIPELINE is faster than L2FWD

2016-12-22 Thread Bruce Richardson
On Thu, Dec 22, 2016 at 12:18:12AM +0800, Royce Niu wrote: > Hi all, > > I tested default L2FWD and IP_PIPELINE (pass-through). The throughput of > IP_PIPELINE is higher immensely. > > There are only two virtual NICs in KVM. The experiment is just moving > packet from vNIC0 to vNIC1. I think the

Re: [dpdk-dev] [PATCH] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-08 13:59, Ferruh Yigit: > - Grouped related items using empty lines I have few comments below. [...] > + > eth_dev_infos_get_tdev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > - /**< Get packet types supported and

[dpdk-dev] [PATCH] net/sfc: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Andrew Rybchenko
Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index dd5ca5c..725c971 100644 --- a/drivers/net

[dpdk-dev] [PATCH v2 0/5] distributor library performance enhancements

2016-12-22 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It adds a series of API calls similar to the original API, but with "_burst" in the function names. Usage is similar (but not identical), in that there are now bursts of mbufs sent to each worker at a time instead of a single mb

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Andrew Rybchenko
On 12/22/2016 02:04 PM, Ferruh Yigit wrote: On 12/21/2016 11:40 AM, Andrew Rybchenko wrote: On 12/21/2016 02:37 PM, Neil Horman wrote: On Wed, Dec 21, 2016 at 12:21:14PM +0300, Andrew Rybchenko wrote: On 12/20/2016 08:26 PM, Thomas Monjalon wrote: Add a new macro RTE_PMD_REGISTER_KMOD_DEP() t

[dpdk-dev] [PATCH v2 2/5] test: unit tests for new distributor burst api

2016-12-22 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor.c | 500 ++-- 1 file changed, 391 insertions(+), 109 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 85cb8f3..7738f04 100644 --- a/app/test/test_distributor.c

[dpdk-dev] [PATCH v2 1/5] lib: distributor performance enhancements

2016-12-22 Thread David Hunt
Now sends bursts of up to 8 mbufs to each worker, and tracks the in-flight flow-ids (atomic scheduling) New file with a new api, similar to the old API except with _burst at the end of the function names Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 2 + lib/l

[dpdk-dev] [PATCH v2 3/5] test: add distributor_perf autotest

2016-12-22 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor_perf.c | 133 +-- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 7947fe9..86285fd 100644 --- a/app/test/test_distr

[dpdk-dev] [PATCH v2 4/5] example: distributor app showing burst api

2016-12-22 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 505 ++-- 1 file changed, 388 insertions(+), 117 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e7641d2..451e253 100644 --- a/examples/distributor/main.c

[dpdk-dev] [PATCH v2 5/5] doc: distributor library changes for new burst api

2016-12-22 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/packet_distrib_lib.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..dffd4ad 100644 --- a/doc/guides/prog_guide/packet_distrib_

[dpdk-dev] [PATCH v2] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Ferruh Yigit
- Grouped related items using empty lines - Aligned arguments to same column - All item comments that doesn't fit same line are placed blow the item itself - Moved some comments to same line if overall line < 100 chars Signed-off-by: Ferruh Yigit --- - ! This patch has the problem of trashing

[dpdk-dev] [PATCH] ethdev: remove invalid function from version map file

2016-12-22 Thread Ferruh Yigit
Fixes: 9d41beed24b0 ("lib: provide initial versioning") Signed-off-by: Ferruh Yigit --- lib/librte_ether/rte_ether_version.map | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 209328c..b7ee80c 100644 --- a/l

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 11:35 AM, Andrew Rybchenko wrote: > On 12/22/2016 02:04 PM, Ferruh Yigit wrote: >> On 12/21/2016 11:40 AM, Andrew Rybchenko wrote: >>> On 12/21/2016 02:37 PM, Neil Horman wrote: On Wed, Dec 21, 2016 at 12:21:14PM +0300, Andrew Rybchenko wrote: > On 12/20/2016 08:26 PM, Thomas

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Andrew Rybchenko
On 12/22/2016 03:07 PM, Ferruh Yigit wrote: On 12/22/2016 11:35 AM, Andrew Rybchenko wrote: On 12/22/2016 02:04 PM, Ferruh Yigit wrote: On 12/21/2016 11:40 AM, Andrew Rybchenko wrote: On 12/21/2016 02:37 PM, Neil Horman wrote: On Wed, Dec 21, 2016 at 12:21:14PM +0300, Andrew Rybchenko wrote:

Re: [dpdk-dev] [PATCH] net/sfc: advertise kmod dependencies in pmdinfo

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 11:32 AM, Andrew Rybchenko wrote: > Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 3/5] test: add distributor_perf autotest

2016-12-22 Thread Jerin Jacob
On Thu, Dec 22, 2016 at 04:37:06AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- > + * it does nothing but return packets and count them. > + */ > +static int > +handle_work_burst(void *arg) > +{ > + //struct rte_mbuf *pkt = NULL; Seems like their is lot test code with // in this

Re: [dpdk-dev] [PATCH 23/28] net/ixgbe: use eal I/O device memory read/write API

2016-12-22 Thread Santosh Shukla
Hi Jiangbo, On Thu, Dec 15, 2016 at 08:40:19PM -0800, Santosh Shukla wrote: > On Thu, Dec 15, 2016 at 04:37:12PM +0800, Jianbo Liu wrote: > > On 14 December 2016 at 09:55, Jerin Jacob > > wrote: > > > From: Santosh Shukla > > > > > > > memory barrier operation is put inside IXGBE_PCI_REG_READ/W

Re: [dpdk-dev] [PATCH v2] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-22 11:53, Ferruh Yigit: > To make it easy to comment to latest struct, copy-paste here: > [With some extra notes] > > struct eth_dev_ops { > eth_dev_configure_tdev_configure; /**< Configure device. */ > eth_dev_start_tdev_start; /**< Start device. */ >

Re: [dpdk-dev] [PATCH v2 1/5] lib: distributor performance enhancements

2016-12-22 Thread Jerin Jacob
On Thu, Dec 22, 2016 at 04:37:04AM +, David Hunt wrote: > Now sends bursts of up to 8 mbufs to each worker, and tracks > the in-flight flow-ids (atomic scheduling) > > New file with a new api, similar to the old API except with _burst > at the end of the function names > > Signed-off-by: Davi

Re: [dpdk-dev] [PATCH v2 00/25] Generic flow API (rte_flow)

2016-12-22 Thread Adrien Mazarguil
On Wed, Dec 21, 2016 at 05:19:16PM +0100, Simon Horman wrote: > On Fri, Dec 16, 2016 at 05:24:57PM +0100, Adrien Mazarguil wrote: > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > > described in [3] (also pasted below), here is the first non-draft series > > for this new API. >

Re: [dpdk-dev] Why IP_PIPELINE is faster than L2FWD

2016-12-22 Thread Royce Niu
But, actually, L3FWD of IP_PIPELINE is also faster than stock L2FWD, which also modifies mac addr. How can explain this? Actually, I want to know why IP_PIPELINE is much faster and I can learn from IP_PIPELINE and make our own program. But, the documentation of that is not detailed enough. if it

[dpdk-dev] [PATCH v14 0/8] add Tx preparation

2016-12-22 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO

[dpdk-dev] [PATCH v14 1/8] ethdev: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prepare` uint16_t rte_eth_tx_prepare(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */

[dpdk-dev] [PATCH v14 2/8] e1000: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/e1000/e1000_ethdev.h | 11 drivers/net/e1000/em_ethdev.c|5 +++- drivers/net/e1000/em_rxtx.c | 48 +- drivers/net/e1000/igb_ethdev.c |4 +++ drivers/net/e100

[dpdk-dev] [PATCH v14 4/8] i40e: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c |3 ++ drivers/net/i40e/i40e_rxtx.c | 74 +++- drivers/net/i40e/i40e_rxtx.h |8 + 3 files changed, 84 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH v14 3/8] fm10k: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k.h|6 + drivers/net/fm10k/fm10k_ethdev.c |5 drivers/net/fm10k/fm10k_rxtx.c | 50 +- 3 files changed, 60 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v14 6/8] vmxnet3: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
From: "Ananyev, Konstantin" Signed-off-by: Konstantin Ananyev --- drivers/net/vmxnet3/vmxnet3_ethdev.c |6 drivers/net/vmxnet3/vmxnet3_ethdev.h |2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 56 ++ 3 files changed, 64 insertions(+) diff --git a/dri

[dpdk-dev] [PATCH v14 5/8] ixgbe: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ drivers/net/ixgbe/ixgbe_ethdev.h |5 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 57 ++ drivers/net/ixgbe/ixgbe_rxtx.h |2 ++ 4 files changed, 66

[dpdk-dev] [PATCH v14 8/8] testpmd: use Tx preparation in csum engine

2016-12-22 Thread Tomasz Kulasek
Since all current drivers supports Tx preparation API, it is used in csum forwarding engine by default for all drivers. Adding additional step to the csum engine costs about 3-4% of performance drop, on my setup with ixgbe driver. It's caused mostly by the need of reaccessing and modification of p

[dpdk-dev] Example(Load_balancer) Tx Flush Bug(This bug dpdk each version)

2016-12-22 Thread Maple
From: Maple To: Cc: Subject: [PATCH] Load_balancer Tx Flush Bug Date: Thu, 22 Dec 2016 09:57:48 +0800 Message-Id: <1482371868-19669-1-git-send-email-liuj...@raisecom.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <2016122122394164225...@raisecom.com> References: <2016122122394164225...@raiseco

[dpdk-dev] [PATCH v14 7/8] ena: add Tx preparation

2016-12-22 Thread Tomasz Kulasek
From: Konstantin Ananyev Signed-off-by: Konstantin Ananyev --- drivers/net/ena/ena_ethdev.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 555fb31..51af723 100644 --- a/drivers/n

[dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Ferruh Yigit
- Grouped related items using empty lines - Aligned arguments to same column - All item comments that doesn't fit same line are placed blow the item itself - Moved some comments to same line if overall line < 100 chars Signed-off-by: Ferruh Yigit --- - ! This patch has the problem of trashing

Re: [dpdk-dev] [PATCH v13 6/7] vmxnet3: add Tx preparation

2016-12-22 Thread Thomas Monjalon
2016-12-20 13:36, Ferruh Yigit: > On 12/13/2016 5:41 PM, Tomasz Kulasek wrote: > > From: "Ananyev, Konstantin" > > > > Signed-off-by: Konstantin Ananyev > > --- > > <...> > > > > > uint16_t > > +vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, > > + uint16_t nb_pk

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Thomas Monjalon
2016-12-02 00:10, Ananyev, Konstantin: > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and > associated logic. > I personally don't use ARM boxes and don't plan to, > and in theory users can still do conditional compilation at the upper layer, > if they want to. Yes you're ri

Re: [dpdk-dev] Why IP_PIPELINE is faster than L2FWD

2016-12-22 Thread Bruce Richardson
On Thu, Dec 22, 2016 at 08:48:50PM +0800, Royce Niu wrote: > But, actually, L3FWD of IP_PIPELINE is also faster than stock L2FWD, which > also modifies mac addr. How can explain this? > > Actually, I want to know why IP_PIPELINE is much faster and I can learn > from IP_PIPELINE and make our own pr

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Thomas Monjalon
2016-12-12 11:51, Ananyev, Konstantin: > > > The application gets few information from tx_prepare() about what should > > > be done to make the packet accepted by the hw, and the actions will > > > probably be different depending on hardware. > > That's true. > I am open to suggestions how in futu

Re: [dpdk-dev] Why IP_PIPELINE is faster than L2FWD

2016-12-22 Thread Royce Niu
Dear Bruce, Thanks for your kind explanation. I will try to follow your suggestion and see the source code. On Thu, Dec 22, 2016 at 9:25 PM, Bruce Richardson < bruce.richard...@intel.com> wrote: > On Thu, Dec 22, 2016 at 08:48:50PM +0800, Royce Niu wrote: > > But, actually, L3FWD of IP_PIPELINE

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Jerin Jacob
On Thu, Dec 22, 2016 at 02:14:45PM +0100, Thomas Monjalon wrote: > 2016-12-02 00:10, Ananyev, Konstantin: > > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and > > associated logic. > > I personally don't use ARM boxes and don't plan to, > > and in theory users can still do cond

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-22 Thread Vincent JARDIN
Le 22/12/2016 à 09:10, Chen, Jing D a écrit : In the meanwhile, we have some test models ongoing to validate combination of Linux and DPDK drivers for VF and PF. We'll fully support below 4 cases going forward. 1. DPDK PF + DPDK VF 2. DPDK PF + Linux VF + DPDK PF + FreeBSD VF + DPDK PF + Windo

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Ananyev, Konstantin
> > 2016-12-12 11:51, Ananyev, Konstantin: > > > > The application gets few information from tx_prepare() about what should > > > > be done to make the packet accepted by the hw, and the actions will > > > > probably be different depending on hardware. > > > > That's true. > > I am open to suggest

Re: [dpdk-dev] [PATCH v14 1/8] ethdev: add Tx preparation

2016-12-22 Thread Thomas Monjalon
Hi Tomasz, 2016-12-22 14:05, Tomasz Kulasek: > Added API for `rte_eth_tx_prepare` > > uint16_t rte_eth_tx_prepare(uint8_t port_id, uint16_t queue_id, > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) As discussed earlier and agreed by Konstantin, please mark this API as experimental. We could

Re: [dpdk-dev] [PATCH v14 8/8] testpmd: use Tx preparation in csum engine

2016-12-22 Thread Thomas Monjalon
2016-12-22 14:05, Tomasz Kulasek: > Since all current drivers supports Tx preparation API, it is used > in csum forwarding engine by default for all drivers. [...] > +/* > + * Enable Tx preparation path in the "csum" engine. > + */ > +uint8_t tx_prepare; It seems this variable is not used.

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 11:07 AM, Thomas Monjalon wrote: > 2016-12-08 16:34, Remy Horton: >> >> On 06/12/2016 15:16, Qiming Yang wrote: >> [..] >>> Qiming Yang (5): >>> ethdev: add firmware version get >>> net/e1000: add firmware version get >>> net/ixgbe: add firmware version get >>> net/i40e: add f

Re: [dpdk-dev] [PATCH v6 23/25] app/testpmd: handle i40e in VF VLAN filter command

2016-12-22 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 22, 2016 10:57 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v6 23/25] app/testpmd: handle i40e in VF > VLAN filter command > > On 12/21/2016 6:34 AM, Wenzhuo

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-22 Thread Thomas Monjalon
2016-12-22 14:36, Ferruh Yigit: > On 12/22/2016 11:07 AM, Thomas Monjalon wrote: > > I think it is OK to add a new dev_ops and a new API function for firmware > > query. Generally speaking, it is a good thing to avoid putting all > > informations in the same structure (e.g. rte_eth_dev_info). > >

Re: [dpdk-dev] [PATCH] ethdev: remove invalid function from version map file

2016-12-22 Thread Thomas Monjalon
2016-12-22 12:00, Ferruh Yigit: > Fixes: 9d41beed24b0 ("lib: provide initial versioning") > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice

2016-12-22 Thread Akhil Goyal
This patch will not be required as some parallel work is going on to add it across all crypto devices. Signed-off-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptode

[dpdk-dev] [PATCH v2 00/11] Introducing NXP DPAA2 SEC based cryptodev PMD

2016-12-22 Thread Akhil Goyal
Based over the DPAA2 PMD driver [1], this series of patches introduces the DPAA2_SEC PMD which provides DPDK crypto driver for NXP's DPAA2 CAAM Hardware accelerator. SEC is NXP DPAA2 SoC's security engine for cryptographic acceleration and offloading. It implements block encryption, stream cipher,

[dpdk-dev] [PATCH v2 04/11] doc: Adding NXP DPAA2_SEC in cryptodev

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 233 doc/guides/cryptodevs/index.rst | 1 + 2 files changed, 234 insertions(+) create mode 100644 doc/guides/cryptodevs/dpaa2_sec.rst diff --git a/doc/gui

[dpdk-dev] [PATCH v2 05/11] lib: Add cryptodev type for DPAA2_SEC

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index bb5f41c..bacf893 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptod

[dpdk-dev] [PATCH v2 06/11] crypto: Add DPAA2_SEC PMD for NXP DPAA2 platform

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c |3 +- drivers/bus/fslmc/rte_fslmc.h |5 +- drivers/common/dpaa2/dpio/dpaa2_hw_pvt.h| 25 + drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1592

[dpdk-dev] [PATCH v2 08/11] crypto/dpaa2_sec: Enable DPAA2_SEC PMD in the configuration

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 12 1 file changed, 12 insertions(+) diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index 18c9589..30fd4e3 100644 --- a/config

[dpdk-dev] [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- drivers/crypto/Makefile| 1 + drivers/crypto/dpaa2_sec/Makefile | 74 ++ .../crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 4 ++ mk/rte.app.mk

[dpdk-dev] [PATCH v2 09/11] crypto/dpaa2_sec: statistics support

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 76 + 1 file changed, 76 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 6c9895f..f4a4

[dpdk-dev] [PATCH v2 10/11] app/test: add dpaa2_sec crypto test

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- app/test/test_cryptodev_perf.c | 12 1 file changed, 12 insertions(+) diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c index 59a6891..2d9b78e 100644 --- a/app/test/test_cryptodev_perf.c +++ b/app

[dpdk-dev] [PATCH v2 11/11] crypto/dpaa2_sec: Update MAINTAINERS entry for dpaa2_sec PMD

2016-12-22 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2f072b5..2ced843 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -457,6 +457,12 @@ M: Declan Doherty F: drivers/crypto/null/ F: doc/gu

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-22 13:10, Ferruh Yigit: > - Grouped related items using empty lines > - Aligned arguments to same column > - All item comments that doesn't fit same line are placed blow the item > itself > - Moved some comments to same line if overall line < 100 chars > > Signed-off-by: Ferruh Yigit A

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 2:47 PM, Thomas Monjalon wrote: > 2016-12-22 14:36, Ferruh Yigit: >> On 12/22/2016 11:07 AM, Thomas Monjalon wrote: >>> I think it is OK to add a new dev_ops and a new API function for firmware >>> query. Generally speaking, it is a good thing to avoid putting all >>> informations in

Re: [dpdk-dev] [PATCH v4 22/23] ethdev: Decouple interrupt handling from PCI device

2016-12-22 Thread Thomas Monjalon
2016-12-21 16:09, Jan Blunck: > The struct rte_intr_handle is an abstraction layer for different types of > interrupt mechanisms. It is embedded in the low-level device (e.g. PCI). > On allocation of a struct rte_eth_dev a reference to the intr_handle > should be stored for devices supporting inter

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Ferruh Yigit
On 12/22/2016 3:10 PM, Jan Blunck wrote: > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit wrote: >> - Grouped related items using empty lines > > Reordering fields of a struct is breaking ABI. We should bump the > library version now. You are right, sorry missed that. Intention was not to break t

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Jan Blunck
On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit wrote: > - Grouped related items using empty lines Reordering fields of a struct is breaking ABI. We should bump the library version now. > - Aligned arguments to same column > - All item comments that doesn't fit same line are placed blow the item

Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

2016-12-22 Thread Thomas Monjalon
2016-12-21 16:09, Jan Blunck: > PCI drivers could use this helper instead of directly accessing fields of > rte_eth_dev to map to rte_pci_device. [...] > +/** > + * @internal > + * Helper for drivers that need to convert from rte_eth_dev to > rte_pci_device. > + */ > +static inline struct rte_pci_

Re: [dpdk-dev] [PATCH v4 23/23] ethdev: Decouple struct rte_eth_dev from struct rte_pci_device

2016-12-22 Thread Thomas Monjalon
2016-12-21 16:09, Jan Blunck: > +/** > + * @internal > + * Helper macro for drivers that need to convert to struct rte_pci_device. > + */ > +#define DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device) Please use RTE_ prefix. RTE_PCI_DEV?

Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace

2016-12-22 Thread Thomas Monjalon
2016-12-22 15:16, Ferruh Yigit: > On 12/22/2016 3:10 PM, Jan Blunck wrote: > > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit > > wrote: > >> - Grouped related items using empty lines > > > > Reordering fields of a struct is breaking ABI. We should bump the > > library version now. > > You are r

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-22 Thread Thomas Monjalon
2016-12-22 15:05, Ferruh Yigit: > On 12/22/2016 2:47 PM, Thomas Monjalon wrote: > > 2016-12-22 14:36, Ferruh Yigit: > >> On 12/22/2016 11:07 AM, Thomas Monjalon wrote: > >>> I think it is OK to add a new dev_ops and a new API function for firmware > >>> query. Generally speaking, it is a good thing

Re: [dpdk-dev] [PATCH v4 00/23] Decouple ethdev from PCI device

2016-12-22 Thread Thomas Monjalon
2016-12-21 16:09, Jan Blunck: > This is a partial merge of Stephens and my patches to make the rte_eth_dev > independent of the rte_pci_device. Thanks for the hard work. > Jan Blunck (17): > eal: define container_of macro > eal: Allow passing const rte_intr_handle > virtio: Don't fill dev_i

Re: [dpdk-dev] [PATCH 12/13] i40e: return -errno when intr setup fails

2016-12-22 Thread Ferruh Yigit
On 12/13/2016 1:08 AM, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > --- > drivers/net/i40e/i40e_ethdev.c | 5 +++-- > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c

Re: [dpdk-dev] [PATCH v2 1/2] crypto/qat: add SGL capability to Intel QuickAssist driver

2016-12-22 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, December 22, 2016 10:15 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 1/2] crypto/qat: add SGL capability to Intel Quick

Re: [dpdk-dev] [PATCH v2 1/5] lib: distributor performance enhancements

2016-12-22 Thread Hunt, David
Thanks for the review, Jerin, I very much appreciate it. I'll address all the minor comments, and I've a comment or two on the remaining changes below. On 22/12/2016 12:47 PM, Jerin Jacob wrote: On Thu, Dec 22, 2016 at 04:37:04AM +, David Hunt wrote: --snip-- + + /* set the

Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF

2016-12-22 Thread Iremonger, Bernard
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, December 21, 2016 12:56 AM > To: Iremonger, Bernard ; Yigit, Ferruh > ; dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Helin > ; Zhang, Qi Z ; Chen, Jing D > > Subject: RE: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from

[dpdk-dev] [PATCH] crypto test: add integrity check for mbuf data

2016-12-22 Thread Fiona Trahe
In block cipher test cases, add checks that the source and destination mbufs are not modified except where expected. Signed-off-by: Fiona Trahe --- app/test/test_cryptodev_blockcipher.c | 139 -- 1 file changed, 134 insertions(+), 5 deletions(-) diff --git a/app/

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong return value when handling PF message

2016-12-22 Thread Ferruh Yigit
On 12/21/2016 8:29 AM, Wenzhuo Lu wrote: > When VF receives a message from PF, it should check the return > value. But in i40evf_execute_vf_cmd the value is ignored and not > returned to the caller. > > Fixes: 95cd21f45d1b ("i40evf: allocate virtchnl commands buffer per VF") > > Signed-off-by: We

Re: [dpdk-dev] [PATCH v14 6/8] vmxnet3: add Tx preparation

2016-12-22 Thread Yong Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, December 22, 2016 5:05 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v14 6/8] vmxnet3: add Tx preparation > > From: "Ananyev, Konstantin" > > Signe

Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

2016-12-22 Thread Jan Blunck
On Thu, Dec 22, 2016 at 4:21 PM, Thomas Monjalon wrote: > 2016-12-21 16:09, Jan Blunck: >> PCI drivers could use this helper instead of directly accessing fields of >> rte_eth_dev to map to rte_pci_device. > [...] >> +/** >> + * @internal >> + * Helper for drivers that need to convert from rte_eth

Re: [dpdk-dev] [PATCH v4 22/23] ethdev: Decouple interrupt handling from PCI device

2016-12-22 Thread Jan Blunck
On Thu, Dec 22, 2016 at 4:13 PM, Thomas Monjalon wrote: > 2016-12-21 16:09, Jan Blunck: >> The struct rte_intr_handle is an abstraction layer for different types of >> interrupt mechanisms. It is embedded in the low-level device (e.g. PCI). >> On allocation of a struct rte_eth_dev a reference to t

[dpdk-dev] [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling

2016-12-22 Thread Harish Patil
- Enable/disable VXLAN tunneling - Add/remove VXLAN classification rules - Destination UDP port configuration Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_l2.c |3 + drivers/net/qede/base/ecore_l2_api.h |1 + drivers/net/qede/qede_ethdev.c | 400

[dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs

2016-12-22 Thread Harish Patil
Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. Signed-off-by: Harish Patil --- drivers/net/qede/qede_logs.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 45c4af0..13b76a7 100644 -

[dpdk-dev] [PATCH v2 2/7] net/qede: fix filtering code

2016-12-22 Thread Harish Patil
In qede_mac_addr_add() a check is added to differentiate between unicast/multicast mac to prevent a multicast mac from being wrongly added to unicast filter table. Secondly, two separate lists will be used to keep track of unicast/multicast mac filters to prevent duplicate filter programming. The o

[dpdk-dev] [PATCH v2 4/7] net/qede: add fastpath support for VXLAN tunneling

2016-12-22 Thread Harish Patil
- Support HW checksum and RSS offload for VXLAN traffic - Identify inner/outer packet_types using lookup table - Update documentation Signed-off-by: Harish Patil --- doc/guides/nics/features/qede.ini |3 + doc/guides/nics/qede.rst |3 +- drivers/net/qede/qede_eth_if.h|3

[dpdk-dev] [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled

2016-12-22 Thread Harish Patil
qede PMD does not support SR-IOV PF driver functionality, so max_vfs is set to 0 to imply the same. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 5/7] net/qede: fix RSS related issue

2016-12-22 Thread Harish Patil
This patch includes the following: - Fix missing hash_key_size advertisement - Fix RSS hash query function - Update RSS offload flag - Accept user provided RSS configuration params via rx_adv_conf in dev_configure() - Decouple RSS configuration from common qed_update_vport() and instead make u

[dpdk-dev] [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF

2016-12-22 Thread Harish Patil
HW can support upto 128 queues based on the NIC config/personality. But most of the testing is done with 32 queues for PF and 16 for VF device across different qede devices, so change here is to advertise only those many instead of returning max queues supported by HW. Fixes: 2ea6f76aff40 ("qede:

[dpdk-dev] [PATCH v2 1/8] net/qede: fix to get vendor/device id info

2016-12-22 Thread Rasesh Mody
The vendor_id and device_id are used to determine device type. If you don't have them, then check for determining device type fails and is always set to default device type. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c |4

[dpdk-dev] [PATCH v2 3/8] net/qede/base: fix multiple acquisition requests by VF

2016-12-22 Thread Rasesh Mody
There are certain conditions under which VF would infinitely send ACQUIRE messages, as it will fail to understand that PF has rejected the ACQUIRE request. Fix to reject multiple acquisition requests by VF. Fixes: 22d07d939c3c ("net/qede/base: update") Signed-off-by: Rasesh Mody --- drivers/net

[dpdk-dev] [PATCH v2 2/8] net/qede/base: fix sriov printouts

2016-12-22 Thread Rasesh Mody
Remove unmeaningful function ID value in print. Don't print the number of Multicast filters as part of Acquire response, as this is an obsolete field which isn't enforced by PF. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c |

[dpdk-dev] [PATCH v2 4/8] net/qede/base: fix error return code in resc alloc

2016-12-22 Thread Rasesh Mody
Fix to return error code ECORE_INVAL instead of 0 when EQ elements is too large as done elsewhere in this function. Fixes: 22d07d939c3c ("net/qede/base: update") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/q

  1   2   >