Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 9:05 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 05/32] net/i40e: set TX loopback from PF
>
> On 12/7/2016 3:31 AM, Wenzhuo Lu wrote:
> > Support enabling/disabling TX loo
In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and
IXGBE_VF_GET_QUEUES appears two times with the same name，value,
and notes.
Version 2.0 VF requests can inherit the two macro defines
in previous version 1.0 and 1.1. Otherwise, may be cause confusion.
Signed-off-by: Chenghu Yao
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 8:45 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 02/32] net/i40e: add callback to user on VF
> to
> PF mbox msg
>
> On 12/7/2016 3:31 AM, Wenzhuo Lu wrote:
> > The callba
Hi Adrien,
For SCTP, it may need support to set 'tag' since in FDIR
(--pkt-filter-mode=perfect) need set it when filter sctp flow.
struct sctp_hdr {
uint16_t src_port; /**< Source port. */
uint16_t dst_port; /**< Destin port. */
uint32_t tag; /**< Validation tag. *
Hi adrien,
Is it possible to support to set ipv4 TOS, ipv4 PROTO, ipv4 TTL and ipv6 tc,
ipv6 next-header, ipv6 hop-limits since
previous FDIR for i40e already support it.
Best Regards
Yulong Pei
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
Se
Hi, Konstantin:
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Friday, December 16, 2016 7:48 PM
> To: Yang, Zhiyong ; Thomas Monjalon
>
> Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce
> ; De Lara Guarch, Pablo
>
> Subject: RE: [dpdk-dev] [PATCH 1/4] eal/comm
On Tue, Dec 20, 2016 at 01:57:46AM +, Xing, Beilei wrote:
> > -Original Message-
> > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> > Sent: Monday, December 19, 2016 6:20 PM
> > To: Xing, Beilei
> > Cc: dev@dpdk.org; Pei, Yulong
> > Subject: Re: [dpdk-dev] [PATCH v2 06/2
> -Original Message-
> From: Baruch Siach [mailto:bar...@tkos.co.il]
> Sent: Monday, December 19, 2016 7:29 PM
> To: dev@dpdk.org
> Cc: Mcnamara, John ; Baruch Siach
>
> Subject: [PATCH v2] doc: fix required tools list layout
>
> The Python requirement should appear in the bullet list.
Hi Wei,
On Tue, Dec 20, 2016 at 07:32:29AM +, Zhao1, Wei wrote:
> Hi, Adrien
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> > Sent: Tuesday, December 20, 2016 1:49 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v3 10/25] a
Hi Yulong,
On Tue, Dec 20, 2016 at 09:14:55AM +, Pei, Yulong wrote:
> Hi Adrien,
>
> For SCTP, it may need support to set 'tag' since in FDIR
> (--pkt-filter-mode=perfect) need set it when filter sctp flow.
>
> struct sctp_hdr {
> uint16_t src_port; /**< Source port. */
>
Hi Yulong,
On Tue, Dec 20, 2016 at 09:21:28AM +, Pei, Yulong wrote:
> Hi adrien,
>
> Is it possible to support to set ipv4 TOS, ipv4 PROTO, ipv4 TTL and ipv6 tc,
> ipv6 next-header, ipv6 hop-limits since
> previous FDIR for i40e already support it.
I suggest we add them later (like for SCT
> > >> Signed-off-by: Maxime Coquelin
> > >
> > > There is one trailing whitespace warning but apart from that:
> > >
> > > Acked-by: John McNamara
> >
> > Thanks John,
> >
> > Do you want me to send a v3, fixing the trailing whitespace & collecting
> > the acks?
>
> No need (unless the tree m
This patch implements NFP PMD support for TSO but it also requires
a firmware advertising the capability.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/features/nfp.ini | 1 +
drivers/net/nfp/nfp_net.c| 40
2 files changed, 33 insertions(+)
2016-12-16 17:50, John McNamara:
> Add a new section to the Code Contributors Guide to outline
> the roles of tree and component maintainers and how they
> can be added and removed.
>
> Signed-off-by: John McNamara
Applied, thanks
> > Signed-off-by: Yong Wang
> > ---
> > v2:
> > * modify some redundant descriptions.
>
>
> Thanks,
>
> Acked-by: John McNamara
Applied, thanks
On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
> I forgot one thing: to update the features file with this new one.
>
> I will wait for your feedback regarding the discussed problem for
> sending another version.
I think it is good to go, please send updated version.
>
<...>
>
> Sorr
> > The Python requirement should appear in the bullet list.
> >
> > Also, indent the x32 note, since it is related to the previous bullet.
> >
> > Signed-off-by: Baruch Siach
>
> Acked-by: John McNamara
Applied, thanks
On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit
wrote:
> On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
> > I forgot one thing: to update the features file with this new one.
> >
> > I will wait for your feedback regarding the discussed problem for
> > sending another version.
>
> I think it is go
> > DPDK source archives are .tar.xz or .tar.gz, not .zip. Use .tar.xz in the
> > instructions, since that is what the main download page links to.
> >
> > Also, correct the archive file and directory name capitalization.
> >
> > Signed-off-by: Baruch Siach
>
> Acked-by: John McNamara
Applied
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Monday, December 19, 2016 4:34 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] doc: simplify L3fwd user guide examples
>
> L3 Forwarding sample app user guides have some inconsistencies betw
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
> Sent: Tuesday, December 20, 2016 10:27 AM
> To: Baruch Siach
> Cc: dev@dpdk.org; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v2] doc: fix required tools list layout
>
> > > The Python requirement should
On Tue, Nov 22, 2016 at 1:57 PM, Shreyansh Jain wrote:
> On Monday 21 November 2016 10:25 PM, Jan Blunck wrote:
>>
>> The struct rte_intr_handle is an abstraction layer for different types of
>> interrupt mechanisms. It is embedded in the low-level device (e.g. PCI).
>> On allocation of a struct r
On Mon, Dec 19, 2016 at 08:44:07PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> > Sent: Monday, December 19, 2016 5:49 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v3 25/25] doc: describe test
On Tue, Dec 20, 2016 at 10:29 AM, Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
>
>
> On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit
> wrote:
>
>> On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
>> > I forgot one thing: to update the features file with this new one.
>> >
>> > I will wa
This is a repost of the series I sent in November. I've addressed Shreyansh's
review comments about the PCI device users I've missed.
Jan Blunck (9):
eal: define container_of macro
ethdev: Helper to convert to struct rte_pci_device
drivers: Use ETH_DEV_PCI_DEV() helper
virtio: Don't fill d
This macro is based on Jan Viktorin's original patch but also checks the
type of the passed pointer against the type of the member.
Signed-off-by: Jan Viktorin
Signed-off-by: Shreyansh Jain
[jblu...@infradead.org: add type checking and __extension__]
Signed-off-by: Jan Blunck
---
lib/librte_ea
Signed-off-by: Jan Blunck
Acked-by: Shreyansh Jain
---
lib/librte_ether/rte_ethdev.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 9678179..3adbb2b 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rt
The drivers should not directly access the rte_eth_dev->pci_dev but use
a macro instead. This is a preparation for replacing the pci_dev with
a struct rte_device member in the future.
Signed-off-by: Jan Blunck
---
drivers/net/bnx2x/bnx2x_ethdev.c| 12 +++---
drivers/net/bnxt/bnxt_ethdev.
This is overwritten in rte_eth_dev_info_get().
Signed-off-by: Jan Blunck
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_ethdev.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 079fd6c..741688e 1006
This adds a helper to get the rte_intr_handle from the virtio_hw. This is
safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC
which is only set if we found a PCI device during initialization.
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 12 +++---
The struct rte_intr_handle is an abstraction layer for different types of
interrupt mechanisms. It is embedded in the low-level device (e.g. PCI).
On allocation of a struct rte_eth_dev a reference to the intr_handle
should be stored for devices supporting interrupts.
Signed-off-by: Jan Blunck
---
Only the device itself can decide its PCI or not.
Signed-off-by: Jan Blunck
---
drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++
drivers/net/e1000/em_ethdev.c | 1 +
drivers/net/e1000/igb_ethd
We don't need to depend on rte_eth_dev->pci_dev to differentiate between
the virtio_user and the virtio_pci case. Instead we can use the private
virtio_hw struct to get that information.
Signed-off-by: Jan Blunck
---
drivers/net/virtio/virtio_ethdev.c | 21 ++---
1 file changed,
On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
wrote:
> The info in rte_device about driver is immutable and
> shouldn't change.
> ---
> lib/librte_eal/common/include/rte_dev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/rte_dev.h
>
On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote:
> As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> described in [3] (also pasted below), here is the first non-draft series
> for this new API.
>
> [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html
> [2] http:/
Signed-off-by: Jan Blunck
---
app/test/virtual_pmd.c | 4 ++--
drivers/net/bonding/rte_eth_bond_args.c | 12 ++--
drivers/net/cxgbe/cxgbe_main.c | 4 ++--
drivers/net/fm10k/fm10k_ethdev.c| 6 +++---
drivers/net/virtio/virtio_user_ethdev.c | 1 -
lib/l
On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
wrote:
> Since rte_eth_dev_info_get does memset() on dev_info before
> calling device specific code, the explicit assignment of NULL
> in all these virtual drivers has no effect.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/test/virtual_pmd
On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
wrote:
> The result from rte_eth_dev_info_get should have pointer to
> device not PCI device. This breaks ABI but is necessary.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/test-pmd/config.c | 32 ++
Hi Billy,
On Fri, Dec 16, 2016 at 07:48:49AM -0500, Billy McFall wrote:
> Add a new API to force free consumed buffers on TX ring. API will return
> the number of packets freed (0-n) or error code if feature not supported
> (-ENOTSUP) or input invalid (-ENODEV).
>
> Because rte_eth_tx_buffer() ma
On 12/20/2016 11:11 AM, Jan Blunck wrote:
> This is overwritten in rte_eth_dev_info_get().
>
> Signed-off-by: Jan Blunck
> Reviewed-by: David Marchand
> ---
> drivers/net/virtio/virtio_ethdev.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Tuesday, December 20, 2016 11:28 AM
> To: Billy McFall
> Cc: thomas.monja...@6wind.com; Lu, Wenzhuo ;
> dev@dpdk.org; Stephen Hemminger
>
> Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: N
On 12/16/2016 6:40 PM, Shreyansh Jain wrote:
This patch introduces the rte_bus abstraction for devices and drivers in
EAL framework. The model is:
- One or more buses are connected to a CPU (or core)
- One or more devices are conneted to a Bus
- Drivers are running instances which manage one o
On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit wrote:
> On 12/20/2016 11:11 AM, Jan Blunck wrote:
>> This is overwritten in rte_eth_dev_info_get().
>>
>> Signed-off-by: Jan Blunck
>> Reviewed-by: David Marchand
>> ---
>> drivers/net/virtio/virtio_ethdev.c | 4
>> 1 file changed, 4 deletions
On Tuesday 20 December 2016 04:21 PM, Jan Blunck wrote:
On Tue, Nov 22, 2016 at 1:57 PM, Shreyansh Jain wrote:
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote:
The struct rte_intr_handle is an abstraction layer for different types of
interrupt mechanisms. It is embedded in the low-level
On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
wrote:
> This set of patches generalize the ethernet device model sufficently
> to support virtual, pci, and vmbus devices.
>
> All this is based on the XP principal of only building what is
> necessary and no more than that. The rationale is NOT
NFP supports more speeds than just 40 and 100GB, which were
what was advertised before.
v2: add feature to nfp.ini
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/features/nfp.ini | 1 +
drivers/net/nfp/nfp_net.c| 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a
On 12/20/2016 12:40 PM, Jan Blunck wrote:
> On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit wrote:
>> On 12/20/2016 11:11 AM, Jan Blunck wrote:
>>> This is overwritten in rte_eth_dev_info_get().
>>>
>>> Signed-off-by: Jan Blunck
>>> Reviewed-by: David Marchand
>>> ---
>>> drivers/net/virtio/virti
On Tue, Dec 20, 2016 at 12:17:10PM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> > Sent: Tuesday, December 20, 2016 11:28 AM
> > To: Billy McFall
> > Cc: thomas.monja...@6wind.com; Lu, Wenzhuo ;
>
On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
wrote:
> Since multiple buses and device types need to be supported.
> Provide type field in driver.
> ---
> lib/librte_eal/common/include/rte_dev.h | 15 ---
> lib/librte_eal/common/include/rte_pci.h | 1 +
> lib/librte_eal/commo
On 12/19/2016 9:59 PM, Stephen Hemminger wrote:
> Since multiple buses and device types need to be supported.
> Provide type field in driver.
> ---
> lib/librte_eal/common/include/rte_dev.h | 15 ---
> lib/librte_eal/common/include/rte_pci.h | 1 +
> lib/librte_eal/common/include/rt
On Tue, Dec 20, 2016 at 11:13:42AM +, Bruce Richardson wrote:
> On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote:
> > As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> > described in [3] (also pasted below), here is the first non-draft series
> > for this new API.
> >
On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain wrote:
> This patch introduces the rte_bus abstraction for devices and drivers in
> EAL framework. The model is:
> - One or more buses are connected to a CPU (or core)
> - One or more devices are conneted to a Bus
> - Drivers are running instances
Previous reported speed was hardcoded because there was not firmware
support for getting this information. This change needs also to support
old firmware versions, but instead of the previous hardcoded report, no
speed is reported to the user avoiding to give the wrong speed when link
is not config
On Tue, Dec 20, 2016 at 06:39:30PM +0530, Jerin Jacob wrote:
> On Tue, Dec 20, 2016 at 11:13:42AM +, Bruce Richardson wrote:
> > On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote:
> > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> > > described in [3] (also pasted
On 12/16/2016 7:02 PM, Ferruh Yigit wrote:
> From: Qi Zhang
>
> This patch add support to get/clear VF statistics
> from PF side.
> Two APIs are added:
> rte_pmd_i40e_get_vf_stats.
> rte_pmd_i40e_reset_vf_stats.
>
> Signed-off-by: Qi Zhang
> ---
<...>
> diff --git a/drivers/net/i40e/rte_pmd_i
On 12/13/2016 5:41 PM, Tomasz Kulasek wrote:
> From: "Ananyev, Konstantin"
>
> Signed-off-by: Konstantin Ananyev
> ---
<...>
>
> uint16_t
> +vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
> + uint16_t nb_pkts)
> +{
<...>
> +
> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
>
Hi Ferruh,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Tuesday, December 20, 2016 1:25 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing ; Zhang, Helin
> ; Zhang, Qi Z ; Lu, Wenzhuo
> ; Chen, Jing D
> Subject: Re: [dpdk-dev] [PATCH v5 29/29] net
> > Signed-off-by: Baruch Siach
> > ---
> > doc/guides/sample_app_ug/ethtool.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Missing fixline
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample
> application")
>
> Otherwise, well spotted.. :)
>
> Acked-
On 12/20/2016 1:22 PM, Alejandro Lucero wrote:
> Previous reported speed was hardcoded because there was not firmware
> support for getting this information. This change needs also to support
> old firmware versions, but instead of the previous hardcoded report, no
> speed is reported to the user a
On 12/20/2016 12:52 PM, Alejandro Lucero wrote:
> NFP supports more speeds than just 40 and 100GB, which were
> what was advertised before.
>
> v2: add feature to nfp.ini
>
> Signed-off-by: Alejandro Lucero
> ---
Applied to dpdk-next-net/master, thanks.
> -Original Message-
> From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck
> Sent: Tuesday, December 20, 2016 6:47 PM
> To: Shreyansh Jain
> Cc: dev@dpdk.org; David Marchand ; Thomas Monjalon
> ; Ferruh Yigit ;
> jianbo@linaro.org
> Subject: Re: [dpdk-dev] [PATCH
> > This patch fixes a trivial typo in testpmd application user guide.
> >
> > Signed-off-by: Rami Rosen
>
> Acked-by: John McNamara
Applied, thanks
NFP is a smart programmable NIC and firmware is deployed for specific
system needs, like offloading OVS, vRouter, contrack or eBPF into the
hardware. This often requires to give metadata to the host within
packets delivered. Last NFP firmware implementations support richer
metadata api facilitating
Thank you for your responses, see inline.
On Tue, Dec 20, 2016 at 7:58 AM, Adrien Mazarguil
wrote:
> On Tue, Dec 20, 2016 at 12:17:10PM +, Ananyev, Konstantin wrote:
>>
>>
>> > -Original Message-
>> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
>> > Sent: Tue
On 12/17/2016 6:03 PM, Chas Williams wrote:
> This patch initializes the eth_dev->link_intr_cbs queue which is
> used when af_packet is passed into rte_eth_ev_callback_register().
Why do you want to register callback to af_packet PMD, it won't be
calling them?
>
> Fixes: 4dc294158cac ("ethdev: s
On 12/20/2016 11:03 AM, Thomas Monjalon wrote:
Signed-off-by: Maxime Coquelin
There is one trailing whitespace warning but apart from that:
Acked-by: John McNamara
Thanks John,
Do you want me to send a v3, fixing the trailing whitespace & collecting
the acks?
No need (unless the tree
2016-11-30 10:47, Remy Horton:
> Doing a device information query on a non-PCI device such as
> vhost was resulting in the dereferencing of a NULL pointer
> (the absent PCI data), causing a segmentation fault.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample
> application
Le 20/12/2016 à 05:48, Chen, Jing D a écrit :
That's a collaboration with another team. we'll follow-up that but not guarantee
it will happen.
May I ask if my reply make it clear? Still NAC for this patch?
Yes still nack, I am not confident with this PF approach since you are
breaking Linux PF
Le 19/12/2016 à 12:03, Ferruh Yigit a écrit :
And it is always possible to move these into ethdev layer, when multiple
PMDs supports same feature.
I agree this is something that needs to keep an eye on it, and be sure
if an API is generic, move it into eth_dev layer.
you are right, you have a g
On 12/15/2016 9:59 PM, Thomas Monjalon wrote:
> The current tools/ and scripts/ directory names are not
> self describing.
> These patches create devtools/ and usertools/ directories.
I think classifying scripts is a good idea.
>
> Thomas Monjalon (3):
> scripts: move to buildtools
> scripts
On Tue, 20 Dec 2016 12:11:48 +0100
Jan Blunck wrote:
> Signed-off-by: Jan Blunck
> Acked-by: Shreyansh Jain
> ---
> lib/librte_ether/rte_ethdev.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 9678179..3adbb
On 12/20/2016 3:18 PM, Vincent JARDIN wrote:
> Le 20/12/2016 à 05:48, Chen, Jing D a écrit :
>> That's a collaboration with another team. we'll follow-up that but not
>> guarantee
>> it will happen.
>> May I ask if my reply make it clear? Still NAC for this patch?
>
> Yes still nack, I am not con
On Tue, 20 Dec 2016 12:11:53 +0100
Jan Blunck wrote:
> Only the device itself can decide its PCI or not.
>
> Signed-off-by: Jan Blunck
> ---
> drivers/net/bnx2x/bnx2x_ethdev.c| 1 +
> drivers/net/bnxt/bnxt_ethdev.c | 2 ++
> drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++
> dr
Hello,
I have several XL710-Q2 interfaces that fail with
`PMD: eth_i40e_dev_init(): Failed to init adminq: -54'
Rebase to the latest dpdk-next-net/master did not fix the fault
Firmware version is 5.04 0x80002505 0.0.0
lspci output looks the same for working and failed interfaces
Full traces with
Hi Adrien,
On 12/19/2016 5:48 PM, Adrien Mazarguil wrote:
> Managing generic flow API functions from command line requires the use of
> dynamic tokens for convenience as flow rules are not fixed and cannot be
> defined statically.
>
> This commit adds specific flexible parser code and object for
add dmesg output:
dmar: DRHD: handling fault status reg 502
dmar: DMAR:[DMA Read] Request device [04:00.0] fault addr 865bcc000
DMAR:[fault reason 02] Present bit in context entry is clear
dmar: DRHD: handling fault status reg 602
dmar: DMAR:[DMA Read] Request device [04:00.0] fault addr 865bcc00
Hi Adrien,
There seems to be an issue when building the PDF version of the docs
due to the width of some of the fields in 2 of the tables. I think
this may be a Sphinx/Latex bug since it doesn't happen without the
table:: directive.
If you replace the following tables with the format below (the t
On 12/2/2016 10:42 AM, Wei Zhao wrote:
> From: wei zhao1
>
> Add support for storing SYN filter in SW.
Do you think does it makes more clear to refer as TCP SYN filter? Or SYN
filter is clear enough?
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: wei zhao1
Can you please update sign-off to
On 12/2/2016 10:42 AM, Wei Zhao wrote:
> From: wei zhao1
>
> Add support for storing flow director filter in SW.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: wei zhao1
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 48 ++
> drivers/net/ixgbe/ixgbe_ethdev.h | 19 ++-
> driv
On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1
>
> Add support for restoring n-tuple filter in SW.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: wei zhao1
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 131
> +--
> 1 file changed, 83 insertions(+),
On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1
>
> check if the rule is a flow director rule, and get the flow director info.
>
> Signed-off-by: wei zhao1
> Signed-off-by: Wenzhuo Lu
> ---
<...>
> + PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule,
> + RTE_F
On 12/19/2016 5:49 PM, Adrien Mazarguil wrote:
> Document syntax, interaction with rte_flow and provide usage examples.
>
> Signed-off-by: Adrien Mazarguil
> Acked-by: Olga Shern
> ---
<...>
> +
> +Check whether redirecting any Ethernet packet received on port 0 to RX queue
> +index 6 is suppo
On Tue, 20 Dec 2016 14:00:55 +0100
Jan Blunck wrote:
> On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger
> wrote:
> > Since multiple buses and device types need to be supported.
> > Provide type field in driver.
> > ---
> > lib/librte_eal/common/include/rte_dev.h | 15 ---
> > li
On Tue, 20 Dec 2016 14:17:14 +0100
Jan Blunck wrote:
> On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain
> wrote:
> > This patch introduces the rte_bus abstraction for devices and drivers in
> > EAL framework. The model is:
> > - One or more buses are connected to a CPU (or core)
> > - One or m
On Tue, 20 Dec 2016 12:23:25 +0530
Shreyansh Jain wrote:
> On Tuesday 20 December 2016 03:29 AM, Stephen Hemminger wrote:
> > Allow sufficicent space for UUID in string form (36+1).
> > Needed to use UUID with Hyper-V
> >
> > Signed-off-by: Stephen Hemminger
> > ---
> > doc/guides/rel_notes/dep
On Tue, 20 Dec 2016 12:46:17 +0530
Shreyansh Jain wrote:
> On Tuesday 20 December 2016 03:29 AM, Stephen Hemminger wrote:
> > Since multiple buses and device types need to be supported.
> > Provide type field in driver.
> > ---
> > lib/librte_eal/common/include/rte_dev.h | 15 ---
>
2016-11-23 09:00, Remy Horton:
> Not sure this is a problem in practice, as the same set if fields is
> updated each time...at least for now.
>
> On 22/11/2016 09:41, Qiming Yang wrote:
> > Function pcmd_drvinfo_callback uses struct info to get
> > the ethtool information of each port. Struct inf
On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1
>
> Add rule validate function and check if the rule is a n-tuple rule,
> and get the n-tuple info.
>
> Signed-off-by: wei zhao1
> Signed-off-by: Wenzhuo Lu
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 349
> +
On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1
>
> This patch adds a function to create the flow directory filter.
>
> Signed-off-by: wei zhao1
> Signed-off-by: Wenzhuo Lu
<...>
> +/**
> + * Create or destroy a flow rule.
> + * Theorically one rule can match more than one filters.
> > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to
> > declare the list of kernel modules required to run properly.
> >
> > Today, most PCI drivers require uio/vfio.
> >
> > Signed-off-by: Olivier Matz
> > Acked-by: Fiona Trahe
>
> Acked-by: Adrien Mazarguil
Applied in m
On 12/2/2016 11:53 AM, Beilei Xing wrote:
> Check if the rule is a ethertype rule, and get the ethertype
> info BTW.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Beilei Xing
> ---
CC: Adrien Mazarguil
> lib/librte_ether/rte_flow.c| 136
> +
> li
As previously discussed in RFC v1 [1], RFC v2 [2], with changes
described in [3] (also pasted below), here is the first non-draft series
for this new API.
Its capabilities are so generic that its name had to be vague, it may be
called "Generic flow API", "Generic flow interface" (possibly shortene
This new API supersedes all the legacy filter types described in
rte_eth_ctrl.h. It is slightly higher level and as a result relies more on
PMDs to process and validate flow rules.
Benefits:
- A unified API is easier to program for, applications do not have to be
written for a specific filter t
They are superseded by the generic flow API (rte_flow). Target release is
not defined yet.
Suggested-by: Kevin Traynor
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
doc/guides/rel_notes/deprecation.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/
This documentation is based on the latest RFC submission, subsequently
updated according to feedback from the community.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
doc/guides/prog_guide/index.rst|1 +
doc/guides/prog_guide/rte_flow.rst | 2042 ++
Considering tokens must be hard-coded in a list part of the instruction
structure, context-dependent tokens cannot be expressed.
This commit adds support for building dynamic token lists through a
user-provided function, which is called when the static token list is empty
(a single NULL entry).
B
This prevents sigbus errors on architectures that cannot handle unexpected
unaligned accesses to the output buffer.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
lib/librte_cmdline/cmdline_parse.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte
Add basic management functions for the generic flow API (validate, create,
destroy, flush, query and list). Flow rule objects and properties are
arranged in lists associated with each port.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline.c | 1 +
app/test-pmd
Parse all integer types and handle conversion to network byte order in a
single function.
Signed-off-by: Adrien Mazarguil
Acked-by: Olga Shern
---
app/test-pmd/cmdline_flow.c | 148 +++
1 file changed, 148 insertions(+)
diff --git a/app/test-pmd/cmdline_flow
Managing generic flow API functions from command line requires the use of
dynamic tokens for convenience as flow rules are not fixed and cannot be
defined statically.
This commit adds specific flexible parser code and object for a new "flow"
command in separate file.
Signed-off-by: Adrien Mazargu
1 - 100 of 163 matches
Mail list logo
