On 12/20/2016 12:40 PM, Jan Blunck wrote:
> On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>> On 12/20/2016 11:11 AM, Jan Blunck wrote:
>>> This is overwritten in rte_eth_dev_info_get().
>>>
>>> Signed-off-by: Jan Blunck <jblu...@infradead.org>
>>> Reviewed-by: David Marchand <david.march...@6wind.com>
>>> ---
>>> drivers/net/virtio/virtio_ethdev.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/net/virtio/virtio_ethdev.c
>>> b/drivers/net/virtio/virtio_ethdev.c
>>> index 079fd6c..741688e 100644
>>> --- a/drivers/net/virtio/virtio_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_ethdev.c
>>> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct
>>> rte_eth_dev_info *dev_info)
>>> uint64_t tso_mask;
>>> struct virtio_hw *hw = dev->data->dev_private;
>>>
>>> - if (dev->pci_dev)
>>> - dev_info->driver_name = dev->driver->pci_drv.driver.name;
>>> - else
>>> - dev_info->driver_name = "virtio_user PMD";
>>> dev_info->max_rx_queues =
>>> RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);
>>> dev_info->max_tx_queues =
>>>
>>
>>
>> This has been already removed in next-net with following commit:
>> 7c6c1857358c ("net: remove dead driver names")
>
> Thanks. Do you want me to rebase against next-net and resend the
> series before continuing to review further?
>
No, I thought this patch can be dropped from patchset, but no, you need
this for decoupling pci_dev.
So, this needs to be resolved in integration time.
I believe this patchset should be against main tree, because of eal and
ethdev patches in it.
And there are already a few patchset around for this area, let's not add
more complexity by adding next-net into the picture.
