Re: [dpdk-dev] [PATCH 4/4] lib/librte_vhost: improve vhost perf using rte_memset

2016-12-06 Thread Yang, Zhiyong
Hi, Thomas: > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, December 2, 2016 5:46 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 4/4] lib/

[dpdk-dev] [PATCH] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Baruch Siach
Since commit 4a96e8b652 ("mbuf: allow to clone an indirect mbuf") attaching to an indirect mbuf creates a clone of that mbuf. Update the mbuf documentation to match. Signed-off-by: Baruch Siach --- doc/guides/prog_guide/mbuf_lib.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v2] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Baruch Siach
Since commit 4a96e8b652181 ("mbuf: allow to clone an indirect mbuf") attaching to an indirect mbuf creates a clone of that mbuf. Update the mbuf documentation to match. Signed-off-by: Baruch Siach --- v2: fix checkpatch issues: long commit log lines, short commit id --- doc/guides/prog_guide/mbu

Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test

2016-12-06 Thread Maxime Coquelin
On 12/06/2016 07:33 AM, Yang, Zhiyong wrote: Hi, Maxime: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Friday, December 2, 2016 6:01 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: yuanhan@linux.intel.com; Richardson, Bruce ; Ananyev, Konstantin Subje

Re: [dpdk-dev] [PATCH 08/13] eal: enable probe and remove from bus infrastructure

2016-12-06 Thread Shreyansh Jain
On Sunday 04 December 2016 03:41 PM, Shreyansh Jain wrote: The model is: rte_eal_init `--> calls rte_eal_bus_probe() This iterates over all the drivers and devices and matches them. For matched bus specific device-driver: `--> bus->probe() This would be responsible

Re: [dpdk-dev] [PATCH v3] eal/linuxapp: fix return value check of mknod()

2016-12-06 Thread Olivier Matz
Hi Wei, On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai wrote: > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > The return value of mknod() is ret, not f got by fopen(). > So the value of ret should be checked for mknod(). > > Fixes: f7f97c16048e ("pci: add option --create-ui

Re: [dpdk-dev] [PATCH] maintainers: update for qede PMD and bnx2x PMD

2016-12-06 Thread Thomas Monjalon
2016-12-02 22:24, Rasesh Mody: > QLogic bnx2x > -M: Sony Chacko > -M: Harish Patil > -M: Rasesh Mody > +M: Harish Patil > +M: Rasesh Mody > F: drivers/net/bnx2x/ > F: doc/guides/nics/bnx2x.rst > > QLogic qede PMD > -M: Harish Patil > -M: Rasesh Mody > -M: Sony Chacko > +M: Rasesh Mody

Re: [dpdk-dev] [PATCH 0/3] net: optimize Rx/Tx log message level

2016-12-06 Thread Ferruh Yigit
Hi Qiming, On 12/3/2016 10:43 AM, Qiming Yang wrote: > These three patches optimized the level of Rx and Tx log > messages. Add a new log control function PMD_RX_FREE_LOG > to control the Rx message which is not printed in packet > receive processing. This function switched by macro > RTE_LIBRTE_

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Ananyev, Konstantin
Hi Adrien, > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > [...] > > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > > [...] > > > > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > > > > > [...] > > > > > > Do you hav

[dpdk-dev] [PATCH 1/2] doc: remove chkincs reference

2016-12-06 Thread Baruch Siach
The chkincs app was removed in commit 1b938bb9dfb6 ("app: remove chkincs"). Signed-off-by: Baruch Siach --- doc/guides/prog_guide/source_org.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/guides/prog_guide/source_org.rst b/doc/guides/prog_guide/source_org.rst index d9c140f704e3..4a4

Re: [dpdk-dev] [PATCH v3] eal/linuxapp: fix return value check of mknod()

2016-12-06 Thread Thomas Monjalon
2016-12-06 11:44, Olivier Matz: > Hi Wei, > > On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai wrote: > > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > > The return value of mknod() is ret, not f got by fopen(). > > So the value of ret should be checked for mknod(). > > > > F

[dpdk-dev] [PATCH 2/2] doc: note that the app list is incomplete

2016-12-06 Thread Baruch Siach
Extend the note at the end of Source Organization chapter to also mention the app directory. Signed-off-by: Baruch Siach --- doc/guides/prog_guide/source_org.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/source_org.rst b/doc/guides/prog_guide/sour

Re: [dpdk-dev] [PATCH v2] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 8:25 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Olivier Matz > ; Baruch Siach > Subject: [PATCH v2] doc: correct description of attach to indirect mbuf > > Since commit 4a96e8b652181

Re: [dpdk-dev] [PATCH v2] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Baruch Siach
Hi John, On Tue, Dec 06, 2016 at 11:03:18AM +, Mcnamara, John wrote: > > -Original Message- > > From: Baruch Siach [mailto:bar...@tkos.co.il] > > Sent: Tuesday, December 6, 2016 8:25 AM > > To: dev@dpdk.org > > Cc: Mcnamara, John ; Olivier Matz > > ; Baruch Siach > > Subject: [PATCH v

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
Hi Neilo, Hi Neilo, > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > > > accordingly. > > > > > > Specific big/little endian types avoid uncertainty and conversion > > > mistakes. > > > > > >

[dpdk-dev] [PATCH] doc: remove the repeat words in documentation.rst

2016-12-06 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/contributing/documentation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst index 2cfb1a2..5ec0675 100644 --- a/doc/guides/contributing/documentati

Re: [dpdk-dev] [PATCH] doc: remove the repeat words in documentation.rst

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Tuesday, December 6, 2016 12:31 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH] doc: remove the repeat words in documentation.rst > > Signed-off-by: Yong Wang Good catch. Acked-b

Re: [dpdk-dev] [PATCH v2] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 11:11 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Olivier Matz > Subject: Re: [PATCH v2] doc: correct description of attach to indirect > mbuf > > ... > > Thanks, please keep the doc fi

Re: [dpdk-dev] [PATCH 2/2] doc: note that the app list is incomplete

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 11:02 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Baruch Siach > > Subject: [PATCH 2/2] doc: note that the app list is incomplete > > Extend the note at the end of Source Organization

Re: [dpdk-dev] [PATCH 0/2] Event queue exception handling in Solarflare PMD

2016-12-06 Thread Ferruh Yigit
On 12/2/2016 7:41 AM, Andrew Rybchenko wrote: > The patch series adds event queue exception handling. > > It is not required when everything goes fine, but has chances to > recover if something goes wrong in either driver or HW. > > The patch series should be applied after > [PATCH v2 00/55] Sola

Re: [dpdk-dev] [PATCH 1/2] doc: remove chkincs reference

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 11:02 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Baruch Siach > > Subject: [PATCH 1/2] doc: remove chkincs reference > > The chkincs app was removed in commit 1b938bb9dfb6 ("app: rem

Re: [dpdk-dev] [PATCH] vhost: allow for many vhost user ports

2016-12-06 Thread Jan Wickbom
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: den 6 december 2016 07:57 > To: Jan Wickbom > Cc: huawei@intel.com; dev@dpdk.org; Patrik Andersson R > > Subject: Re: [PATCH] vhost: allow for many vhost user ports > > On Thu, Dec 01, 2016 at 04:26

Re: [dpdk-dev] [PATCH 2/2] doc: note that the app list is incomplete

2016-12-06 Thread Baruch Siach
Hi John, On Tue, Dec 06, 2016 at 11:41:44AM +, Mcnamara, John wrote: > > Extend the note at the end of Source Organization chapter to also mention > > the app directory. > > > > Signed-off-by: Baruch Siach > > --- > > doc/guides/prog_guide/source_org.rst | 2 +- > > 1 file changed, 1 insert

Re: [dpdk-dev] [PATCH 2/2] doc: note that the app list is incomplete

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 11:46 AM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] doc: note that the app list is incomplete > > Hi John, > > On Tue, Dec 06, 2016 at 11:41:44AM +, Mcnama

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > Hi Neilo, > > > Hi Neilo, > > > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > > > > accordingly. > > > > > > > > Speci

Re: [dpdk-dev] [PATCH v3] nfp: report link speed using hardware info

2016-12-06 Thread Ferruh Yigit
On 12/2/2016 9:05 AM, Alejandro Lucero wrote: > Previous reported speed was hardcoded. > > v3: remove unsed macro > v2: using RTE_DIM instead of own macro > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 28 ++-- > 1 file changed, 26 insertions(+),

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-06 Thread Ferruh Yigit
On 12/2/2016 8:17 AM, Alejandro Lucero wrote: > Signed-off-by: Alejandro Lucero > --- > doc/guides/nics/features/nfp.ini | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/doc/guides/nics/features/nfp.ini > b/doc/guides/nics/features/nfp.ini > index d967151..dd7

[dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

2016-12-06 Thread Maxime Coquelin
Having reference benchmarks is important in order to obtain reproducible performance figures. This patch describes required steps to configure a PVP setup using testpmd in both host and guest. Not relying on external vSwitch ease integration in a CI loop by not being impacted by DPDK API changes.

[dpdk-dev] [PATCH v2 1/3] doc: note that the app list is incomplete

2016-12-06 Thread Baruch Siach
Extend the note at the end of Source Organization chapter to also mention the app directory. Signed-off-by: Baruch Siach --- v2: Refer to 'applications' in general (John M) --- doc/guides/prog_guide/source_org.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/pro

[dpdk-dev] [PATCH v2 2/3] doc: correct the description of the app directory

2016-12-06 Thread Baruch Siach
The applications under the app directory are just that, not sample applications. Signed-off-by: Baruch Siach --- v2: New patch (John M) --- doc/guides/prog_guide/source_org.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/source_org.rst b/doc/guides/

[dpdk-dev] [PATCH v2 3/3] doc: consistently quote directory names

2016-12-06 Thread Baruch Siach
Quote the names of the app and example directories like other directory names in this chapter. Signed-off-by: Baruch Siach --- v2: New patch --- doc/guides/prog_guide/source_org.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/source_org.rst b/

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, December 6, 2016 11:55 AM > To: Ananyev, Konstantin > Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier Matz > ; Lu, Wenzhuo > ; Adrien Mazarguil > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and little endian types > >

Re: [dpdk-dev] [PATCH v2 1/3] doc: note that the app list is incomplete

2016-12-06 Thread Mcnamara, John
Acked-by: John McNamara > -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 12:38 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Baruch Siach > > Subject: [PATCH v2 1/3] doc: note that the app list is incomplete > > Extend the note at th

Re: [dpdk-dev] [PATCH v2 2/3] doc: correct the description of the app directory

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 12:38 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Baruch Siach > > Subject: [PATCH v2 2/3] doc: correct the description of the app directory > > The applications under the app directo

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, December 6, 2016 12:08 PM > To: Alejandro Lucero ; dev@dpdk.org; > Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH] nfp: add doc about supported features > > On 12/2/2016 8:17 AM, Alejandro Lucero wrote: > > Signed-off-by: Alejan

Re: [dpdk-dev] [PATCH v2 3/3] doc: consistently quote directory names

2016-12-06 Thread Mcnamara, John
> -Original Message- > From: Baruch Siach [mailto:bar...@tkos.co.il] > Sent: Tuesday, December 6, 2016 12:38 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Baruch Siach > > Subject: [PATCH v2 3/3] doc: consistently quote directory names > > Quote the names of the app and example directori

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Nélio Laranjeiro
Hi Konstantin, Bruce, On Tue, Dec 06, 2016 at 11:55:02AM +, Bruce Richardson wrote: > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > > Hi Neilo, > > > > > > Hi Neilo, > > > > > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > > > rt

Re: [dpdk-dev] [PATCH v2] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS

2016-12-06 Thread Thomas Monjalon
> > > From: Bert van Leeuwen > > > > > > Arrays inside rte_eth_stats have size=RTE_ETHDEV_QUEUE_STAT_CNTRS. > > > Some devices report more queues than that and this code blindly uses > > > the reported number of queues by the device to fill those arrays up. > > > This patch fixes the problem usin

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 02:14:17PM +0100, Nélio Laranjeiro wrote: > Hi Konstantin, Bruce, > > On Tue, Dec 06, 2016 at 11:55:02AM +, Bruce Richardson wrote: > > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > > > Hi Neilo, > > > > > > > > > Hi Neilo, > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings

2016-12-06 Thread Thomas Monjalon
> > Formatted as: > > cmd fixed_string fixed|string|options : Description > > > > If there is no description, final colon emitted. > > > > Signed-off-by: Ferruh Yigit > > > Good refactoring work to give consistency. It might be worth having a look at > the testpmd docs to see if some of the s

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 12:41:00PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Tuesday, December 6, 2016 11:55 AM > > To: Ananyev, Konstantin > > Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier > > Matz ; Lu, Wenzhuo > > ; Adrien Mazar

Re: [dpdk-dev] [PATCH] app/testpmd: display port driver name

2016-12-06 Thread Thomas Monjalon
> > This makes it easier to check which driver name is reported through ethdev > > rte_eth_dev_info_get(). > > > > Example: > > > > root@ubuntu1604:~/dpdk# ./build/app/testpmd -c 0x6 --vdev > > net_af_packet0,iface=mgmt0 -- -i --total-num-mbufs 2049 [snip] > > testpmd> show port info all > > >

Re: [dpdk-dev] [PATCH] mempool: fix Api documentation

2016-12-06 Thread Thomas Monjalon
> > A previous commit changed the local_cache table into a pointer, reducing > > the size of the rte_mempool structure. > > > > Fix the API comment of rte_mempool_create() related to this modification. > > > > Fixes: 213af31e0960 ("mempool: reduce structure size if no cache needed") > > > > Sign

Re: [dpdk-dev] [PATCH 01/32] doc: add dpaa2 nic details

2016-12-06 Thread Hemant Agrawal
On 12/5/2016 10:42 PM, Mcnamara, John wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal Sent: Sunday, December 4, 2016 6:17 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Richardson, Bruce ; shreyansh.j...@nxp.com; Hemant Agrawal Subject: [

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Adrien Mazarguil
Hi Konstantin, On Tue, Dec 06, 2016 at 10:56:26AM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > > [...] > > > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > > > [...] > > > > > > On W

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
> On Dec 5, 2016, at 6:06 AM, Nélio Laranjeiro > wrote: > > On Mon, Dec 05, 2016 at 10:09:05AM +, Ananyev, Konstantin wrote: >> Hi Neilo, >> >>> >>> This commit introduces new rte_{le,be}{16,32,64}_t types and updates >>> rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures >>

Re: [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment

2016-12-06 Thread Thomas Monjalon
2016-12-05 11:39, Wei Zhao: > There is a redundant repetition mempool socket_id assignment in the > file rte_mempool.c in function rte_mempool_create_empty. The > statement "mp->socket_id = socket_id;"appear twice in line 821 > and 824. One of them is redundant, so delete it. > > Fixes: 85226f9c52

Re: [dpdk-dev] [PATCH v3] mempool: remove a redundant word "for" in comment

2016-12-06 Thread Thomas Monjalon
2016-12-05 11:40, Wei Zhao: > There is a redundant repetition word "for" in commnet line of the > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. > The word "for"appear twice in line 359 and 360. One of them is > redundant, so delete it. > > Fixes: 449c49b93a6b ("mempool: supp

Re: [dpdk-dev] [PATCH] doc: fix typos in code comments

2016-12-06 Thread Thomas Monjalon
> > Signed-off-by: Yong Wang > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: remove the repeat words in documentation.rst

2016-12-06 Thread Thomas Monjalon
> > Signed-off-by: Yong Wang > > Good catch. > > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen

2016-12-06 Thread Thomas Monjalon
2016-12-01 13:28, Mcnamara, John: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Thursday, December 1, 2016 11:02 AM > > To: dev@dpdk.org > > Cc: Pattan, Reshma > > Subject: [dpdk-dev] [PATCH v2] doc: add pdump library to API doxyg

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
> > On Tue, Dec 06, 2016 at 12:41:00PM +, Ananyev, Konstantin wrote: > > > > > > > -Original Message- > > > From: Richardson, Bruce > > > Sent: Tuesday, December 6, 2016 11:55 AM > > > To: Ananyev, Konstantin > > > Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier > > > Matz ; Lu, Wenzh

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-06 Thread Alejandro Lucero
Then I guess I should send another version of this patch. On Tue, Dec 6, 2016 at 12:46 PM, Mcnamara, John wrote: > > -Original Message- > > From: Yigit, Ferruh > > Sent: Tuesday, December 6, 2016 12:08 PM > > To: Alejandro Lucero ; dev@dpdk.org; > > Mcnamara, John > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
> On Dec 6, 2016, at 8:45 AM, Ananyev, Konstantin > wrote: > > > >> >> On Tue, Dec 06, 2016 at 12:41:00PM +, Ananyev, Konstantin wrote: >>> >>> -Original Message- From: Richardson, Bruce Sent: Tuesday, December 6, 2016 11:55 AM To: Ananyev, Konstantin

Re: [dpdk-dev] [PATCH] dpdk: Fix abort on double free.

2016-12-06 Thread Aaron Conole
Daniele Di Proietto writes: > On 29/11/2016 07:57, "Aaron Conole" wrote: > >>Hi Ilya, >> >>Ilya Maximets writes: >> >>> On 28.11.2016 21:55, Aaron Conole wrote: Ilya Maximets writes: > According to DPDK API (lib/librte_eal/common/include/rte_eal.h): > > "After the call

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Morten Brørup
Hi all, Being a big fan of strong typing, I really like the concept of explicit endian types. Especially if type mismatches can be caught at compile time. However, I think it is too late! That train left the station when the rest of the world - including libraries and headers that might be link

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Ferruh Yigit
On 11/28/2016 11:03 AM, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. > > Reminder of what Konstantin suggested: > " > - if the PMD supports TX offloads AND > - if to be able use any of these offloads the upper layer SW would have to: > * modify the content

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-06 Thread Ferruh Yigit
On 12/6/2016 2:51 PM, Alejandro Lucero wrote: > Then I guess I should send another version of this patch. I can also update the patch while applying, if you agree with following content (simply just all =N removed): [Features] +SR-IOV = Y +Link status = Y +Link status even

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Nélio Laranjeiro
Hi all, On Tue, Dec 06, 2016 at 04:34:07PM +0100, Morten Brørup wrote: > Hi all, > > Being a big fan of strong typing, I really like the concept of > explicit endian types. Especially if type mismatches can be caught at > compile time. +1, > However, I think it is too late! That train left the

Re: [dpdk-dev] [PATCH v1] doc: fix relative path of Nic table input file

2016-12-06 Thread Thomas Monjalon
> > Fix relative path between sphinx conf.py file and Nic table file > > to allow automatic build on ReadTheDocs. > > > > Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") > > > > Signed-off-by: John McNamara > > Acked-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
> On Dec 6, 2016, at 10:28 AM, Nélio Laranjeiro > wrote: > > Hi all, > > On Tue, Dec 06, 2016 at 04:34:07PM +0100, Morten Brørup wrote: >> Hi all, >> >> Being a big fan of strong typing, I really like the concept of >> explicit endian types. Especially if type mismatches can be caught at >> c

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Richardson, Bruce
> -Original Message- > From: Wiles, Keith > Sent: Tuesday, December 6, 2016 4:32 PM > To: Nélio Laranjeiro > Cc: Morten Brørup ; Ananyev, Konstantin > ; Richardson, Bruce > ; DPDK ; Olivier Matz > ; Lu, Wenzhuo ; Adrien > Mazarguil > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and

Re: [dpdk-dev] [PATCH v2 0/6] libeventdev API and northbound implementation

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 09:22:14AM +0530, Jerin Jacob wrote: > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > described in [3] (also pasted below), here is the first non-draft series > for this new API. > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html > [2] http:/

Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 09:22:15AM +0530, Jerin Jacob wrote: > In a polling model, lcores poll ethdev ports and associated > rx queues directly to look for packet. In an event driven model, > by contrast, lcores call the scheduler that selects packets for > them based on programmer-specified criter

Re: [dpdk-dev] [PATCH v2 1/3] doc: note that the app list is incomplete

2016-12-06 Thread Thomas Monjalon
2016-12-06 14:38, Baruch Siach: > Extend the note at the end of Source Organization chapter to also mention > the app directory. > > Signed-off-by: Baruch Siach [...] > --- a/doc/guides/prog_guide/source_org.rst > +++ b/doc/guides/prog_guide/source_org.rst > @@ -162,5 +162,5 @@ The examples direc

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
> -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Tuesday, December 6, 2016 4:28 PM > To: Morten Brørup > Cc: Wiles, Keith ; Ananyev, Konstantin > ; Richardson, Bruce > ; dev@dpdk.org; Olivier Matz > ; Lu, Wenzhuo ; Adrien > Mazarguil > Subject:

Re: [dpdk-dev] [PATCH] doc: remove wrong document description

2016-12-06 Thread Thomas Monjalon
> > The Programmer’s Guide intro is not the Release Notes. > > > > Signed-off-by: Baruch Siach > > > Acked-by: John McNamara Applied (merged with 2 others), thanks

Re: [dpdk-dev] [PATCH v2] doc: prog_guide: fix section heading

2016-12-06 Thread Thomas Monjalon
2016-11-30 07:43, Baruch Siach: > This section only deals with Tx queues configuration. > > Acked-by: John McNamara > Signed-off-by: Baruch Siach Applied (merged with 2 others), thanks

Re: [dpdk-dev] [PATCH] doc: fix wrong verbatim text paragraphs

2016-12-06 Thread Thomas Monjalon
> > Reduce the indentation of these paragraphs since they are not part of the > > verbatim block. > > > > Signed-off-by: Baruch Siach > > Acked-by: John McNamara Applied (merged with 2 others), thanks

Re: [dpdk-dev] [PATCH v2] doc: correct description of attach to indirect mbuf

2016-12-06 Thread Thomas Monjalon
> > > Thanks, please keep the doc fixes coming. > > > > > > It would be better to quote the function in fixed width text like: > > > ``rte_pktmbuf_attach()``. > > > > None of the function names mentioned in this chapter are quoted. I can > > post a fix for that, but I think it should be a separate

Re: [dpdk-dev] [PATCH v2 3/6] eventdev: implement the northbound APIs

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 09:22:17AM +0530, Jerin Jacob wrote: > This patch implements northbound eventdev API interface using > southbond driver interface > > Signed-off-by: Jerin Jacob > --- > config/common_base |6 + > lib/Makefile |

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Neil Horman
On Tue, Dec 06, 2016 at 05:00:05PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Tuesday, December 6, 2016 4:28 PM > > To: Morten Brørup > > Cc: Wiles, Keith ; Ananyev, Konstantin > > ; Richardson, B

Re: [dpdk-dev] [PATCH v1] doc: add details of sub-trees and maintainers

2016-12-06 Thread Thomas Monjalon
Thanks for documenting the process, John. 2016-12-02 16:44, John McNamara: > +The role of the component maintainers is to: > + I would add: * Coordinate how improvements and fixes are done. > +* Review patches for the component or delegate the review. > + This should be done, ideally, within 1-

[dpdk-dev] [PATCH v2 01/12] mk: fix build of assembly files for ARM64

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Avoid using incorrect assembler (nasm) and unsupported flags when building for ARM64. Signed-off-by: Zbigniew Bodek --- mk/arch/arm64/rte.vars.mk| 1 - mk/toolchain/gcc/rte.vars.mk | 6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/mk/arch/arm64

[dpdk-dev] [PATCH v2 03/12] crypto/armv8: Add core crypto operations for ARMv8

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek This patch adds core low-level crypto operations for ARMv8 processors. The assembly code is a base for an optimized PMD and is currently excluded from the build. Standalone SHA1 and SHA256 are provided to support partial hashing of inner/outer key+padding and authentication

[dpdk-dev] [PATCH v2 00/12] Add crypto PMD optimized for ARMv8

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Introduce crypto poll mode driver using ARMv8 cryptographic extensions. This PMD is optimized to provide performance boost for chained crypto operations processing, such as: * encryption + HMAC generation * decryption + HMAC validation. In particular, cipher only or hash only

[dpdk-dev] [PATCH v2 02/12] lib: add cryptodev type for the upcoming ARMv8 PMD

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Add type and name for ARMv8 crypto PMD Signed-off-by: Zbigniew Bodek --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 8f63e8f..7bab79d 100644 -

[dpdk-dev] [PATCH v2 05/12] crypto/armv8: Add AES+SHA1 crypto operations for ARMv8

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek This patch adds AES-128-CBC + SHA1 low-level crypto operations for ARMv8 processors. The assembly code is a base for an optimized PMD and is currently excluded from the build. This code is optimized to provide performance boost for combined operations such as encryption + HM

[dpdk-dev] [PATCH v2 06/12] crypto/armv8: add PMD optimized for ARMv8 processors

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek This patch introduces crypto poll mode driver using ARMv8 cryptographic extensions. CPU compatibility with this driver is detected in run-time and virtual crypto device will not be created if CPU doesn't provide: AES, SHA1, SHA2 and NEON. This PMD is optimized to provide per

[dpdk-dev] [PATCH v2 07/12] crypto/armv8: generate ASM symbols automatically

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek In order to acquire crypto_arg structure fields from the assembly code it is necessary to generate macros that will define offsets to those fields during app build. This will allow for free crypto_arg structure modifications in the future without the necessity to make similar

[dpdk-dev] [PATCH v2 08/12] mk/crypto/armv8: add PMD to the build system

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Build ARMv8 crypto PMD if compiling for ARM64 and CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO option is enable in the configuration file. Signed-off-by: Zbigniew Bodek --- drivers/crypto/Makefile | 3 +++ mk/rte.app.mk | 3 +++ 2 files changed, 6 insertions(+) diff --git

[dpdk-dev] [PATCH v2 10/12] crypto/armv8: enable ARMv8 PMD in the configuration

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Add CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO option to the common configuration file and enable it by default for ARM64. Signed-off-by: Zbigniew Bodek --- config/common_base | 6 ++ config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++ 2 files changed, 8

[dpdk-dev] [PATCH v2 11/12] crypto/armv8: update MAINTAINERS entry for ARMv8 crypto

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Signed-off-by: Zbigniew Bodek --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 26d9590..ef1f25b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -445,6 +445,12 @@ M: Declan Doherty F: drivers/crypto/openssl/ F: doc/gu

[dpdk-dev] [PATCH v2 12/12] app/test: add ARMv8 crypto tests and test vectors

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Introduce unit tests for ARMv8 crypto PMD. Add test vectors for short cases such as 160 bytes. These test cases are ARMv8 specific since the code provides different processing paths for different input data sizes. Add test vectors for cipher + SHA256 MAC generation. User can

[dpdk-dev] [PATCH v2 09/12] doc/armv8: update documentation about crypto PMD

2016-12-06 Thread zbigniew.bodek
From: Zbigniew Bodek Add documentation about the driver and update release notes. Signed-off-by: Zbigniew Bodek --- doc/guides/cryptodevs/armv8.rst| 82 ++ doc/guides/cryptodevs/index.rst| 1 + doc/guides/rel_notes/release_17_02.rst | 5 +++ 3

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-06 Thread Chandran, Sugesh
Hi Adrien, Thanks for sending out the patches, Please find few comments below, Regards _Sugesh > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kevin Traynor > Sent: Friday, December 2, 2016 9:07 PM > To: Adrien Mazarguil > Cc: dev@dpdk.org; Thomas Monjalon

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Yong Wang
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Sunday, December 4, 2016 4:11 AM > To: Yong Wang ; Thomas Monjalon > > Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy > ; Stephen Hurd > ; Jan Medala ; Jakub > Palider ; John Daley ; Adrien >

Re: [dpdk-dev] [PATCH 01/32] doc: add dpaa2 nic details

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:16 PM, Hemant Agrawal wrote: > Add the dpaa2 architecture and pmd details > > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/dpaa2.rst | 537 > + > doc/guides/nics/features/dpaa2.ini | 9 + > doc/guides/nics/index.rst

Re: [dpdk-dev] [PATCH 00/32] NXP DPAA2 PMD

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:16 PM, Hemant Agrawal wrote: > The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based > network SoC PMD. This version of the driver supports NXP LS208xA, > LS204xA and LS108x families Network SoCs. > > DPAA2, or Data Path Acceleration Architecture, is a hardware arch

Re: [dpdk-dev] [PATCH 02/32] drivers/common: introducing dpaa2 mc driver

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:16 PM, Hemant Agrawal wrote: > This patch intoduces the DPAA2 MC(Management complex Driver) > > This driver is common to be used by various DPAA2 net, crypto > and other drivers > > Signed-off-by: Cristian Sovaiala > [Hemant:rebase and conversion to library for DPDK] Is this note

Re: [dpdk-dev] [PATCH 09/32] lib/ether: add rte_device in rte_eth_dev

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > lib/librte_ether/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 3c45a1f..6f5673f 100644 > --- a/lib/librte_ether/rte_et

Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > The DPAA2 bus driver is a rte_bus driver which scans the fsl-mc bus. > > Signed-off-by: Hemant Agrawal > --- > drivers/net/Makefile| 2 +- > drivers/net/dpaa2/Makefile | 60 ++ > drivers/net/dpa

Re: [dpdk-dev] [PATCH 15/32] net/dpaa2: dpio routine to affine to crypto threads

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa2/base/dpaa2_hw_dpio.c | 45 > ++ > drivers/net/dpaa2/base/dpaa2_hw_dpio.h | 3 +++ > 2 files changed, 48 insertions(+) > > diff --git a/drivers/net/dpaa2/base/dp

Re: [dpdk-dev] [PATCH 17/32] net/dpaa2: dpbp based mempool hw offload driver

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > DPBP represent a buffer pool instance in DPAA2-QBMAN > HW accelerator. > > All buffers needs to be programmed in the HW accelerator. > > Signed-off-by: Hemant Agrawal > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 5 + > drivers/net/dpaa2/Mak

Re: [dpdk-dev] [PATCH 13/32] net/dpaa2: add debug log macros

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 + > drivers/net/dpaa2/Makefile| 5 ++ > drivers/net/dpaa2/dpaa2_logs.h| 77 > +++ > 3 files changed, 84 ins

Re: [dpdk-dev] [PATCH 19/32] net/dpaa2: adding eth ops to dpaa2

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa2/base/dpaa2_hw_dpni.h | 50 + > drivers/net/dpaa2/dpaa2_ethdev.c | 130 > - > 2 files changed, 179 insertions(+), 1 deletion(-) > create mode 1

Re: [dpdk-dev] [PATCH 20/32] net/dpaa2: add queue configuration support

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/features/dpaa2.ini | 1 + > drivers/net/dpaa2/base/dpaa2_hw_dpni.h | 14 +- > drivers/net/dpaa2/base/dpaa2_hw_pvt.h | 21 +++ > drivers/net/dpaa2/dpaa2_ethdev.c | 254 >

Re: [dpdk-dev] [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > add support for dpaa2 architucture fsl-mc bus based dpaa2 pmd driver. > > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa2/Makefile | 1 + > drivers/net/dpaa2/dpaa2_bus.c| 64 > ++-- > drivers/ne

Re: [dpdk-dev] [PATCH 22/32] net/dpaa2: configure mac address at init

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa2/base/dpaa2_hw_dpni.h | 3 +++ > drivers/net/dpaa2/dpaa2_ethdev.c | 26 ++ > 2 files changed, 29 insertions(+) > > diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni

Re: [dpdk-dev] [PATCH 21/32] net/dpaa2: add rss flow distribution

2016-12-06 Thread Ferruh Yigit
On 12/4/2016 6:17 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/features/dpaa2.ini | 1 + > drivers/net/dpaa2/Makefile | 3 +- > drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 287 > + > drivers/net/dpaa2/base/dpaa

  1   2   >