[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-05 Thread Ouyang, Changchun
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Sunday, January 4, 2015 5:46 PM > To: Ouyang, Changchun; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode > > > On 01/04/15 10:58, Ouyang, Changchun wrote: > >>

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-05 Thread Ouyang, Changchun
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Sunday, January 4, 2015 5:47 PM > To: Ouyang, Changchun; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode > > > On 01/04/15 11:01, Ouyang, Changchun wrote: >

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

2015-01-05 Thread Ouyang, Changchun
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Sunday, January 4, 2015 4:39 PM > To: Ouyang, Changchun; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number > > > On 01/04/15 09:18, Ouyang Changchun wrote: > > Ge

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Gal Sagie
Hello All, I noticed that in version 1.8, there are no flags to indicate IPv6 check sum offloading (only DEV_TX_OFFLOAD_IPV4_CKSUM) which means TSO offloading is also not supported for IPv6. Are there any plans/road map to support this? Thanks Gal.

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Matthew Hall
On Jan 4, 2015, at 11:56 PM, Gal Sagie wrote: > I noticed that in version 1.8, there are no flags to indicate IPv6 check > sum offloading > (only DEV_TX_OFFLOAD_IPV4_CKSUM) > which means TSO offloading is also not supported for IPv6. I need that feature too. Right now I disabled the IP checksum o

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Olivier MATZ
Hello, On 01/05/2015 08:56 AM, Gal Sagie wrote: > I noticed that in version 1.8, there are no flags to indicate IPv6 check > sum offloading > (only DEV_TX_OFFLOAD_IPV4_CKSUM) There is no L3 checksum field in IPv6 header, that's why there is no DEV_TX_OFFLOAD_IPV6_CKSUM flag. > which means TSO of

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Thomas Monjalon
Hi Gal and Matthew, 2015-01-05 00:09, Matthew Hall: > On Jan 4, 2015, at 11:56 PM, Gal Sagie wrote: > > I noticed that in version 1.8, there are no flags to indicate IPv6 check > > sum offloading > > (only DEV_TX_OFFLOAD_IPV4_CKSUM) > > which means TSO offloading is also not supported for IPv6. >

[dpdk-dev] two tso related questions

2015-01-05 Thread Olivier MATZ
Hi, On 01/04/2015 11:13 AM, Helmut Sim wrote: > In such case, a modified api should not require to set the ip_hdr > total_length field, which is 16 bits. > The HW will assign the correct packet length for each transmitted IP > packet which is l3_len+l4_len+mss (except of the last segment which may

[dpdk-dev] Q on Support for I217 and I218 Intel chipsets.

2015-01-05 Thread Thomas Monjalon
2015-01-04 15:28, Ravi Kerur: > We have a Gigabyte H97N motherboard which has I217 Intel chipset which uses > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see > that e1000e code is integrated but missing some support for read/write from > flash_address and other minor things

[dpdk-dev] [PATCH 2/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2014-12-26 07:28, Ravi Kerur: > On Fri, Dec 26, 2014 at 6:40 AM, Neil Horman wrote: > > > On Thu, Dec 25, 2014 at 11:23:12AM -0800, Ravi Kerur wrote: > > > Thanks Neil for reviews. Inline > > > > > > On Thu, Dec 25, 2014 at 9:30 AM, Neil Horman > > wrote: > > > > > > > On Thu, Dec 25, 2014 at 1

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

2015-01-05 Thread Vlad Zolotarov
On 01/05/15 04:59, Ouyang, Changchun wrote: > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Sunday, January 4, 2015 4:39 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number >> >> >

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-05 Thread Vlad Zolotarov
On 01/05/15 03:00, Ouyang, Changchun wrote: > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Sunday, January 4, 2015 5:46 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode >> >> >

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-05 Thread Vlad Zolotarov
On 01/05/15 04:38, Ouyang, Changchun wrote: > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Sunday, January 4, 2015 5:47 PM >> To: Ouyang, Changchun; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >> >

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2015-01-05 Thread Xie, Huawei
> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Wednesday, December 10, 2014 10:36 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user > support > > > > On 2014

[dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS

2015-01-05 Thread Bruce Richardson
On Fri, Dec 26, 2014 at 01:52:25AM +, Ouyang, Changchun wrote: > > > > -Original Message- > > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > > Sent: Thursday, December 25, 2014 9:20 PM > > To: Ouyang, Changchun; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 5/6]

[dpdk-dev] [PATCH v3 0/6] Enable VF RSS for Niantic

2015-01-05 Thread Bruce Richardson
On Thu, Dec 25, 2014 at 01:46:54AM +, Ouyang, Changchun wrote: > Hi, > > > -Original Message- > > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > > Sent: Wednesday, December 24, 2014 5:59 PM > > To: Ouyang, Changchun; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3

[dpdk-dev] Query on the modified rte_mbuf structure

2015-01-05 Thread Bruce Richardson
On Tue, Dec 30, 2014 at 08:58:01AM +0200, Tapio Tallgren wrote: > Hi, > > I am not sure if I understand the question correctly, but there was a > change to the rte_mbuf structure with > patch ea672a8b1655bbb44876d2550ff56f384968a43b. It got rid of the pkt > member in rte_mbuf. Here is an example o

[dpdk-dev] [PATCH 1/2] Fix checkpatch errors in librte_acl

2015-01-05 Thread Bruce Richardson
On Thu, Dec 25, 2014 at 10:31:47AM -0500, Ravi Kerur wrote: > Fix checkpatch warnings and errors in lib/librte_acl. checkpatch > is run as follows > > scripts/checkpatch.pl --no-tree --file > > Following warnings are treated as false-positive > > 1. WARNING: quoted string split across lines > 2

[dpdk-dev] [PATCH 0/2] Fix checkpatch errors

2015-01-05 Thread Bruce Richardson
On Thu, Dec 25, 2014 at 10:31:46AM -0500, Ravi Kerur wrote: > checkpatch script is run against files in librte_acl and > librte_mempool files. No functionality change. > Changes are tested in Ubuntu and FreeBSD. > > Ravi Kerur (2): > Fix checkpatch errors in librte_acl > Fix checkpatch errors

[dpdk-dev] [PATCH 0/7] Move EAL common functions

2015-01-05 Thread Bruce Richardson
On Sun, Jan 04, 2015 at 03:10:46PM -0800, Ravi Kerur wrote: > Hi, > > I plan to work on this and would like to know if I need consider anything > else other than mentioned in the email by Olivier/Neil i.e.go with 2 > directories > > common-os/generic-os > common-posix > > under librte_eal direct

[dpdk-dev] [PATCH v3 0/6] Enable VF RSS for Niantic

2015-01-05 Thread Vlad Zolotarov
On 01/05/15 12:38, Bruce Richardson wrote: > On Thu, Dec 25, 2014 at 01:46:54AM +, Ouyang, Changchun wrote: >> Hi, >> >>> -Original Message- >>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >>> Sent: Wednesday, December 24, 2014 5:59 PM >>> To: Ouyang, Changchun; dev at

[dpdk-dev] [PATCH 5/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2014-12-25 10:33, Ravi Kerur: > +#ifdef RTE_EXEC_ENV_BSDAPP > + const unsigned ncpus = get_ncpus(); > + > + lcore_config[lcore_id].detected = (lcore_id < ncpus); > +#else /* RTE_EXEC_ENV_BSDAPP */ > + lcore_config[lcore_id].detected = cpu_detected(lcore_id); > +#

[dpdk-dev] [PATCH 6/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2014-12-25 10:33, Ravi Kerur: > +#ifdef RTE_EXEC_ENV_BSDAPP > + if (set_tsc_freq_from_sysctl() < 0) > +#else /* RTE_EXEC_ENV_BSDAPP */ > + if (set_tsc_freq_from_clock() < 0) > +#endif /* RTE_EXEC_ENV_BSDAPP */ In case there is only 1 line in ifdef, it's clearer to not comment #else and #en

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2014-12-25 10:33, Ravi Kerur: > Move common functions in eal.c to librte_eal/common directory. [...] > lib/librte_eal/common/eal_common.c| 328 > ++ > lib/librte_eal/common/eal_externs.h | 42 + I don't agree with these new files. We must try to keep a s

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2015-01-05 Thread Bruce Richardson
On Mon, Dec 22, 2014 at 05:33:07PM +, Bruce Richardson wrote: > On Mon, Dec 22, 2014 at 06:02:53PM +0100, Thomas Monjalon wrote: > > Hi Bruce, > > > > Callbacks, as hooks for applications, give more flexibility and are > > generally a good idea. > > In DPDK the main issue will be to avoid perf

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Ravi Kerur
Thanks Thomas for the reviews, do you want me to send "v4" version of this patch series or start a different patch series? Thanks, Ravi On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [..

[dpdk-dev] Q on Support for I217 and I218 Intel chipsets.

2015-01-05 Thread Ravi Kerur
Inline On Mon, Jan 5, 2015 at 12:55 AM, Thomas Monjalon wrote: > 2015-01-04 15:28, Ravi Kerur: > > We have a Gigabyte H97N motherboard which has I217 Intel chipset which > uses > > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see > > that e1000e code is integrated but mi

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Ravi Kerur
Inline On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [...] > > lib/librte_eal/common/eal_common.c| 328 > ++ > > lib/librte_eal/common/eal_externs.h

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2015-01-05 10:56, Ravi Kerur: > On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon > wrote: > > 2014-12-25 10:33, Ravi Kerur: > > > Move common functions in eal.c to librte_eal/common directory. > > [...] > > > lib/librte_eal/common/eal_common.c| 328 > > > ++ > >

[dpdk-dev] [PATCH v3 5/6] Move common functions in eal_timer.c

2015-01-05 Thread Thomas Monjalon
2014-12-30 11:37, Ravi Kerur: > Use common function name set_tsc_freq_from_sysctl for BSD and Linux. [...] > +/** > + * This function sets TSC frequency from sysctl > + * for BSD and from clock for Linux. > + * > + * This function is private to the EAL. > + */ > +int set_tsc_freq_from_sysctl(void

[dpdk-dev] [PATCH v3 6/6] Move common functions in eal_memory.c

2015-01-05 Thread Thomas Monjalon
2014-12-30 11:37, Ravi Kerur: > Use common function names rte_eal_hugepage_init and > rte_eal_hugepage_attach for BSD and Linux. I'd like to be sure that using hugepage wording instead of contigmem is not too weird for BSD people. Do not forget that we have a kernel module called contigmem. Here,

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Matthew Hall
On Mon, Jan 05, 2015 at 09:36:54AM +0100, Thomas Monjalon wrote: > Which checksum are you talking about? IPv6 checsum doesn't exist. The same computation algorithm must be reused to calculate the IPV6 Pseudoheader checksum when generating ICMPV6, UDPV6, and other L4 protocols whose definitions w

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Matthew Hall
On Mon, Jan 05, 2015 at 09:25:37PM -0800, Matthew Hall wrote: > The same computation algorithm must be reused to calculate the IPV6 > Pseudoheader checksum when generating ICMPV6, UDPV6, and other L4 protocols > whose definitions were retroactively modified to include the IPV6 > pseudoheader, th