Thanks Thomas for the reviews, do you want me to send "v4" version of this patch series or start a different patch series?
Thanks, Ravi On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [...] > > lib/librte_eal/common/eal_common.c | 328 > ++++++++++++++++++++++++++++++++++ > > lib/librte_eal/common/eal_externs.h | 42 +++++ > > I don't agree with these new files. > We must try to keep a semantic organization. The file eal_common_options.c > would be better for option-related functions. > Maybe that the split between system config, runtime config and internal > config > must be reworked. > > By the way, it would be nice to avoid extern variables. > > -- > Thomas >
