Disclaimer: I agree with Thomas's suggestions in his reply [1] to your
message, I'm replying below as well to provide more details of my own and
clarify the motivations behind this approach a bit more.
On Tue, Dec 19, 2017 at 12:44:35PM -0800, Ferruh Yigit wrote:
> On 12/19/2017 7:06 AM, Adrien Ma
19/12/2017 21:44, Ferruh Yigit:
> On 12/19/2017 7:06 AM, Adrien Mazarguil wrote:
> > On Mon, Dec 18, 2017 at 05:54:45PM -0800, Ferruh Yigit wrote:
> >> On 12/18/2017 8:46 AM, Adrien Mazarguil wrote:
> >>> As described in more details in the attached documentation (see patch
> >>> contents), this vi
On 12/19/2017 7:06 AM, Adrien Mazarguil wrote:
> On Mon, Dec 18, 2017 at 05:54:45PM -0800, Ferruh Yigit wrote:
>> On 12/18/2017 8:46 AM, Adrien Mazarguil wrote:
>>> As described in more details in the attached documentation (see patch
>>> contents), this virtual device driver manages NetVSC interfa
On Tue, 19 Dec 2017 11:01:55 +0100
Adrien Mazarguil wrote:
> > Why not use sscanf which would be safer in this case.
>
> Right, this is indeed the obvious implementation, however not only the fixed
> MAC-48 format is not the most convenient to use for user input (somewhat
> like forcing them t
On Tue, 19 Dec 2017 11:15:38 +0100
Adrien Mazarguil wrote:
> On Tue, Dec 19, 2017 at 09:53:27AM +, Bruce Richardson wrote:
> > On Mon, Dec 18, 2017 at 09:23:41PM +0100, Adrien Mazarguil wrote:
> > > On Mon, Dec 18, 2017 at 10:34:12AM -0800, Stephen Hemminger wrote:
> > > > On Mon, 18 Dec
On Mon, Dec 18, 2017 at 05:54:45PM -0800, Ferruh Yigit wrote:
> On 12/18/2017 8:46 AM, Adrien Mazarguil wrote:
> > As described in more details in the attached documentation (see patch
> > contents), this virtual device driver manages NetVSC interfaces in virtual
> > machines hosted by Hyper-V/Azur
On Tue, Dec 19, 2017 at 09:53:27AM +, Bruce Richardson wrote:
> On Mon, Dec 18, 2017 at 09:23:41PM +0100, Adrien Mazarguil wrote:
> > On Mon, Dec 18, 2017 at 10:34:12AM -0800, Stephen Hemminger wrote:
> > > On Mon, 18 Dec 2017 17:46:23 +0100
> > > Adrien Mazarguil wrote:
> > >
>
> > > > +sta
On Mon, Dec 18, 2017 at 03:59:46PM -0800, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 17:46:23 +0100
> Adrien Mazarguil wrote:
>
> > +static int
> > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str)
> > +{
> > + static const uint8_t conv[0x100] = {
> > + ['0'] = 0x
On Mon, Dec 18, 2017 at 09:23:41PM +0100, Adrien Mazarguil wrote:
> On Mon, Dec 18, 2017 at 10:34:12AM -0800, Stephen Hemminger wrote:
> > On Mon, 18 Dec 2017 17:46:23 +0100
> > Adrien Mazarguil wrote:
> >
> > > +static int
> > > +hyperv_iface_is_netvsc(const struct if_nameindex *iface)
> > > +{
Hi Keith,
On Mon, Dec 18, 2017 at 06:43:35PM +, Wiles, Keith wrote:
>
>
> > On Dec 18, 2017, at 11:59 AM, Adrien Mazarguil
> > wrote:
>
> >> Not to criticize style, but a few blank lines could help in
> >> readability for these files IMHO. Unless blank lines are illegal
> >> :-)
> >
> >
On 12/18/2017 8:46 AM, Adrien Mazarguil wrote:
> As described in more details in the attached documentation (see patch
> contents), this virtual device driver manages NetVSC interfaces in virtual
> machines hosted by Hyper-V/Azure platforms.
>
> This driver does not manage traffic nor Ethernet dev
On Mon, 18 Dec 2017 17:46:23 +0100
Adrien Mazarguil wrote:
> +static int
> +ether_addr_from_str(struct ether_addr *eth_addr, const char *str)
> +{
> + static const uint8_t conv[0x100] = {
> + ['0'] = 0x80, ['1'] = 0x81, ['2'] = 0x82, ['3'] = 0x83,
> + ['4'] = 0x84, ['5
On Mon, 18 Dec 2017 22:03:55 +0100
Thomas Monjalon wrote:
> >
> > Good question. For the following reasons:
> >
> > - I forgot about the existence of ether_ntoa() and didn't look it up seeing
> > struct ether_addr is (re-)defined by rte_ether.h. What happens when one
> > includes netinet/et
18/12/2017 21:21, Adrien Mazarguil:
> On Mon, Dec 18, 2017 at 10:26:29AM -0800, Stephen Hemminger wrote:
> > On Mon, 18 Dec 2017 17:46:23 +0100
> > Adrien Mazarguil wrote:
> >
> > > +static int
> > > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str)
> > > +{
> > > + static const
On Mon, Dec 18, 2017 at 10:34:12AM -0800, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 17:46:23 +0100
> Adrien Mazarguil wrote:
>
> >
> > /**
> > + * Destroy a hyperv context instance.
> > + *
> > + * @param ctx
> > + * Context to destroy.
> > + */
> > +static void
> > +hyperv_ctx_destroy(
On Mon, Dec 18, 2017 at 10:26:29AM -0800, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 17:46:23 +0100
> Adrien Mazarguil wrote:
>
> > +static int
> > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str)
> > +{
> > + static const uint8_t conv[0x100] = {
> > + ['0'] = 0x
> On Dec 18, 2017, at 11:59 AM, Adrien Mazarguil
> wrote:
>> Not to criticize style, but a few blank lines could help in readability for
>> these files IMHO. Unless blank lines are illegal :-)
>
> It's a matter of taste, I think people tend to add random blank lines where
> they think doing
On Mon, 18 Dec 2017 17:46:23 +0100
Adrien Mazarguil wrote:
>
> /**
> + * Destroy a hyperv context instance.
> + *
> + * @param ctx
> + * Context to destroy.
> + */
> +static void
> +hyperv_ctx_destroy(struct hyperv_ctx *ctx)
> +{
> + if (ctx->pipe[0] != -1)
> + close(ctx->pip
On Mon, 18 Dec 2017 17:46:23 +0100
Adrien Mazarguil wrote:
> +static int
> +ether_addr_from_str(struct ether_addr *eth_addr, const char *str)
> +{
> + static const uint8_t conv[0x100] = {
> + ['0'] = 0x80, ['1'] = 0x81, ['2'] = 0x82, ['3'] = 0x83,
> + ['4'] = 0x84, ['5
On Mon, Dec 18, 2017 at 05:04:23PM +, Wiles, Keith wrote:
> > On Dec 18, 2017, at 10:46 AM, Adrien Mazarguil
> > wrote:
> >
> > As described in more details in the attached documentation (see patch
> > contents), this virtual device driver manages NetVSC interfaces in virtual
> > machines ho
> On Dec 18, 2017, at 10:46 AM, Adrien Mazarguil
> wrote:
>
> As described in more details in the attached documentation (see patch
> contents), this virtual device driver manages NetVSC interfaces in virtual
> machines hosted by Hyper-V/Azure platforms.
>
> This driver does not manage traffi
21 matches
Mail list logo
