Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-15 Thread Nicholas Pratte
On Mon, May 13, 2024 at 6:06 AM Juraj Linkeš wrote: > > On Tue, May 7, 2024 at 3:00 PM Bruce Richardson > wrote: > > > > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > > > On 07/05/2024 13:05, Bruce Richardson wrote: > > > > Sorry to be late to the reviews here, but since this i

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-13 Thread Juraj Linkeš
On Tue, May 7, 2024 at 3:00 PM Bruce Richardson wrote: > > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > > On 07/05/2024 13:05, Bruce Richardson wrote: > > > Sorry to be late to the reviews here, but since this is a countable value > > > - > > > as you state in the cover letter

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-07 Thread Bruce Richardson
On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > On 07/05/2024 13:05, Bruce Richardson wrote: > > Sorry to be late to the reviews here, but since this is a countable value - > > as you state in the cover letter- would "number" or "count" not be better > > terms. To me, "quantity" is

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-07 Thread Luca Vizzarro
On 07/05/2024 13:05, Bruce Richardson wrote: Sorry to be late to the reviews here, but since this is a countable value - as you state in the cover letter- would "number" or "count" not be better terms. To me, "quantity" is just a synonym of "amount", and can be used for uncountable values too, e.

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-07 Thread Bruce Richardson
On Tue, Apr 30, 2024 at 02:45:33PM -0400, Nicholas Pratte wrote: > The term 'amount' is used for uncountable nouns. Since total hugepages > is a discrete value (i.e. countable), the declaration of the 'amount' > key value pair should be changes to a different term in both the config > and the rest

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-07 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-02 Thread Juraj Linkeš
On Tue, Apr 30, 2024 at 8:47 PM Nicholas Pratte wrote: > > The term 'amount' is used for uncountable nouns. Since total hugepages > is a discrete value (i.e. countable), the declaration of the 'amount' > key value pair should be changes to a different term in both the config > and the rest of the