Re: [PATCH v2 2/2] dts: reformat to 100 line length

2023-09-28 Thread Bruce Richardson
On Thu, Sep 28, 2023 at 09:33:55AM +0200, Juraj Linkeš wrote: > On Wed, Sep 27, 2023 at 10:08 AM Bruce Richardson > wrote: > > > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > > > Signed-off-by: Ju

Re: [PATCH v2 2/2] dts: reformat to 100 line length

2023-09-28 Thread Juraj Linkeš
On Wed, Sep 27, 2023 at 10:08 AM Bruce Richardson wrote: > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > Signed-off-by: Juraj Linkeš > > Generally for something like this we wouldn't reformat the e

Re: [PATCH v2 2/2] dts: reformat to 100 line length

2023-09-28 Thread Juraj Linkeš
Thanks, Jeremy. I skimmed the changes before submitting them, but I didn't catch this. I'll submit a new version. On Tue, Sep 26, 2023 at 11:52 PM Jeremy Spewock wrote: > > > I think this is a good idea because of all the weird places we had to > break things up with the 88 character cap. I do h

Re: [PATCH v2 2/2] dts: reformat to 100 line length

2023-09-27 Thread Bruce Richardson
On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > Reformat to 100 from the previous 88 to unify with C recommendations. > > Signed-off-by: Juraj Linkeš Generally for something like this we wouldn't reformat the existing code, because it confuses the git history e.g. for those looki

Re: [PATCH v2 2/2] dts: reformat to 100 line length

2023-09-26 Thread Jeremy Spewock
I think this is a good idea because of all the weird places we had to break things up with the 88 character cap. I do however also notice that in some cases where these multi-line strings were combined back into one line it would just have two string literals on the same line rather than them being