On Wed, Sep 27, 2023 at 10:08 AM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > > Generally for something like this we wouldn't reformat the existing code, > because it confuses the git history e.g. for those looking for "fixlines" > for bug fixes. However, given that DTS is so new in the repo, it's probably > ok and worthwhile doing. > > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Thanks for pointing this out, Bruce, I'll keep it in mind for the future. For now, it's kinda necessary we do this because our reformat tool, Black, reformats the whole codebase so I think the pros outweigh the cons. One more thing: I originally wanted to put this config part into the first patch (I wanted this patch to be only code changes) which I plan on fixing in the next version: diff --git a/dts/pyproject.toml b/dts/pyproject.toml index 6762edfa6b..980ac3c7db 100644 --- a/dts/pyproject.toml +++ b/dts/pyproject.toml @@ -41,7 +41,7 @@ build-backend = "poetry.core.masonry.api" [tool.pylama] linters = "mccabe,pycodestyle,pyflakes" format = "pylint" -max_line_length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length +max_line_length = 100 [tool.mypy] python_version = "3.10" @@ -55,4 +55,4 @@ profile = "black" [tool.black] target-version = ['py310'] include = '\.pyi?$' -line-length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length +line-length <https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length+line-length> = 100
