On Thu, Sep 28, 2023 at 09:33:55AM +0200, Juraj Linkeš wrote: > On Wed, Sep 27, 2023 at 10:08 AM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > > > > Generally for something like this we wouldn't reformat the existing code, > > because it confuses the git history e.g. for those looking for "fixlines" > > for bug fixes. However, given that DTS is so new in the repo, it's probably > > ok and worthwhile doing. > > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > > Thanks for pointing this out, Bruce, I'll keep it in mind for the > future. For now, it's kinda necessary we do this because our reformat > tool, Black, reformats the whole codebase so I think the pros outweigh > the cons. > Agreed
- [PATCH v2 1/2] doc: increase python max line length to 1... Juraj Linkeš
- [PATCH v2 2/2] dts: reformat to 100 line length Juraj Linkeš
- Re: [PATCH v2 2/2] dts: reformat to 100 line le... Jeremy Spewock
- Re: [PATCH v2 2/2] dts: reformat to 100 lin... Juraj Linkeš
- Re: [PATCH v2 2/2] dts: reformat to 100 line le... Bruce Richardson
- Re: [PATCH v2 2/2] dts: reformat to 100 lin... Juraj Linkeš
- Re: [PATCH v2 2/2] dts: reformat to 100... Bruce Richardson
- Re: [PATCH v2 1/2] doc: increase python max line le... Bruce Richardson
- [PATCH v3 1/2] doc: increase python max line length... Juraj Linkeš
- [PATCH v3 2/2] dts: reformat to 100 line length Juraj Linkeš
- Re: [PATCH v3 2/2] dts: reformat to 100 lin... Jeremy Spewock
- [PATCH v4 1/2] doc: increase python max lin... Juraj Linkeš
- [PATCH v4 2/2] dts: reformat to 100 lin... Juraj Linkeš
- [PATCH v5 1/2] doc: increase pytho... Juraj Linkeš
- [PATCH v5 2/2] dts: reformat t... Juraj Linkeš
- Re: [PATCH v4 1/2] doc: increase python... Stephen Hemminger
- Re: [PATCH v4 1/2] doc: increase p... Juraj Linkeš