Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-22 Thread Thomas Monjalon
22/11/2023 10:37, fengchengwen: > On 2023/11/22 16:28, Robin Jarry wrote: > > Stephen Hemminger, Nov 21, 2023 at 18:27: > >> On Tue, 21 Nov 2023 22:51:19 +0530 > >> Jerin Jacob wrote: > >> > IMO, That may be too much of non-productive work to save a couple of > >> > lines(seed array) of duplicate

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-22 Thread fengchengwen
On 2023/11/22 16:28, Robin Jarry wrote: > Stephen Hemminger, Nov 21, 2023 at 18:27: >> On Tue, 21 Nov 2023 22:51:19 +0530 >> Jerin Jacob wrote: >> > IMO, That may be too much of non-productive work to save a couple of >> > lines(seed array) of duplicate code between c and python. >> >> But the too

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-22 Thread Robin Jarry
Stephen Hemminger, Nov 21, 2023 at 18:27: On Tue, 21 Nov 2023 22:51:19 +0530 Jerin Jacob wrote: > IMO, That may be too much of non-productive work to save a couple of > lines(seed array) of duplicate code between c and python. But the tool is incomplete right now, it doesn't cover all the drive

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Stephen Hemminger
On Tue, 21 Nov 2023 22:51:19 +0530 Jerin Jacob wrote: > On Tue, Nov 21, 2023 at 10:34 PM Stephen Hemminger > wrote: > > > > On Tue, 21 Nov 2023 22:21:54 +0530 > > Jerin Jacob wrote: > > > > > > The tool should not need to have driver specific tables like this. > > > > DPDK is already riddled

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Jerin Jacob
On Tue, Nov 21, 2023 at 10:34 PM Stephen Hemminger wrote: > > On Tue, 21 Nov 2023 22:21:54 +0530 > Jerin Jacob wrote: > > > > The tool should not need to have driver specific tables like this. > > > DPDK is already riddled with enough driver specific quirks.. > > > > > > That shows a flaw in the

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Stephen Hemminger
On Tue, 21 Nov 2023 22:21:54 +0530 Jerin Jacob wrote: > > The tool should not need to have driver specific tables like this. > > DPDK is already riddled with enough driver specific quirks.. > > > > That shows a flaw in the rss design, which should have been fixed. > > Every NIC's implements st

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Jerin Jacob
On Tue, Nov 21, 2023 at 10:08 PM Stephen Hemminger wrote: > > On Mon, 23 Oct 2023 10:07:11 +0200 > Robin Jarry wrote: > > > +class DriverInfo: > > +def __init__(self, key: bytes = None, reta_size: int = None): > > +self.__key = key > > +self.__reta_size = reta_size > > + > > +

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Thomas Monjalon
21/11/2023 17:38, Stephen Hemminger: > The tool should not need to have driver specific tables like this. > DPDK is already riddled with enough driver specific quirks.. > > That shows a flaw in the rss design, which should have been fixed. > I should have seen this in the earlier versions, would h

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-21 Thread Stephen Hemminger
On Mon, 23 Oct 2023 10:07:11 +0200 Robin Jarry wrote: > +class DriverInfo: > +def __init__(self, key: bytes = None, reta_size: int = None): > +self.__key = key > +self.__reta_size = reta_size > + > +def rss_key(self) -> bytes: > +return self.__key > + > +def re

RE: [EXT] Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-20 Thread Sunil Kumar Kori
[EXT] Re: [PATCH 1/2] usertools/rss: add driver abstractions > > External Email > > -- > Hi, Jerin, Sunil Komar, > > Could you have a look at this series and report if it brings the needed > abstractions for integrating CNXK? > > Thanks!

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-20 Thread Robin Jarry
Hi, Jerin, Sunil Komar, Could you have a look at this series and report if it brings the needed abstractions for integrating CNXK? Thanks!