On Tue, 21 Nov 2023 22:51:19 +0530 Jerin Jacob <jerinjac...@gmail.com> wrote:
> On Tue, Nov 21, 2023 at 10:34 PM Stephen Hemminger > <step...@networkplumber.org> wrote: > > > > On Tue, 21 Nov 2023 22:21:54 +0530 > > Jerin Jacob <jerinjac...@gmail.com> wrote: > > > > > > The tool should not need to have driver specific tables like this. > > > > DPDK is already riddled with enough driver specific quirks.. > > > > > > > > That shows a flaw in the rss design, which should have been fixed. > > > > > > Every NIC's implements standard Toeplitz hash algorithm for RSS hash > > > generation. > > > Only the initial SEED is different. It is not DPDK property, all the > > > HW like is that as > > > there is no standardization on initial SEED for hash. > > > > The tool should be able to query the default key from driver, or the > > build infrastructure should extract and generate the table. > > IMO, That may be too much of non-productive work to save a couple of > lines(seed array) of duplicate code between c and python. But the tool is incomplete right now, it doesn't cover all the drivers.
