22/11/2023 10:37, fengchengwen: > On 2023/11/22 16:28, Robin Jarry wrote: > > Stephen Hemminger, Nov 21, 2023 at 18:27: > >> On Tue, 21 Nov 2023 22:51:19 +0530 > >> Jerin Jacob <jerinjac...@gmail.com> wrote: > >> > IMO, That may be too much of non-productive work to save a couple of > >> > lines(seed array) of duplicate code between c and python. > >> > >> But the tool is incomplete right now, it doesn't cover all the drivers. > > > > I agree that having a standard API or mechanism for drivers to expose their > > default redirection table size and hash seed key would be nice. The script > > could have a dynamically generated section that is populated during the > > build based on selected drivers. > > > > However, it would make the python script dependant on it and it would not > > be a standalone tool anymore. This is not a blocking issue but something to > > keep in mind. > > The usertools/dpdk-pmdinfo.py will parse dpdk elf to get some information, We > could do same thing in here.
We can imagine different things to avoid listing few RSS keys in this script. For now, this series is an improvement, so I take it. Feel free to follow-up with more enhancements.
