Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 17:50, Andrew Rybchenko 写道: Hi Huisong, On 7/5/21 9:07 AM, Thomas Monjalon wrote: 05/07/2021 05:18, Huisong Li: 在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 19:22, Ananyev, Konstantin 写道: On 7/5/21 6:03 AM, Huisong Li wrote: 在 2021/7/3 19:04, Ananyev, Konstantin 写道: 在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Ananyev, Konstantin
> On 7/5/21 6:03 AM, Huisong Li wrote: > > > > 在 2021/7/3 19:04, Ananyev, Konstantin 写道: > >>> 在 2021/7/2 21:23, Ananyev, Konstantin 写道: > > On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > >> @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > >> but I need your opinion

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Andrew Rybchenko
Hi Huisong, On 7/5/21 9:07 AM, Thomas Monjalon wrote: > 05/07/2021 05:18, Huisong Li: >> 在 2021/7/5 4:05, Thomas Monjalon 写道: >>> 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch add

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Andrew Rybchenko
On 7/5/21 6:03 AM, Huisong Li wrote: > > 在 2021/7/3 19:04, Ananyev, Konstantin 写道: >>> 在 2021/7/2 21:23, Ananyev, Konstantin 写道: > On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: >> @Thomas, @Ferruh, I tend to accept it (with minor style fixes), >> but I need your opinion on it before do

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Thomas Monjalon
05/07/2021 05:18, Huisong Li: > 在 2021/7/5 4:05, Thomas Monjalon 写道: > > 08/05/2021 10:00, Huisong Li: > >> Currently, if dev_configure is not invoked or fails to be invoked, users > >> can still invoke dev_start successfully. This patch adds a "dev_configured" > >> flag in "rte_eth_dev_data" to co

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch adds a "dev_configured" flag in "rte_eth_dev_data" to control whether dev_start can be invoked. [...]

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
在 2021/7/3 19:04, Ananyev, Konstantin 写道: 在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. I guess we were relying on the user/application to

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Thomas Monjalon
08/05/2021 10:00, Huisong Li: > Currently, if dev_configure is not invoked or fails to be invoked, users > can still invoke dev_start successfully. This patch adds a "dev_configured" > flag in "rte_eth_dev_data" to control whether dev_start can be invoked. [...] > --- a/lib/ethdev/rte_ethdev_core.h

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-03 Thread Ananyev, Konstantin
> > 在 2021/7/2 21:23, Ananyev, Konstantin 写道: > > > >> On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > >>> @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > >>> but I need your opinion on it before doing it. > >>> > >> I guess we were relying on the user/application to have correct

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-03 Thread Huisong Li
在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. I guess we were relying on the user/application to have correct order up until now, it can

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Ananyev, Konstantin
> > On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > > @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > > but I need your opinion on it before doing it. > > > > I guess we were relying on the user/application to have correct order up until > now, it can be good to add this into

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Ferruh Yigit
On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > but I need your opinion on it before doing it. > I guess we were relying on the user/application to have correct order up until now, it can be good to add this into the API. OK to add

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Andrew Rybchenko
@Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. Thanks, Andrew. On 6/29/21 5:27 AM, Huisong Li wrote: > > 在 2021/6/14 23:37, Andrew Rybchenko 写道: >> Summary should start from "ethdev: " >> >> Don't forget to include all maintainers i

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-06-28 Thread Huisong Li
在 2021/6/14 23:37, Andrew Rybchenko 写道: Summary should start from "ethdev: " Don't forget to include all maintainers in Cc the next time. Just use --cc-cmd or --to-cmd options. ok, thanks! Adding Thomas. On 5/8/21 11:00 AM, Huisong Li wrote: Currently, if dev_configure is not invoked or f

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-06-14 Thread Andrew Rybchenko
Summary should start from "ethdev: " Don't forget to include all maintainers in Cc the next time. Just use --cc-cmd or --to-cmd options. Adding Thomas. On 5/8/21 11:00 AM, Huisong Li wrote: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start succ

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-05-31 Thread Huisong Li
Hi, All & Ferruh What do you think about this patch? 在 2021/5/8 16:00, Huisong Li 写道: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch adds a "dev_configured" flag in "rte_eth_dev_data" to control whether dev_start can

[dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-05-08 Thread Huisong Li
Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch adds a "dev_configured" flag in "rte_eth_dev_data" to control whether dev_start can be invoked. Signed-off-by: Huisong Li --- lib/ethdev/rte_ethdev.c | 11 +++