Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Suanming . Mou
Hi, Thanks for the advises from you all. The latest v7 patch has sent out. Br, Mou On 2019/5/2 17:54, Pattan, Reshma wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou static void +monitor_primary(void *arg __rte_unused) { + if

Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou > static void > +monitor_primary(void *arg __rte_unused) { > + if (quit_signal) > + return; > + > + if (rte_eal_primary_proc_alive(NULL)) > + rte_eal_alarm_set(MO

Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Varghese, Vipin
HI Suanming, snipped > >> /* true if x is a power of 2 */ > >> #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ > >> struct > > Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? > > I'm sorry, but that line is not add by this patch this time. > > Maybe another commit

Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Burakov, Anatoly
On 02-May-19 9:32 AM, Suanming.Mou wrote: On 2019/5/2 16:04, Varghese, Vipin wrote: Hi Suanming, snipped   /* true if x is a power of 2 */   #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? I'm sorry, but tha

Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Suanming . Mou
On 2019/5/2 16:04, Varghese, Vipin wrote: Hi Suanming, snipped /* true if x is a power of 2 */ #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? I'm sorry, but that line is not add by this patch this time.

Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Varghese, Vipin
Hi Suanming, snipped > > /* true if x is a power of 2 */ > #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? > parse_val { } > > static void > +monitor_primary(void *arg __rte_unused) { > + if (quit_signal

[dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-01 Thread Suanming . Mou
When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Signed-off-by: Suanming.Mou --- Change in V6: - remove "Suggested-by" tags and head line '.' in git log. - adjust the rte_alarm.h head file position. - add comment