Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
On 3/26/2019 12:06 PM, Stephen Hemminger wrote: On Mon, 25 Mar 2019 23:02:34 -0700 Anand Rawat wrote: +/*- + * SPDX-License-Identifier: BSD-3-Clause + * + * Copyright (c) 1991, 1993 + * The Regents of the University of California. All rights reserved. + * + * Redistribution and use in sou

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Thomas Monjalon
27/03/2019 00:43, Jeff Shaw: > On Wed, Mar 27, 2019 at 12:00:49AM +0100, Thomas Monjalon wrote: > > 26/03/2019 23:34, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 22:54, Jeff Shaw: > > > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Mon

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Wed, Mar 27, 2019 at 12:00:49AM +0100, Thomas Monjalon wrote: > 26/03/2019 23:34, Jeff Shaw: > > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:54, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > > > 26/03/2019 22:14

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Thomas Monjalon
26/03/2019 23:34, Jeff Shaw: > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:54, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 22:14, Jeff Shaw: > > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Mon

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:54, Jeff Shaw: > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:14, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > > Even better woul

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Thomas Monjalon
26/03/2019 22:54, Jeff Shaw: > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:14, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > Even better would be to get it as a dependency outside of DPDK. > > > > Where this code com

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:14, Jeff Shaw: > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > Even better would be to get it as a dependency outside of DPDK. > > > Where this code come from? > > > How other projects on Win

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Thomas Monjalon
26/03/2019 22:14, Jeff Shaw: > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > Even better would be to get it as a dependency outside of DPDK. > > Where this code come from? > > How other projects on Windows get it? > > It comes from FreeBSD 12.0, specifically > https://gith

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Reg

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Thomas Monjalon
26/03/2019 20:06, Stephen Hemminger: > On Mon, 25 Mar 2019 23:02:34 -0700 > Anand Rawat wrote: > > > +/*- > > + * SPDX-License-Identifier: BSD-3-Clause > > + * > > + * Copyright (c) 1991, 1993 > > + * The Regents of the University of California. All rights reserved. > > + * > > + * Redistributio

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Stephen Hemminger
On Mon, 25 Mar 2019 23:02:34 -0700 Anand Rawat wrote: > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1991, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without >

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Harini Ramakrishnan
v5 4/8] eal: sys/queue.h implementation for windows Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Acked-by: Harini Ramakrishnan --- .../windows/eal

[dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-25 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(