On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat <anand.ra...@intel.com> wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Regents of the University of California. All rights > > > reserved. > > > + * > > > + * Redistribution and use in source and binary forms, with or without > > > + * modification, are permitted provided that the following conditions > > > + * are met: > > > + * 1. Redistributions of source code must retain the above copyright > > > + * notice, this list of conditions and the following disclaimer. > > > + * 2. Redistributions in binary form must reproduce the above copyright > > > + * notice, this list of conditions and the following disclaimer in the > > > + * documentation and/or other materials provided with the > > > distribution. > > > + * 3. Neither the name of the University nor the names of its > > > contributors > > > + * may be used to endorse or promote products derived from this > > > software > > > + * without specific prior written permission. > > > + * > > > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' > > > AND > > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR > > > PURPOSE > > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE > > > LIABLE > > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > > > CONSEQUENTIAL > > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE > > > GOODS > > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > > > STRICT > > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY > > > WAY > > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > > > + * SUCH DAMAGE. > > > + * > > > > If you have SPDX license identifier then the text boilerplate is unnecessary > > and not desired.
I think we'd still need the Copyright statement there, right? > > Even better would be to get it as a dependency outside of DPDK. > Where this code come from? > How other projects on Windows get it? > It comes from FreeBSD 12.0, specifically https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h It has been modified such that only the parts used by DPDK (i.e. TAILQ) are implemented. The other stuff has been deleted. Windows does not have sys/queue.h, so we reproduce it here. Would it better to have this as a dependency outside of DPDK? I think pulling a file from the internet and applying a patch (where we'd have to maintain a patch file inside of DPDK's repo anyway) would be overkill when we just need a few lines of code that will change very infrequently.
