Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-09 Thread Thomas Monjalon
2017-03-09 10:49, Billy McFall: > On Tue, Mar 7, 2017 at 11:03 AM, Thomas Monjalon > wrote: > > 2017-03-07 09:29, Billy McFall: > > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon < > > thomas.monja...@6wind.com> > > > wrote: > > > > I think you could use rte_errno (while keeping negative retur

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-09 Thread Billy McFall
On Tue, Mar 7, 2017 at 11:03 AM, Thomas Monjalon wrote: > 2017-03-07 09:29, Billy McFall: > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon < > thomas.monja...@6wind.com> > > wrote: > > > I think you could use rte_errno (while keeping negative return codes). > > > > > > > I can do that if you

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy McFall > Sent: Friday, January 27, 2017 6:38 PM > To: thomas.monja...@6wind.com; Lu, Wenzhuo ; > olivier.m...@6wind.com > Cc: dev@dpdk.org; Billy McFall > Subject: [dpdk-dev] [PATCH v5

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy McFall > Sent: Tuesday, March 7, 2017 2:30 PM > To: Thomas Monjalon > Cc: Lu, Wenzhuo ; olivier.m...@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Thomas Monjalon
2017-03-07 09:29, Billy McFall: > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon > wrote: > > I think you could use rte_errno (while keeping negative return codes). > > > > I can do that if you want, but if I understand your comment, it will make > the implementation of the function not as clea

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Billy McFall
Thomas, Thanks for your comments. See inline. On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon wrote: > 2017-01-27 13:37, Billy McFall: > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > @@ -55,6 +55,7 @@ FW version = > > EEPROM dump

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-02-27 Thread Thomas Monjalon
2017-01-27 13:37, Billy McFall: > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -55,6 +55,7 @@ FW version = > EEPROM dump = > Registers dump = > Multiprocess aware = > +Free TX ring buffers = I'm afraid this wording will

[dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-01-27 Thread Billy McFall
Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Signed-off-by: Billy McFall --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/mempool_lib