Thomas, Thanks for your comments. See inline.
On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon <thomas.monja...@6wind.com> wrote: > 2017-01-27 13:37, Billy McFall: > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > @@ -55,6 +55,7 @@ FW version = > > EEPROM dump = > > Registers dump = > > Multiprocess aware = > > +Free TX ring buffers = > > I'm afraid this wording will be confusing, because every drivers > free their buffers :) > What about "Free Tx mbuf on demand" ? > > I definitely like your wording of the feature better than mine. All the existing features were under 20 characters and I was trying to stay under that. > And please, move this line upper, just after "Rx interrupt". > > Done > We also need to carefully review the doc you provided (thanks). > First quick comment, please wrap lines shorter in the doc. > > Done > About the function prototype, I've seen a double space :) > Done > I think you could use rte_errno (while keeping negative return codes). > I can do that if you want, but if I understand your comment, it will make the implementation of the function not as clean. I cannot use the existing RTE_ETH_VALID_PORTID_OR_ERR_RET(..) and RTE_FUNC_PTR_OR_ERR_RET(..) MACROs because they are handling the return on error. Or am I missing something?
