> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy McFall > Sent: Friday, January 27, 2017 6:38 PM > To: thomas.monja...@6wind.com; Lu, Wenzhuo <wenzhuo...@intel.com>; > olivier.m...@6wind.com > Cc: dev@dpdk.org; Billy McFall <bmcf...@redhat.com> > Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed > buffers in Tx ring >
Hi Billy, Thanks for this. Some minor comments below. > > > +Driver Cache > +~~~~~~~~~~~~ I think this could be at the same level as the "Local Cache" earlier in the doc. > + > +In addition to the a core’s local cache, many of the drivers don't The apostrophe after core is non-ascii. That can mess with the PDF output. > +release the mbuf back to the mempool, or local cache, immediately after > the packet has been transmitted. > +Instead, they leave the mbuf in their txRing and either perform a bulk I'd suggest s/txRing/Tx ring/ here and below. > +release when the tx_rs_thresh has been crossed or free the mbuf when a You should fixed width quote ``tx_rs_thresh`` here and below. > slot in the txRing is needed. > + > +An application can request the driver to release used mbufs with the > ``rte_eth_tx_done_cleanup()`` API. > +This API requests the driver to release mbufs that are no longer in > +use, independent of whether or not the tx_rs_thresh has been crossed. > +There are two scenarios when an application may want the mbuf back > immediately: s/back/released/ maybe? > + > +* When a given packet needs to be sent to multiple destination interfaces > (either for Layer 2 flooding or Layer 3 multi-cast). > + One option is to make a copy of the packet or a copy of the header > portion that needs to manipulated. s/to/to be/ John
