Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-26 Thread Varghese, Vipin
Hi, > Hi Vipin, > > > > > Hi Konstantin, > > > > > > > > > > If the operator is '|' what else except of 'OR' you expect it to be > > > > remapped? > > > > Thanks for your correction. I have rerun with logical or > > > > if ((ret) || (!is_leaf)) > >9a512: 83 bd 3

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-26 Thread Ananyev, Konstantin
Hi Vipin, > > Hi Konstantin, > > > > > > > If the operator is '|' what else except of 'OR' you expect it to be > > > remapped? > > Thanks for your correction. I have rerun with logical or > > if ((ret) || (!is_leaf)) >9a512: 83 bd 3c fd ff ff 00cmpD

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-26 Thread Varghese, Vipin
Hi Konstantin, > > > > If the operator is '|' what else except of 'OR' you expect it to be > > remapped? Thanks for your correction. I have rerun with logical or if ((ret) || (!is_leaf)) 9a512: 83 bd 3c fd ff ff 00cmpDWORD PTR [rbp-0x2c4],0x0 9a519:

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-26 Thread Ananyev, Konstantin
Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Varghese, Vipin > > Sent: Monday, No

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-26 Thread Ananyev, Konstantin
Michael J > ; Patel, Amol > Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm > > Hi Stephen, > > snipped > > > > > > > > > > > > > > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-25 Thread Varghese, Vipin
Hi Stephen, snipped > > > > > > > > > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > > > + > > > > > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Check is done

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Stephen Hemminger
On Fri, 23 Nov 2018 15:05:07 + "Varghese, Vipin" wrote: > > > > > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > > + > > > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > + > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > > > > Check is done for 'if either ret is not 0 or if it ret is 0 > > > > > > but

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 1:56 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> -Original Message- > From: Pattan, Reshma > Sent: Friday, November 23, 2018 7:04 PM > To: Varghese, Vipin ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 1:29 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> -Original Message- > From: Pattan, Reshma > Sent: Friday, November 23, 2018 5:21 PM > To: Varghese, Vipin ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/proc

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, November 22, 2018 1:28 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/p

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-22 Thread Varghese, Vipin
Hi Reshma, > > > + if ((ret) | (!is_leaf)) > > + > > Is the operator here should be || ? > > Check is done for 'if either ret is not 0 or if it ret is 0 but not leaf' we skip leaf details print. If 'ret is 0 and is leaf' we skip continue to print leaf details.

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-21 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, November 6, 2018 12:49 PM > To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma > ; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol ; Varghese, > Vipin > Subject: [PATC

[dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-06 Thread Vipin Varghese
Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis

[dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-05 Thread Vipin Varghese
Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis