[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-21 Thread Thomas Monjalon
2016-04-21 11:00, Bruce Richardson: > On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > > It's not for testing, more for code review and to help understand the code > > > [though > > > as you say, we do need to ensure that each commit doesn't actually break > > > the > > > build]. >

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-21 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > It's not for testing, more for code review and to help understand the code > > [though > > as you say, we do need to ensure that each commit doesn't actually break > > the > > build]. > > Right now, the driver code goes in as a singl

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-20 Thread Stephen Hurd
> It's not for testing, more for code review and to help understand the code > [though > as you say, we do need to ensure that each commit doesn't actually break > the > build]. > Right now, the driver code goes in as a single commit - which makes it a > hard > enough task to review and see what is

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-20 Thread Bruce Richardson
On Tue, Apr 19, 2016 at 01:51:32PM -0700, Stephen Hurd wrote: > On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > > > T

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-19 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput > http://www.broadcom.com/press/release.php?id=s923886 > > Signed-off-by: Stephen Hurd > --- > v

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-19 Thread Stephen Hurd
On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > This seems a single huge commit. Can this be split up into separate commits >

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-04 Thread Stephen Hurd
On Fri, Mar 4, 2016 at 3:02 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > > > New driver for Broadcom bnxt (NexXtreme C-series) devices.> > > Looks good, I just have a couple of functionality comments. > > 1. Driver does not appear to support Link State interrupt. Not a big >

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-04 Thread Stephen Hemminger
On Fri, 4 Mar 2016 13:05:24 -0800 Stephen Hurd wrote: > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput > http://www.broadcom.com/press/release.php?id=s923886 > > Signed-off-by: Stephen Hurd > --- > v3: >

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-04 Thread Stephen Hurd
New driver for Broadcom bnxt (NexXtreme C-series) devices. Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput http://www.broadcom.com/press/release.php?id=s923886 Signed-off-by: Stephen Hurd --- v3: * Fix incorrect format specifier compilation error on i686 (PRIx64 instea