2016-04-21 11:00, Bruce Richardson: > On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > > It's not for testing, more for code review and to help understand the code > > > [though > > > as you say, we do need to ensure that each commit doesn't actually break > > > the > > > build]. > > > Right now, the driver code goes in as a single commit - which makes it a > > > hard > > > enough task to review and see what is in there. One suggestion that > > > hopefully > > > wouldn't be too much work might be to split the code up into: basic device > > > init code, RX and TX functions, and then any additional features based on > > > top > > > of that [ideally one patch per added feature]. > > > > > > > The current driver doesn't have much beyond basic TX/RX, but we can give it > > a shot. "Too much work" is relative of course, but splitting it into > > self-contained easily understood chunks will absolutely be a lot of work. > > > > Adding Ajit who will also be working on this. Since he's coming up to > > speed on the driver code, this could be a good way for him to fully > > familiarize himself with it. > > > Sure, thanks. Any splitting you can do at all would be appreciated and help > with > reviews.
I'd add that it helps newcomers to understand the driver by reading the git history. Thanks
