Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Thu, Apr 2, 2020 at 1:13 AM Thomas Monjalon wrote: > > 01/04/2020 21:14, Jerin Jacob: > > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > > wrote: > > > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob > > > > wrote: > >

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Thomas Monjalon
01/04/2020 21:14, Jerin Jacob: > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > wrote: > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > > > wrote: > > > > > On

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > wrote: > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > > wrote: > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob > > >

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 11:02 PM David Marchand wrote: > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > wrote: > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > > I assume the patch content will be: > > > > 1) Removing expe

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread David Marchand
On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > wrote: > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > I assume the patch content will be: > > > 1) Removing experimental API from app, lib, drivers, examples with > > > make and mes

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 10:16 PM Bruce Richardson wrote: > > > > > > > > Since the trace changes in the "inline" functions of the specific > > > > library already > > > > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and > > > > it is using RTE_TRACE_POINT_DP() to define the trace unlike

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Bruce Richardson
On Wed, Apr 01, 2020 at 09:55:20PM +0530, Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > wrote: > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > > wrote: > > > > - Regardless of the trace framework, the ALL

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 7:42 PM David Marchand wrote: > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > wrote: > > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > > gates access to APIs so that external users a

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Thomas Monjalon
01/04/2020 16:12, David Marchand: > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > wrote: > > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > > gates access to APIs so that external users are aware of their stat

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread David Marchand
On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > wrote: > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > gates access to APIs so that external users are aware of their status. > > I have been considering setting this

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 1:49 PM David Marchand wrote: > > Hello Jerin, Hello David, Thanks for the review. > > On Sun, Mar 29, 2020 at 4:43 PM wrote: > > Items that needs to be sort it out > > ~~ > > # Makefile and meson.build are updated to allow experimental AP

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread David Marchand
Hello Jerin, On Sun, Mar 29, 2020 at 4:43 PM wrote: > Items that needs to be sort it out > ~~ > # Makefile and meson.build are updated to allow experimental APIs. > > As multiple EXPERIMENTAL symbols, exported by trace library, are > used in various drivers, lib, a

[dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-03-29 Thread jerinj
From: Jerin Jacob v3: ~~ 1) Fix the following build issues reported by CI http://mails.dpdk.org/archives/test-report/2020-March/122060.html a) clang + i686 meson build issue(Fixed in the the patch meson: add libatomic as a global dependency for i686 clang) b) fixed build issue with FreeBSD wi