On Wed, Apr 1, 2020 at 10:16 PM Bruce Richardson <bruce.richard...@intel.com> wrote:
> > > > > > > > Since the trace changes in the "inline" functions of the specific > > > > library already > > > > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and > > > > it is using RTE_TRACE_POINT_DP() to define the trace unlike slow path > > > > trace like RTE_TRACE_POINT(). > > > > > > Ah indeed. > > > Note: RTE_ENABLE_TRACE_DP is not plugged with meson. > > > > If you see the " eal: define the public API for trace support" patch, > > I have updated rte_config.h for meson likewise for other configuration > > such log for DP. > > Would you like to have a meson option? and update in meson_options.txt. > > > > I don't have a strong opinion on either way? Bruce ,any thoughts? > > > Since it's likely that developers will be wanting to switch this option on > and off, I think an explicit option rather than hard-coded constant should > be the way to go. OK. I will add an explicit option in the next version. > > However, an alternative might be to add in the DP tracing for debug builds > but not for others. This would save a build option, but may be more > restrictive, since debug builds can also be optimized ones. I think it will be restrictive. > > /Bruce
