Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Akhil Goyal
On 9/18/2018 6:10 PM, jos...@dpdk.org wrote: Hi Akhil, On 18-09-2018 18:01, Akhil Goyal wrote: External Email Hi Anoob, On 9/17/2018 7:43 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Joseph
Hi Akhil, On 18-09-2018 18:01, Akhil Goyal wrote: > External Email > > Hi Anoob, > > On 9/17/2018 7:43 PM, Joseph, Anoob wrote: >> Hi Akhil, >> >> >> On 17-09-2018 17:50, Akhil Goyal wrote: >>> External Email >>> >>> On 9/17/2018 5:12 PM, Joseph, Anoob wrote: >>> Hi Akhil, On 17-09-2018

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Akhil Goyal
Hi Anoob, On 9/17/2018 7:43 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related chan

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Thomas, On 17-09-2018 20:06, Thomas Monjalon wrote: External Email 17/09/2018 16:13, Joseph, Anoob: On 17-09-2018 17:50, Akhil Goyal wrote: On 9/17/2018 5:12 PM, Joseph, Anoob wrote: On 17-09-2018 16:07, Akhil Goyal wrote: I think it would be better to squash the makefile related change

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Thomas Monjalon
17/09/2018 16:13, Joseph, Anoob: > On 17-09-2018 17:50, Akhil Goyal wrote: > > On 9/17/2018 5:12 PM, Joseph, Anoob wrote: > >> On 17-09-2018 16:07, Akhil Goyal wrote: > > I think it would be better to squash the makefile related changes in > > the 3/33 patch as the code > > is actually

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Akhil Goyal
On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in that and here the code is not getting compiled here. So the change

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in that and here the code is not getting compiled here. So the changes in the following files has to be moved t

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Akhil Goyal
I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in that and here the code is not getting compiled here. So the changes in the following files has to be moved to patch 3/33?   drivers/crypto/Makefile   drivers/crypto/meson.

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-16 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 14-09-2018 17:41, Akhil Goyal wrote: External Email Hi Anoob, On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-14 Thread Akhil Goyal
Hi Anoob, On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim responsibility. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR

[dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim responsibility. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragot