Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Stephen Hemminger
On Tue, 13 Mar 2018 01:51:34 +0530 Vipin Varghese wrote: > +static int parse_user_mac(struct ether_addr *user_mac, > + const char *value) > +{ > + unsigned int index = 0; > + char mac_temp[strlen(ETH_TAP_USR_MAC_FMT) + 1], *mac_byte = NULL; > + > + if (user_mac == NULL ||

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Varghese, Vipin
Sure Ferruh, I will spin a new one. > -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 12, 2018 8:39 PM > To: Varghese, Vipin ; dev@dpdk.org; > pascal.ma...@6wind.com > Subject: Re: [PATCH v2] net/tap: allow user MAC to be passed as args > > On 3/12/2018 8:21 PM, Vipin Vargh

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 8:21 PM, Vipin Varghese wrote: > @@ -1591,7 +1632,7 @@ enum ioctl_mode { > int speed; > char tap_name[RTE_ETH_NAME_MAX_LEN]; > char remote_iface[RTE_ETH_NAME_MAX_LEN]; > - int fixed_mac_type = 0; > + struct ether_addr user_mac = { .addr_bytes = {0, 0, 0, 0, 0,

[dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string delimited by ':', is parsed and converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Acked-by: Pascal Mazon --- Changes in V2: - updated the auto variable for user_mac

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-02-05 Thread Ferruh Yigit
On 2/5/2018 3:54 PM, Pascal Mazon wrote: > From: Vipin Varghese > > Allow TAP PMD to pass user desired MAC address as argument. > The argument value is processed as string, where each 2 bytes > are converted to HEX MAC address after validation. > > Signed-off-by: Vipin Varghese > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-02-05 Thread Varghese, Vipin
[dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as > args > > Hi Pascal, > > Thanks for the update, I see your point instead of mixing up with int32_t and > uint64_t; converting to ' struct ether_addr' makes sense. > > I will check internally and th

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-02-05 Thread Varghese, Vipin
Hi Pascal, Thanks for the update, I see your point instead of mixing up with int32_t and uint64_t; converting to ' struct ether_addr' makes sense. I will check internally and thanks once again for the suggestion. Thanks Vipin Varghese > -Original Message- > From: Pascal Mazon [mailto:p

[dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-02-05 Thread Pascal Mazon
From: Vipin Varghese Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string, where each 2 bytes are converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Signed-off-by: Pascal Mazon --- Hi Vipin, I suggest the following pa

Re: [dpdk-dev] [PATCH v2] net/tap: allow user mac to be passed as args

2018-01-16 Thread Ferruh Yigit
On 12/21/2017 4:01 PM, Vipin Varghese wrote: > Added fixes for user TAP user MAC > 1) user format to RTE_PMD_REGISTER_PARAM_STRING > 2) TAP to the RTE_LOG in absence of dynamic RTE_LOG > 3) Boundary case for MAC string added > > --- > > O

[dpdk-dev] [PATCH v2] net/tap: allow user mac to be passed as args

2017-12-21 Thread Vipin Varghese
Added fixes for user TAP user MAC 1) user format to RTE_PMD_REGISTER_PARAM_STRING 2) TAP to the RTE_LOG in absence of dynamic RTE_LOG 3) Boundary case for MAC string added --- Other Details: 1) not to extract "string to mac" conversion t