On 2/5/2018 3:54 PM, Pascal Mazon wrote:
> From: Vipin Varghese <[email protected]>
>
> Allow TAP PMD to pass user desired MAC address as argument.
> The argument value is processed as string, where each 2 bytes
> are converted to HEX MAC address after validation.
>
> Signed-off-by: Vipin Varghese <[email protected]>
> Signed-off-by: Pascal Mazon <[email protected]>
<...>
@@ -278,15 +282,8 @@ tap_rx_offload_get_queue_capa(void)
> static bool
> tap_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads)
> {
> - uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads;
> - uint64_t queue_supp_offloads = tap_rx_offload_get_queue_capa();
> - uint64_t port_supp_offloads = tap_rx_offload_get_port_capa();
> -
> - if ((offloads & (queue_supp_offloads | port_supp_offloads)) !=
> - offloads)
> - return false;
> - if ((port_offloads ^ offloads) & port_supp_offloads)
> - return false;
> + (void)dev;
> + (void)offloads;
This part seems unrelated with the patch?
