Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-27 Thread Gaëtan Rivet
Hi Ferruh, On Mon, Mar 27, 2017 at 04:08:51PM +0100, Ferruh Yigit wrote: On 3/3/2017 3:40 PM, Gaetan Rivet wrote: Most ConnectX-3 adapters expose two physical ports on a single PCI bus address. Add a new port parameter allowing the user to choose either or both physical ports to be used by the

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-27 Thread Ferruh Yigit
On 3/3/2017 3:40 PM, Gaetan Rivet wrote: > Most ConnectX-3 adapters expose two physical ports on a single PCI bus > address. > > Add a new port parameter allowing the user to choose > either or both physical ports to be used by the application. > > This parameter is used as follows: > > Selectin

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-20 Thread Adrien Mazarguil
Hi Ferruh, On Mon, Mar 20, 2017 at 01:24:36PM +, Ferruh Yigit wrote: > On 3/16/2017 11:04 AM, Adrien Mazarguil wrote: > > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: > >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus > >> address. > >> > >> Add a new

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-20 Thread Ferruh Yigit
On 3/16/2017 11:04 AM, Adrien Mazarguil wrote: > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus >> address. >> >> Add a new port parameter allowing the user to choose >> either or both physical ports to be used

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-16 Thread Adrien Mazarguil
On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: > Most ConnectX-3 adapters expose two physical ports on a single PCI bus > address. > > Add a new port parameter allowing the user to choose > either or both physical ports to be used by the application. > > This parameter is used as f

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-11 Thread Legacy, Allain
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Friday, March 10, 2017 12:12 PM > The first solution might be interesting, however it makes this option > dependent on two defines instead of one. If one had to change the > default MAX_PHYS_PORT value for mlx

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Gaëtan Rivet
slight additional remark below. On Fri, Mar 10, 2017 at 06:11:59PM +0100, Gaëtan Rivet wrote: Hey, thanks for reading. On Fri, Mar 10, 2017 at 04:24:32PM +, Legacy, Allain wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet Sent: Friday, Marc

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Gaëtan Rivet
Hey, thanks for reading. On Fri, Mar 10, 2017 at 04:24:32PM +, Legacy, Allain wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet Sent: Friday, March 03, 2017 10:40 AM ... + errno = 0; + tmp = strtoul(val, NULL, 0); The robustnes

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2017 16:24:32 + "Legacy, Allain" wrote: > The robustness of the strtoul() could be improved with something like the > following to catch non-integer characters following the port number. > > char *end = NULL; > tmp = strtoull(val, &end, 0); > if ((val[0] == '\0')

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-10 Thread Legacy, Allain
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Friday, March 03, 2017 10:40 AM ... > + errno = 0; > + tmp = strtoul(val, NULL, 0); The robustness of the strtoul() could be improved with something like the following to catch non-inte

[dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-03 Thread Gaetan Rivet
Most ConnectX-3 adapters expose two physical ports on a single PCI bus address. Add a new port parameter allowing the user to choose either or both physical ports to be used by the application. This parameter is used as follows: Selecting only the second port: -w 00:00.0,port=1 Selecting bot