Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-05-08 Thread Thomas Monjalon
08/05/2019 22:22, Arnon Warshavsky: > > I am preparing a deprecation notice for rte_eal_remote_launch > > and rte_metrics_init. > > > hmm, I followed panic and not exit, so missed rte_metrics_init. > rte_eal_remote_launch currently returns int. what deprecation goes there? We probably need to add

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-05-08 Thread Arnon Warshavsky
> > > > I am preparing a deprecation notice for rte_eal_remote_launch > and rte_metrics_init. > > > hmm, I followed panic and not exit, so missed rte_metrics_init. rte_eal_remote_launch currently returns int. what deprecation goes there?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-05-08 Thread Thomas Monjalon
07/05/2019 11:57, Arnon Warshavsky: > > > > > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > > perhaps it would be a problem if the content of the fifo changed but it is > > not > > the case. > > > > Should I move this patch to deferred or reject? It can be set to "reje

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-05-07 Thread Arnon Warshavsky
> > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > perhaps it would be a problem if the content of the fifo changed but it is > not > the case. > Should I move this patch to deferred or reject?

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Ferruh Yigit
On 4/29/2019 5:24 PM, Stephen Hemminger wrote: > On Mon, 29 Apr 2019 10:28:36 +0100 > Ferruh Yigit wrote: > >>> >>> +* kni: Modify function return value for the sake of removing rte_panic + from the init sequence in version 19.08. + - In ``lib/librte_kni/rte_kni_fifo.h``

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2019 10:28:36 +0100 Ferruh Yigit wrote: > > > > > >> +* kni: Modify function return value for the sake of removing rte_panic > >> + from the init sequence in version 19.08. > >> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace > >> +``static void kni_fifo_init(struct

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Ferruh Yigit
On 4/28/2019 5:23 PM, Stephen Hemminger wrote: > On Sun, 28 Apr 2019 17:58:48 +0300 > Arnon Warshavsky wrote: > > These deprecation notices are unnecessary. These are not public API's. +1 > >> +* eal: Modify function return value for the sake of removing rte_panic >> + from the init sequ

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-28 Thread Stephen Hemminger
On Sun, 28 Apr 2019 17:58:48 +0300 Arnon Warshavsky wrote: These deprecation notices are unnecessary. These are not public API's. > +* eal: Modify function return value for the sake of removing rte_panic > + from the init sequence in version 19.08. > + - In ``lib/librte_eal/common/eal_thr

[dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-28 Thread Arnon Warshavsky
For the purpose of removing instances of rte_panic from the init sequence, some void functions need to change to return an error code.The planned modifications of 19.08 require to change one eal function and one kni function. Signed-off-by: Arnon Warshavsky --- doc/guides/rel_notes/deprecation.r