On 4/28/2019 5:23 PM, Stephen Hemminger wrote: > On Sun, 28 Apr 2019 17:58:48 +0300 > Arnon Warshavsky <ar...@qwilt.com> wrote: > > These deprecation notices are unnecessary. These are not public API's.
+1 > >> +* eal: Modify function return value for the sake of removing rte_panic >> + from the init sequence in version 19.08. >> + - In ``lib/librte_eal/common/eal_thread.h`` replace >> + ``void eal_thread_init_master(unsigned lcore_id)`` >> + to return ``int`` > > This function is never exported (see rte_eal_version.map) and therefore be > marked private to the EAL, and not a public API. > > >> +* kni: Modify function return value for the sake of removing rte_panic >> + from the init sequence in version 19.08. >> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace >> + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)`` >> + to return ``int`` > > This is not a public API really so no deprecation needed. > It is just an include file used internally by library and the driver. >
