[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Panu Matilainen
On 03/04/2015 03:31 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: >> On 03/04/2015 03:08 PM, Bruce Richardson wrote: >>> On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Panu Matilainen
On 03/04/2015 03:08 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: >> On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: >>> On 03/04/2015 11:24 AM, Thomas Monjalon wrote: Hi Panu, 2015-03-04 08:17, Panu Matilainen: > With

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread David Marchand
On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > > Right, but then there's "ivshmem" that doesn't fit that description > either > > AFAICS. > > Ah, yes, forgotten about that one! :-) Well, this is out of scope, but this

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Thomas Monjalon
2015-03-04 13:49, Bruce Richardson: > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > > On 03/04/2015 03:31 PM, Bruce Richardson wrote: > > >On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: > > >>On 03/04/2015 03:08 PM, Bruce Richardson wrote: > > >>>On Wed, Mar 0

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 02:57:50PM +0100, David Marchand wrote: > On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson intel.com > > wrote: > > > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > > > Right, but then there's "ivshmem" that doesn't fit that description > > either > > >

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > On 03/04/2015 03:31 PM, Bruce Richardson wrote: > >On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: > >>On 03/04/2015 03:08 PM, Bruce Richardson wrote: > >>>On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: > On 03/04/2015 03:08 PM, Bruce Richardson wrote: > >On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: > >>On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > >>>On 03/04/2015 11:24 AM, Thomas Monjalon wrote:

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: > On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > > >Hi Panu, > > > > > >2015-03-04 08:17, Panu Matilainen: > > >>With symbol versioning its vital that developers test

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Panu Matilainen
On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > Hi Panu, > > 2015-03-04 08:17, Panu Matilainen: >> With symbol versioning its vital that developers test their code in >> shared library mode, otherwise we'll be playing "add the forgotten >> symbol export" from here to eternity. > > Yes we must impr

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Thomas Monjalon
2015-03-04 13:05, Panu Matilainen: > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > > Hi Panu, > > > > 2015-03-04 08:17, Panu Matilainen: > >> With symbol versioning its vital that developers test their code in > >> shared library mode, otherwise we'll be playing "add the forgotten > >> symbol ex

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 10:24:44AM +0100, Thomas Monjalon wrote: > Hi Panu, > > 2015-03-04 08:17, Panu Matilainen: > > With symbol versioning its vital that developers test their code in > > shared library mode, otherwise we'll be playing "add the forgotten > > symbol export" from here to eternity

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Thomas Monjalon
Hi Panu, 2015-03-04 08:17, Panu Matilainen: > With symbol versioning its vital that developers test their code in > shared library mode, otherwise we'll be playing "add the forgotten > symbol export" from here to eternity. Yes we must improve the sanity checks. A lot of options must be tested (or

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Panu Matilainen
With symbol versioning its vital that developers test their code in shared library mode, otherwise we'll be playing "add the forgotten symbol export" from here to eternity. By defaulting to shared we should catch more of these cases early, but without taking away anybodys ability to build static.

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 Thread Neil Horman
On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > >Hi Panu, > > > >2015-03-04 08:17, Panu Matilainen: > >>With symbol versioning its vital that developers test their code in > >>shared library mode, otherwise we'll be playing "add th