Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-03 Thread David Marchand
On Thu, Feb 2, 2023 at 4:56 PM Tyler Retzlaff wrote: > > On Thu, Feb 02, 2023 at 10:14:41AM +0100, David Marchand wrote: > > Hello Tyler, > > > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > > wrote: > > > > > > hi folks, > > > > > > i think this one can probably be merged? > > > > > > Serie

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-03 Thread David Marchand
On Thu, Feb 2, 2023 at 4:57 PM Tyler Retzlaff wrote: > > > I like the cleanup of rte_common.h and additional unit tests, but the > > > MSVC bits don't belong here. > > > Please move them in your MSVC enablement series > > > https://patchwork.dpdk.org/project/dpdk/list/?series=26662&state=%2A&archi

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 11:56:41AM +0100, David Marchand wrote: > On Thu, Feb 2, 2023 at 10:14 AM David Marchand > wrote: > > > > Hello Tyler, > > > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > > wrote: > > > > > > hi folks, > > > > > > i think this one can probably be merged? > > > > > >

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 10:14:41AM +0100, David Marchand wrote: > Hello Tyler, > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > wrote: > > > > hi folks, > > > > i think this one can probably be merged? > > > > Series-acked-by: Morten Brørup > > Series-acked-by: Bruce Richardson > > patch 1

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 10:14 AM David Marchand wrote: > > Hello Tyler, > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > wrote: > > > > hi folks, > > > > i think this one can probably be merged? > > > > Series-acked-by: Morten Brørup > > Series-acked-by: Bruce Richardson > > patch 1/2 Acked

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread David Marchand
Hello Tyler, On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff wrote: > > hi folks, > > i think this one can probably be merged? > > Series-acked-by: Morten Brørup > Series-acked-by: Bruce Richardson > patch 1/2 Acked-by: Ferruh Yigit I like the cleanup of rte_common.h and additional unit tests

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-20 Thread Tyler Retzlaff
hi folks, i think this one can probably be merged? Series-acked-by: Morten Brørup Series-acked-by: Bruce Richardson patch 1/2 Acked-by: Ferruh Yigit thanks! On Tue, Jan 10, 2023 at 11:46:39AM -0800, Tyler Retzlaff wrote: > v6: > * remove stray #include > > v5: > * fix implementation of

[PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-01-10 Thread Tyler Retzlaff
v6: * remove stray #include v5: * fix implementation of msvc versions of rte_clz{32,64} incorrect use of _BitscanReverse{,64} index. * fix and expand unit test to exercise full range of counting over uint{32,64}_t input values. (which would have caught above mistake). * reduce