On Thu, Feb 2, 2023 at 10:14 AM David Marchand <david.march...@redhat.com> wrote: > > Hello Tyler, > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > <roret...@linux.microsoft.com> wrote: > > > > hi folks, > > > > i think this one can probably be merged? > > > > Series-acked-by: Morten Brørup <m...@smartsharesystems.com> > > Series-acked-by: Bruce Richardson <bruce.richard...@intel.com> > > patch 1/2 Acked-by: Ferruh Yigit <ferruh.yi...@amd.com> > > I like the cleanup of rte_common.h and additional unit tests, but the > MSVC bits don't belong here. > Please move them in your MSVC enablement series > https://patchwork.dpdk.org/project/dpdk/list/?series=26662&state=%2A&archive=both.
Addendum, running the series through my checks, I can see that test_bitcount.c is left unattended wrt the MAINTAINERS file. app/test/test_bitcount.c must be put under the "EAL API and common code" section. Thanks. -- David Marchand
