On Thu, Feb 2, 2023 at 4:57 PM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > > I like the cleanup of rte_common.h and additional unit tests, but the > > > MSVC bits don't belong here. > > > Please move them in your MSVC enablement series > > > https://patchwork.dpdk.org/project/dpdk/list/?series=26662&state=%2A&archive=both. > > > > Addendum, running the series through my checks, I can see that > > test_bitcount.c is left unattended wrt the MAINTAINERS file. > > app/test/test_bitcount.c must be put under the "EAL API and common > > code" section. > > is this an automated check i should have run prior to submission?
The script is devtools/check-maintainers.sh. But unfortunately it is not run in the CI as its author never made it reliable enough: it has false positives / known issues / accepted issues. Users (I guess Thomas and I, maybe some subtree maintainers) keep a local reference of this script output, and compare against it. This is something that is rarely needed: in general additions are done as a single component in MAINTAINERS, so people naturally add themselves with the top level directory, and that's it. So I guess our current check is good enough. > > either way i'll fix that up, sorry for the mistake. No worries, this is not something you could easily find unless grepping and looking how things were done for other unit tests. -- David Marchand
