RE: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency

2024-01-10 Thread Chautru, Nicolas
c: dev@dpdk.org; gak...@marvell.com; Rix, Tom ; > maxime.coque...@redhat.com; Chautru, Nicolas ; > Zhang, Qi Z > Subject: Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for > consistency > > On Fri, 5 Jan 2024 13:15:16 -0800 > Hernan Vargas wrote: > > > +#

Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency

2024-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2024 13:15:16 -0800 Hernan Vargas wrote: > +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000) Just my opinion, no need it doesn't have to change but. These variable names are getting quite long which doesn't improve readability.

[PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency

2024-01-05 Thread Hernan Vargas
Rename generic functions and constants using the FPGA 5GNR prefix naming to prepare for code reuse for new FPGA implementation variant. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 117 +++-- .../fpga_5gnr_fe